mm: fix typo of cache_alloc_zspage()

PATCH New Xishi Qiu 3 participants 12 messages Dec 29, 2016 – Jan 6, 2017

Subsystems (2)

Memory management Zsmalloc compressed slab memory allocator

lore

Share & tools

lore

Xishi Qiu

author

2016-12-29 02:07 UTC #0 lore raw

Signed-off-by Xishi Qiu <[email protected]>

---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

mm/zsmalloc.c +1 -1

index 9cc3c0b..2d6c92e 100644
@@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
 	return kmem_cache_alloc(pool->zspage_cachep,
 			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
-};
+}
 
 static void cache_free_zspage(struct zs_pool *pool, struct zspage *zspage)
 {

Signature · 8 lines

1.8.3.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Minchan Kim

maintainer

2016-12-29 06:44 UTC #1 lore raw

Quoted 10 lines · Xishi Qiu

Signed-off-by Xishi Qiu <[email protected]>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/zsmalloc.c +0 -0
index 9cc3c0b..2d6c92e 100644

mm/zsmalloc.c static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags) · line 367

Quoted 5 lines

mm/zsmalloc.c +1 -1

@@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
 	return kmem_cache_alloc(pool->zspage_cachep,
 			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
-};
+}

Although it's trivial, we need descritpion.
Please, could you resend to Andrew Morton with filling description?

Andrew Morton <[email protected]>

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Sergey Senozhatsky

2016-12-29 06:51 UTC #2 lore raw

Quoted 6 lines · Minchan Kim

Quoted 5 lines · Xishi Qiu
Signed-off-by Xishi Qiu <[email protected]>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 13 lines

mm/zsmalloc.c static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags) · line 367
Quoted 10 lines
mm/zsmalloc.c +1 -1
index 9cc3c0b..2d6c92e 100644
@@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
 	return kmem_cache_alloc(pool->zspage_cachep,
 			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
-};
+}
Although it's trivial, we need descritpion.
Please, could you resend to Andrew Morton with filling description?

I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday later.

-ss

Minchan Kim

maintainer

2016-12-29 06:59 UTC #3 lore raw

Hi Sergey,

Quoted 21 lines · Sergey Senozhatsky

Quoted 6 lines · Minchan Kim
Quoted 5 lines · Xishi Qiu
Signed-off-by Xishi Qiu <[email protected]>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
mm/zsmalloc.c static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags) · line 367
Quoted 10 lines
mm/zsmalloc.c +1 -1
index 9cc3c0b..2d6c92e 100644
@@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
 	return kmem_cache_alloc(pool->zspage_cachep,
 			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
-};
+}
Although it's trivial, we need descritpion.
Please, could you resend to Andrew Morton with filling description?

Quoted 2 lines

I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday later.

Xishi spent his time to make the patch(review,create/send). And I want to give a credit to him. :)

Thanks.

Sergey Senozhatsky

2016-12-29 07:33 UTC #4 lore raw

Hello,

On (12/29/16 15:59), Minchan Kim wrote:
[..]

Quoted 5 lines

Quoted 2 lines
I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday later.
Xishi spent his time to make the patch(review,create/send). And I want to give a credit to him. :)

sure, I didn't mean "let's seize the credit" :) my reasoning was that that patch hardly can be counted even as trivial. per documentation:

: Trivial patches must qualify for one of the following rules:
:
: - Spelling fixes in documentation
: - Spelling fixes for errors which could break :manpage:grep(1) : - Warning fixes (cluttering with useless warnings is bad) : - Compilation fixes (only if they are actually correct)
: - Runtime fixes (only if they actually fix things)
: - Removing use of deprecated functions/macros
: - Contact detail and documentation fixes
: - Non-portable code replaced by portable code (even in arch-specific,
: since people copy, as long as it's trivial)
: - Any fix by the author/maintainer of the file (ie. patch monkey
: in re-transmission mode)

hence was my question. we can have it as "p.s. in this patch we also remove XYZ reported by Xishi Qiu".

but up to you.

for instance, we can have Xishi's fix up as part of this "fix documentation typos" patch. which can be counted in as trivial.

---

mm/zsmalloc.c +3 -3

index 9cc3c0b2c2c1..af7cd90c26f7 100644
@@ -25,7 +25,7 @@
  * Usage of struct page flags:
  *     PG_private: identifies the first component page
  *     PG_private2: identifies the last component page
- *     PG_owner_priv_1: indentifies the huge component page
+ *     PG_owner_priv_1: identifies the huge component page
  *
  */

@@ -65,7 +65,7 @@
 #define ZS_ALIGN               8
 
 /*
- * A single 'zspage' is composed of up to 2^N discontiguous 0-order (single)
+ * A single 'zspage' is composed of up to 2^N discontinuous 0-order (single)
  * pages. ZS_MAX_ZSPAGE_ORDER defines upper limit on N.
  */
 #define ZS_MAX_ZSPAGE_ORDER 2

@@ -2383,7 +2383,7 @@ struct zs_pool *zs_create_pool(const char *name)
                goto err;
 
        /*
-        * Iterate reversly, because, size of size_class that we want to use
+        * Iterate reversely, because, size of size_class that we want to use
         * for merging should be larger or equal to current size.
         */
        for (i = zs_size_classes - 1; i >= 0; i--) {

---

-ss

Minchan Kim

maintainer

2016-12-29 07:56 UTC #5 lore raw

Quoted 32 lines · Sergey Senozhatsky

Hello,
On (12/29/16 15:59), Minchan Kim wrote:
[..]
Quoted 5 lines
Quoted 2 lines
I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday later.
Xishi spent his time to make the patch(review,create/send). And I want to give a credit to him. :)
sure, I didn't mean "let's seize the credit" :) my reasoning was that that patch hardly can be counted even as trivial. per documentation:
: Trivial patches must qualify for one of the following rules:
:
: - Spelling fixes in documentation
: - Spelling fixes for errors which could break :manpage:grep(1) : - Warning fixes (cluttering with useless warnings is bad) : - Compilation fixes (only if they are actually correct)
: - Runtime fixes (only if they actually fix things)
: - Removing use of deprecated functions/macros
: - Contact detail and documentation fixes
: - Non-portable code replaced by portable code (even in arch-specific,
: since people copy, as long as it's trivial)
: - Any fix by the author/maintainer of the file (ie. patch monkey
: in re-transmission mode)
hence was my question. we can have it as "p.s. in this patch we also remove XYZ reported by Xishi Qiu".

Quoted 6 lines

but up to you.
for instance, we can have Xishi's fix up as part of this "fix documentation typos" patch. which can be counted in as trivial.

Xishi, Could you send your patch with fixing ones Sergey pointed out if Sergey doesn't mind?

You should include Sergey's SOB, too.

Quoted 18 lines

---

mm/zsmalloc.c +1 -1

index 9cc3c0b2c2c1..af7cd90c26f7 100644
@@ -25,7 +25,7 @@
  * Usage of struct page flags:
  *     PG_private: identifies the first component page
  *     PG_private2: identifies the last component page
- *     PG_owner_priv_1: indentifies the huge component page
+ *     PG_owner_priv_1: identifies the huge component page
  *
  */

mm/zsmalloc.c line 68

Quoted 5 lines

mm/zsmalloc.c +1 -1

@@ -65,7 +65,7 @@
 #define ZS_ALIGN               8
 
 /*
- * A single 'zspage' is composed of up to 2^N discontiguous 0-order (single)
+ * A single 'zspage' is composed of up to 2^N discontinuous 0-order (single)

Hmm, discontinuous is right?
I'm not a native but discontiguos is wrong? "contiguous" was used mm part widely.

Quoted 16 lines

mm/zsmalloc.c +1 -2

  * pages. ZS_MAX_ZSPAGE_ORDER defines upper limit on N.
  */
 #define ZS_MAX_ZSPAGE_ORDER 2

@@ -2383,7 +2383,7 @@ struct zs_pool *zs_create_pool(const char *name)
                goto err;
 
        /*
-        * Iterate reversly, because, size of size_class that we want to use
+        * Iterate reversely, because, size of size_class that we want to use
         * for merging should be larger or equal to current size.
         */
        for (i = zs_size_classes - 1; i >= 0; i--) {
 
 
---

Quoted 7 lines

	-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Sergey Senozhatsky

Reviewed-by

2016-12-29 08:03 UTC #6 lore raw

Quoted 5 lines · Minchan Kim

Quoted 2 lines
for instance, we can have Xishi's fix up as part of this "fix documentation typos" patch. which can be counted in as trivial.
Xishi, Could you send your patch with fixing ones Sergey pointed out if Sergey doesn't mind?

I don't.

Reviewed-by Sergey Senozhatsky <[email protected]>

will be more than enough (well, to me).

Quoted 5 lines

Quoted 2 lines
- * A single 'zspage' is composed of up to 2^N discontiguous 0-order (single)
+ * A single 'zspage' is composed of up to 2^N discontinuous 0-order (single)
Hmm, discontinuous is right?
I'm not a native but discontiguos is wrong? "contiguous" was used mm part widely.

oh, you're definitely much closer to native speaker than `aspell' tool! you're right. Xishi, please drop that 'discontiguous' "correction". sorry for that.

-ss

Xishi Qiu

author

2016-12-29 10:34 UTC #7 lore raw

In reply to Minchan Kim

Quoted 37 lines · Minchan Kim

Quoted 36 lines · Sergey Senozhatsky
Hello,
On (12/29/16 15:59), Minchan Kim wrote:
[..]
Quoted 5 lines
Quoted 2 lines
I don't know... do we want to have it as a separate patch? may be we can fold it into some other patch someday later.
Xishi spent his time to make the patch(review,create/send). And I want to give a credit to him. :)
sure, I didn't mean "let's seize the credit" :) my reasoning was that that patch hardly can be counted even as trivial. per documentation:
: Trivial patches must qualify for one of the following rules:
:
: - Spelling fixes in documentation
: - Spelling fixes for errors which could break :manpage:grep(1) : - Warning fixes (cluttering with useless warnings is bad) : - Compilation fixes (only if they are actually correct)
: - Runtime fixes (only if they actually fix things)
: - Removing use of deprecated functions/macros
: - Contact detail and documentation fixes
: - Non-portable code replaced by portable code (even in arch-specific,
: since people copy, as long as it's trivial)
: - Any fix by the author/maintainer of the file (ie. patch monkey
: in re-transmission mode)
hence was my question. we can have it as "p.s. in this patch we also remove XYZ reported by Xishi Qiu".
but up to you.

Quoted 8 lines

Quoted 2 lines
for instance, we can have Xishi's fix up as part of this "fix documentation typos" patch. which can be counted in as trivial.
Xishi, Could you send your patch with fixing ones Sergey pointed out if Sergey doesn't mind?
You should include Sergey's SOB, too.

Hi, Minchan and Sergey,

OK, but I will have a vacation soon, so could you just add that typo in your patch? or I will resend v3 several days later.

Thanks
Xishi Qiu

Quoted 54 lines

Quoted 18 lines

---

mm/zsmalloc.c +1 -1

index 9cc3c0b2c2c1..af7cd90c26f7 100644
@@ -25,7 +25,7 @@
  * Usage of struct page flags:
  *     PG_private: identifies the first component page
  *     PG_private2: identifies the last component page
- *     PG_owner_priv_1: indentifies the huge component page
+ *     PG_owner_priv_1: identifies the huge component page
  *
  */

mm/zsmalloc.c line 68

Quoted 5 lines

mm/zsmalloc.c +1 -1

@@ -65,7 +65,7 @@
 #define ZS_ALIGN               8
 
 /*
- * A single 'zspage' is composed of up to 2^N discontiguous 0-order (single)
+ * A single 'zspage' is composed of up to 2^N discontinuous 0-order (single)

Hmm, discontinuous is right?
I'm not a native but discontiguos is wrong? "contiguous" was used mm part widely.

Quoted 16 lines

mm/zsmalloc.c +1 -2

  * pages. ZS_MAX_ZSPAGE_ORDER defines upper limit on N.
  */
 #define ZS_MAX_ZSPAGE_ORDER 2

@@ -2383,7 +2383,7 @@ struct zs_pool *zs_create_pool(const char *name)
                goto err;
 
        /*
-        * Iterate reversly, because, size of size_class that we want to use
+        * Iterate reversely, because, size of size_class that we want to use
         * for merging should be larger or equal to current size.
         */
        for (i = zs_size_classes - 1; i >= 0; i--) {
 
 
---

Quoted 7 lines

	-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Sergey Senozhatsky

2016-12-30 01:07 UTC #8 lore raw

Hello,

Quoted 4 lines · Xishi Qiu

Hi, Minchan and Sergey,
OK, but I will have a vacation soon, so could you just add that typo in your patch? or I will resend v3 several days later.

works for me. the patch is trivial, so I definitely can wait for v3. if there is a chance to find additional trivial corrections/tweaks then I wouldn't mind to include them into v3 as well. I just want to keep the trivial patch flow at min level.

have a good vacation.

-ss

Xishi Qiu

author

2016-12-29 07:54 UTC #9 lore raw

PATCH v2 1/1 mm: fix typo of cache_alloc_zspage()

In reply to Xishi Qiu

Delete extra semicolon, it was introduced in
3783689 zsmalloc: introduce zspage structure

Signed-off-by Xishi Qiu <[email protected]>

---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

mm/zsmalloc.c +1 -1

index 9cc3c0b..2d6c92e 100644
@@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
 	return kmem_cache_alloc(pool->zspage_cachep,
 			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
-};
+}
 
 static void cache_free_zspage(struct zs_pool *pool, struct zspage *zspage)
 {

Signature · 1 line

1.8.3.1

Xishi Qiu

author

2017-01-06 04:11 UTC #10 lore raw

PATCH 1/1 mm: fix some typos in mm/zsmalloc.c

Delete extra semicolon, and fix some typos.

Signed-off-by Xishi Qiu <[email protected]>

Reviewed-by Sergey Senozhatsky <[email protected]>

---
 mm/zsmalloc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

mm/zsmalloc.c +3 -3

index 9cc3c0b..a1f2498 100644
@@ -25,7 +25,7 @@
  * Usage of struct page flags:
  *	PG_private: identifies the first component page
  *	PG_private2: identifies the last component page
- *	PG_owner_priv_1: indentifies the huge component page
+ *	PG_owner_priv_1: identifies the huge component page
  *
  */

@@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
 	return kmem_cache_alloc(pool->zspage_cachep,
 			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
-};
+}
 
 static void cache_free_zspage(struct zs_pool *pool, struct zspage *zspage)
 {

@@ -2383,7 +2383,7 @@ struct zs_pool *zs_create_pool(const char *name)
 		goto err;
 
 	/*
-	 * Iterate reversly, because, size of size_class that we want to use
+	 * Iterate reversely, because, size of size_class that we want to use
 	 * for merging should be larger or equal to current size.
 	 */
 	for (i = zs_size_classes - 1; i >= 0; i--) {

Signature · 1 line

1.8.3.1

Minchan Kim

maintainer Acked-by on v1 1/1

2017-01-06 04:38 UTC #11 lore raw

Re: [PATCH] mm: fix some typos in mm/zsmalloc.c

Quoted 4 lines · Xishi Qiu

Delete extra semicolon, and fix some typos.
Signed-off-by Xishi Qiu <[email protected]>
Reviewed-by Sergey Senozhatsky <[email protected]>

Acked-by Minchan Kim <[email protected]>

Thanks.