Skip to contentSkip to conversation

st.c: Improve sense output

PATCH In review Luben Tuikov 2 participants 2 messages Nov 4, 2006 – Nov 7, 2006

Subsystems (2)
SCSI SCSI tape driver
lore
Share & tools
lore

Luben Tuikov

author
#0 lore raw

PATCH 1/1 st.c: Improve sense output

Quoted 1 line

From this:

st0: Error with sense data: <6>st: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb

To this:
st0: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb

Signed-off-by Luben Tuikov <[email protected]>
---
 drivers/scsi/st.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

March 24, 2006!

Luben

drivers/scsi/st.c +3 -4
index 29d7319..2a59635 100644
@@ -368,7 +368,7 @@ static int st_chk_result(struct scsi_tap
 		       SRpnt->cmd[0], SRpnt->cmd[1], SRpnt->cmd[2],
 		       SRpnt->cmd[3], SRpnt->cmd[4], SRpnt->cmd[5]);
 		if (cmdstatp->have_sense)
-			 __scsi_print_sense("st", SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
+			 __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
 	} ) /* end DEB */
 	if (!debugging) { /* Abnormal conditions for tape */
 		if (!cmdstatp->have_sense)

@@ -384,9 +384,8 @@ static int st_chk_result(struct scsi_tap
 			 scode != VOLUME_OVERFLOW &&
 			 SRpnt->cmd[0] != MODE_SENSE &&
 			 SRpnt->cmd[0] != TEST_UNIT_READY) {
-				printk(KERN_WARNING "%s: Error with sense data: ", name);
-				__scsi_print_sense("st", SRpnt->sense,
-						   SCSI_SENSE_BUFFERSIZE);
+
+			__scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
 		}
 	}
Signature · 1 line
1.4.3.3.g8478
#1 lore raw
Quoted 8 lines · Luben Tuikov
Quoted 1 line

From this:

st0: Error with sense data: <6>st: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb

To this:
st0: Current: sense key: Illegal Request
Additional sense: Invalid field in cdb

Quoted 7 lines
Signed-off-by Luben Tuikov <[email protected]>
---
 drivers/scsi/st.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

March 24, 2006!

This is already in the official kernel.

Signature · 1 line
Kai