Skip to contentSkip to conversation

network: remove unnecessary check for rsh in scripts

PATCH New Petr Vorel 2 participants 2 messages Dec 19, 2016 – Jan 13, 2017

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 network: remove unnecessary check for rsh in scripts

scripts rlogin01 and telnet01 don't use rsh directly, but via tst_rhost_run. This means that ssh or netns can be used instead of rsh.

IMHO these checks should be done in tst_rhost_run().

---
 testcases/network/tcp_cmds/rlogin/rlogin01 | 2 +-
 testcases/network/tcp_cmds/telnet/telnet01 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
testcases/network/tcp_cmds/rlogin/rlogin01 +1 -1
index f53b1a88a..162b8f0d8 100755
@@ -24,7 +24,7 @@ TST_TOTAL=1
 
 setup()
 {
-	tst_check_cmds rlogin expect rsh
+	tst_check_cmds rlogin expect
 
 	if [ -z $RUSER ]; then
 		RUSER=root
testcases/network/tcp_cmds/telnet/telnet01 +1 -1
index a1609f0f6..f2f2444a8 100755
@@ -24,7 +24,7 @@ TST_TOTAL=1
 
 setup()
 {
-	tst_check_cmds telnet expect rsh
+	tst_check_cmds telnet expect
 
 	if [ -z $RUSER ]; then
 		RUSER=root
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 network: remove unnecessary check for rsh in scripts

Hi,

Quoted 2 lines · Petr Vorel

scripts rlogin01 and telnet01 don't use rsh directly, but via tst_rhost_run. This means that ssh or netns can be used instead of rsh.

Applied, thanks!

Best regards,
Alexey