network: remove unnecessary check for rsh in scripts
PATCH 1/1 network: remove unnecessary check for rsh in scripts
scripts rlogin01 and telnet01 don't use rsh directly, but via tst_rhost_run. This means that ssh or netns can be used instead of rsh.
IMHO these checks should be done in tst_rhost_run().
Signed-off-by Petr Vorel <[email protected]>
--- testcases/network/tcp_cmds/rlogin/rlogin01 | 2 +- testcases/network/tcp_cmds/telnet/telnet01 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
testcases/network/tcp_cmds/rlogin/rlogin01 +1 -1
@@ -24,7 +24,7 @@ TST_TOTAL=1 setup() { - tst_check_cmds rlogin expect rsh + tst_check_cmds rlogin expect if [ -z $RUSER ]; then RUSER=root
testcases/network/tcp_cmds/telnet/telnet01 +1 -1
@@ -24,7 +24,7 @@ TST_TOTAL=1 setup() { - tst_check_cmds telnet expect rsh + tst_check_cmds telnet expect if [ -z $RUSER ]; then RUSER=root
Signature · 1 line
2.11.0
Alexey Kodanev
AppliedPATCH 1/1 network: remove unnecessary check for rsh in scripts
Hi,
Quoted 2 lines · Petr Vorel
scripts rlogin01 and telnet01 don't use rsh directly, but via
tst_rhost_run. This means that ssh or netns can be used instead of rsh.
Applied, thanks!
Best regards,
Alexey