Host information userspace version
Subsystems (2)
cover Host information userspace version
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918
Thanks,
Gal
Gal Pressman (2):
RDMA/efa: Move host info set to first ucontext allocation RDMA/efa: Report userspace version in host info
drivers/infiniband/hw/efa/efa.h | 7 +++++++ drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 3 +++ drivers/infiniband/hw/efa/efa_main.c | 6 +++--- drivers/infiniband/hw/efa/efa_verbs.c | 3 +++ include/uapi/rdma/efa-abi.h | 3 ++- 5 files changed, 18 insertions(+), 4 deletions(-)
base-commit: e246b7c035d74abfb3507fa10082d0c42cc016c3
Signature · 1 line
2.30.0
PATCH 1/2 RDMA/efa: Move host info set to first ucontext allocation
Downstream patch will require the userspace version which is passed as part of ucontext allocation. Move the host info set there and make sure it's only called once (on the first allocation).
--- drivers/infiniband/hw/efa/efa.h | 7 +++++++ drivers/infiniband/hw/efa/efa_main.c | 4 +--- drivers/infiniband/hw/efa/efa_verbs.c | 3 +++ 3 files changed, 11 insertions(+), 3 deletions(-)
drivers/infiniband/hw/efa/efa.h +7 -0
@@ -45,6 +45,11 @@ struct efa_stats {atomic64_t keep_alive_rcvd; }; +enum { +EFA_FLAGS_HOST_INFO_SET_BIT , +EFA_FLAGS_NUM , +}; +struct efa_dev {struct ib_device ibdev;struct efa_com_dev edev;
@@ -62,6 +67,7 @@ struct efa_dev {struct efa_irq admin_irq;struct efa_stats stats; +DECLARE_BITMAP (flags,EFA_FLAGS_NUM ); };struct efa_ucontext {
@@ -117,6 +123,7 @@ struct efa_ah {u8 id[EFA_GID_SIZE ]; }; +void efa_set_host_info (struct efa_dev *dev);int efa_query_device (struct ib_device *ibdev,struct ib_device_attr *props,struct ib_udata *udata);
drivers/infiniband/hw/efa/efa_main.c +1 -3
@@ -191,7 +191,7 @@ static void efa_stats_init(struct efa_dev *dev)atomic64_set (s,0 ); } -static void efa_set_host_info (struct efa_dev *dev) +void efa_set_host_info (struct efa_dev *dev) {struct efa_admin_set_feature_resp resp = {};struct efa_admin_set_feature_cmd cmd = {};
@@ -301,8 +301,6 @@ static int efa_ib_device_add(struct efa_dev *dev)if (err) goto err_release_doorbell_bar; -efa_set_host_info (dev); - dev->ibdev.node_type =RDMA_NODE_UNSPECIFIED ; dev->ibdev.phys_port_cnt =1 ; dev->ibdev.num_comp_vectors =1 ;
drivers/infiniband/hw/efa/efa_verbs.c +3 -0
@@ -1695,6 +1695,9 @@ int efa_alloc_ucontext(struct ib_ucontext *ibucontext, struct ib_udata *udata) goto err_out; } +if (!test_and_set_bit (EFA_FLAGS_HOST_INFO_SET_BIT , dev->flags)) +efa_set_host_info (dev); + err =efa_user_comp_handshake (ibucontext, &cmd);if (err) goto err_out;
Signature · 1 line
2.30.0
Re: [PATCH for-next 1/2] RDMA/efa: Move host info set to first ucontext allocation
Quoted 30 lines · Gal Pressman
Downstream patch will require the userspace version which is passed as part of ucontext allocation. Move the host info set there and make sure it's only called once (on the first allocation).
Reviewed-by Firas JahJah <[email protected]>Reviewed-by Leonid Feschuk <[email protected]>Signed-off-by Gal Pressman <[email protected]>--- drivers/infiniband/hw/efa/efa.h | 7 +++++++ drivers/infiniband/hw/efa/efa_main.c | 4 +--- drivers/infiniband/hw/efa/efa_verbs.c | 3 +++ 3 files changed, 11 insertions(+), 3 deletions(-)drivers/infiniband/hw/efa/efa.h +5
-0@@ -45,6 +45,11 @@ struct efa_stats {atomic64_t keep_alive_rcvd; }; +enum { +EFA_FLAGS_HOST_INFO_SET_BIT , +EFA_FLAGS_NUM , +}; +struct efa_dev {struct ib_device ibdev;struct efa_com_dev edev;
drivers/infiniband/hw/efa/efa.h struct efa_dev { · line 71
Quoted 5 lines
drivers/infiniband/hw/efa/efa.h +1
-0@@ -62,6 +67,7 @@ struct efa_dev {struct efa_irq admin_irq;struct efa_stats stats; +DECLARE_BITMAP (flags,EFA_FLAGS_NUM ); };
Why do you need such over-engineering?
What is wrong with old school "u8 flag"?
Thanks
Re: [PATCH for-next 1/2] RDMA/efa: Move host info set to first ucontext allocation
Quoted 33 lines · Leon Romanovsky
Quoted 32 lines · Gal Pressman
Downstream patch will require the userspace version which is passed as part of ucontext allocation. Move the host info set there and make sure it's only called once (on the first allocation).
Reviewed-by Firas JahJah <[email protected]>Reviewed-by Leonid Feschuk <[email protected]>Signed-off-by Gal Pressman <[email protected]>--- drivers/infiniband/hw/efa/efa.h | 7 +++++++ drivers/infiniband/hw/efa/efa_main.c | 4 +--- drivers/infiniband/hw/efa/efa_verbs.c | 3 +++ 3 files changed, 11 insertions(+), 3 deletions(-)drivers/infiniband/hw/efa/efa.h +5
-0@@ -45,6 +45,11 @@ struct efa_stats {atomic64_t keep_alive_rcvd; }; +enum { +EFA_FLAGS_HOST_INFO_SET_BIT , +EFA_FLAGS_NUM , +}; +struct efa_dev {struct ib_device ibdev;struct efa_com_dev edev;@@ -62,6 +67,7 @@ struct efa_dev {struct efa_irq admin_irq;
Quoted 6 lines
drivers/infiniband/hw/efa/efa.h struct efa_dev { · line 71
Quoted 3 lines
drivers/infiniband/hw/efa/efa.h +1
-0struct efa_stats stats; +DECLARE_BITMAP (flags,EFA_FLAGS_NUM ); };Why do you need such over-engineering?
What is wrong with old school "u8 flag"?
The main reason is for the atomic test_and_set_bit() usage, otherwise it would be an atomic flag, not u8 flag.
Re: [PATCH for-next 1/2] RDMA/efa: Move host info set to first ucontext allocation
Quoted 41 lines · Gal Pressman
Quoted 33 lines · Leon Romanovsky
Quoted 32 lines · Gal Pressman
Downstream patch will require the userspace version which is passed as part of ucontext allocation. Move the host info set there and make sure it's only called once (on the first allocation).
Reviewed-by Firas JahJah <[email protected]>Reviewed-by Leonid Feschuk <[email protected]>Signed-off-by Gal Pressman <[email protected]>--- drivers/infiniband/hw/efa/efa.h | 7 +++++++ drivers/infiniband/hw/efa/efa_main.c | 4 +--- drivers/infiniband/hw/efa/efa_verbs.c | 3 +++ 3 files changed, 11 insertions(+), 3 deletions(-)drivers/infiniband/hw/efa/efa.h +5
-0@@ -45,6 +45,11 @@ struct efa_stats {atomic64_t keep_alive_rcvd; }; +enum { +EFA_FLAGS_HOST_INFO_SET_BIT , +EFA_FLAGS_NUM , +}; +struct efa_dev {struct ib_device ibdev;struct efa_com_dev edev;@@ -62,6 +67,7 @@ struct efa_dev {struct efa_irq admin_irq;Quoted 6 lines
drivers/infiniband/hw/efa/efa.h struct efa_dev { · line 71
Quoted 3 lines
drivers/infiniband/hw/efa/efa.h +1
-0struct efa_stats stats; +DECLARE_BITMAP (flags,EFA_FLAGS_NUM ); };Why do you need such over-engineering?
What is wrong with old school "u8 flag"?
Quoted 2 lines
The main reason is for the atomic
test_and_set_bit()usage, otherwise it would be an atomic flag, not u8 flag.
But efa_dev can be opened with different applications and they can have different user space versions, but you are setting this info for the first caller only. How will it help for the debug?
Thanks
Re: [PATCH for-next 1/2] RDMA/efa: Move host info set to first ucontext allocation
Quoted 42 lines · Leon Romanovsky
Quoted 41 lines · Gal Pressman
Quoted 39 lines · Leon Romanovsky
Quoted 30 lines · Gal Pressman
Downstream patch will require the userspace version which is passed as part of ucontext allocation. Move the host info set there and make sure it's only called once (on the first allocation).
Reviewed-by Firas JahJah <[email protected]>Reviewed-by Leonid Feschuk <[email protected]>Signed-off-by Gal Pressman <[email protected]>--- drivers/infiniband/hw/efa/efa.h | 7 +++++++ drivers/infiniband/hw/efa/efa_main.c | 4 +--- drivers/infiniband/hw/efa/efa_verbs.c | 3 +++ 3 files changed, 11 insertions(+), 3 deletions(-)drivers/infiniband/hw/efa/efa.h +5
-0@@ -45,6 +45,11 @@ struct efa_stats {atomic64_t keep_alive_rcvd; }; +enum { +EFA_FLAGS_HOST_INFO_SET_BIT , +EFA_FLAGS_NUM , +}; +struct efa_dev {struct ib_device ibdev;struct efa_com_dev edev;drivers/infiniband/hw/efa/efa.h struct efa_dev { · line 71
Quoted 5 lines
drivers/infiniband/hw/efa/efa.h +1
-0@@ -62,6 +67,7 @@ struct efa_dev {struct efa_irq admin_irq;struct efa_stats stats; +DECLARE_BITMAP (flags,EFA_FLAGS_NUM ); };Why do you need such over-engineering?
What is wrong with old school "u8 flag"?
Quoted 6 lines
Quoted 2 lines
The main reason is for the atomic
test_and_set_bit()usage, otherwise it would be an atomic flag, not u8 flag.But
efa_devcan be opened with different applications and they can have different user space versions, but you are setting this info for the first caller only. How will it help for the debug?
Right, it is possible for the userspace version to change between contexts, but that's a tradeoff we're willing to take for the meantime so we don't have to send a host info command for each ucontext allocation.
We can change that in the future if that won't prove to be reliable enough.
PATCH 2/2 RDMA/efa: Report userspace version in host info
In reply to Gal PressmanReport the userspace version in the host information set feature admin command.
--- drivers/infiniband/hw/efa/efa.h | 2 +- drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 3 +++ drivers/infiniband/hw/efa/efa_main.c | 4 +++- drivers/infiniband/hw/efa/efa_verbs.c | 2 +- include/uapi/rdma/efa-abi.h | 3 ++- 5 files changed, 10 insertions(+), 4 deletions(-)
drivers/infiniband/hw/efa/efa.h +1 -1
@@ -123,7 +123,7 @@ struct efa_ah {u8 id[EFA_GID_SIZE ]; }; -void efa_set_host_info (struct efa_dev *dev); +void efa_set_host_info (struct efa_dev *dev,u8 *userspace_ver);int efa_query_device (struct ib_device *ibdev,struct ib_device_attr *props,struct ib_udata *udata);
drivers/infiniband/hw/efa/efa_admin_cmds_defs.h +3 -0
@@ -884,6 +884,9 @@ struct efa_admin_host_info {* 31:2 : reserved2 */ u32 flags; + +/* Userspace version */ +u8 userspace_ver[32 ]; };/* create_qp_cmd */
drivers/infiniband/hw/efa/efa_main.c +3 -1
@@ -191,7 +191,7 @@ static void efa_stats_init(struct efa_dev *dev)atomic64_set (s,0 ); } -void efa_set_host_info (struct efa_dev *dev) +void efa_set_host_info (struct efa_dev *dev,u8 *userspace_ver) {struct efa_admin_set_feature_resp resp = {};struct efa_admin_set_feature_cmd cmd = {};
@@ -230,6 +230,8 @@ void efa_set_host_info(struct efa_dev *dev) EFA_COMMON_SPEC_VERSION_MINOR);EFA_SET (&hinf->flags,EFA_ADMIN_HOST_INFO_INTREE ,1 );EFA_SET (&hinf->flags,EFA_ADMIN_HOST_INFO_GDR ,0 ); +strlcpy (hinf->userspace_ver, userspace_ver, +sizeof (hinf->userspace_ver));efa_com_set_feature_ex (&dev->edev, &resp, &cmd,EFA_ADMIN_HOST_INFO , hinf_dma, bufsz);
drivers/infiniband/hw/efa/efa_verbs.c +1 -1
@@ -1696,7 +1696,7 @@ int efa_alloc_ucontext(struct ib_ucontext *ibucontext, struct ib_udata *udata) }if (!test_and_set_bit (EFA_FLAGS_HOST_INFO_SET_BIT , dev->flags)) -efa_set_host_info (dev); +efa_set_host_info (dev, cmd.userspace_ver); err =efa_user_comp_handshake (ibucontext, &cmd);if (err)
include/uapi/rdma/efa-abi.h +2 -1
@@ -27,7 +27,8 @@ enum {struct efa_ibv_alloc_ucontext_cmd {__u32 comp_mask; -__u8 reserved_20[4 ]; +__u8 userspace_ver[32 ]; +__u8 reserved_120[4 ]; };enum efa_ibv_user_cmds_supp_udata {
Signature · 1 line
2.30.0
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
Gal
Anything stopping this series from being merged?
Quoted 5 lines · Gal Pressman
Quoted 4 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
Quoted 7 lines
Quoted 5 lines
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalAnything stopping this series from being merged?
It is unclear when this forwarding of non-verbs data to the FW will stop.
Thanks
Quoted 9 lines · Leon Romanovsky
Quoted 8 lines · Gal Pressman
Quoted 7 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Thanks,
GalAnything stopping this series from being merged?
It is unclear when this forwarding of non-verbs data to the FW will stop.
This was already discussed in the PR. Not everything should be passed through this interface, there should be a limit and it should be examined per case. rdma-core version is clearly related to an RDMA device.
BTW, if you have any concerns about a patch you can state them, you don't have to ignore it and wait for the submitter to ask what's wrong..
Quoted 13 lines · Gal Pressman
Quoted 12 lines · Leon Romanovsky
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
Gal
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Anything stopping this series from being merged?
It is unclear when this forwarding of non-verbs data to the FW will stop.
This was already discussed in the PR. Not everything should be passed through this interface, there should be a limit and it should be examined per case. rdma-core version is clearly related to an RDMA device.
"Clearly or not" - it depends on the observer.
Quoted 3 lines
BTW, if you have any concerns about a patch you can state them, you don't have to ignore it and wait for the submitter to ask what's wrong..
Didn't you mistake me with anyone else?
I'm reviewer in the kernel exactly like you and it gives me nice thing - ignore patches.
Thanks
Quoted 22 lines · Leon Romanovsky
Quoted 13 lines · Gal Pressman
Quoted 12 lines · Leon Romanovsky
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalQuoted 7 lines
Quoted 3 lines
Quoted 1 line
Anything stopping this series from being merged?
It is unclear when this forwarding of non-verbs data to the FW will stop.
This was already discussed in the PR. Not everything should be passed through this interface, there should be a limit and it should be examined per case. rdma-core version is clearly related to an RDMA device.
Quoted 7 lines
"Clearly or not" - it depends on the observer.
Quoted 3 lines
BTW, if you have any concerns about a patch you can state them, you don't have to ignore it and wait for the submitter to ask what's wrong..
Didn't you mistake me with anyone else?
No, you decided to answer my original question :).
Quoted 1 line
I'm reviewer in the kernel exactly like you and it gives me nice thing - ignore patches.
Don't get me wrong, your review is very appreciated, but this series is 20 LOC which you already reviewed two weeks ago, and I replied to all comments. Ignoring patches is fine, but please don't review, ignore and wait for the last minute to say they shouldn't be merged.
Quoted 31 lines · Gal Pressman
Quoted 22 lines · Leon Romanovsky
Quoted 13 lines · Gal Pressman
Quoted 12 lines · Leon Romanovsky
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalQuoted 7 lines
Quoted 3 lines
Quoted 1 line
Anything stopping this series from being merged?
It is unclear when this forwarding of non-verbs data to the FW will stop.
This was already discussed in the PR. Not everything should be passed through this interface, there should be a limit and it should be examined per case. rdma-core version is clearly related to an RDMA device.
Quoted 7 lines
"Clearly or not" - it depends on the observer.
Quoted 3 lines
BTW, if you have any concerns about a patch you can state them, you don't have to ignore it and wait for the submitter to ask what's wrong..
Didn't you mistake me with anyone else?
Quoted 8 lines
No, you decided to answer my original question :).
Quoted 1 line
I'm reviewer in the kernel exactly like you and it gives me nice thing - ignore patches.
Don't get me wrong, your review is very appreciated, but this series is 20 LOC which you already reviewed two weeks ago, and I replied to all comments. Ignoring patches is fine, but please don't review, ignore and wait for the last minute to say they shouldn't be merged.
Sorry, but it is impossible to get it right.
I gave you hint WHY it takes so long, it is not review/ack/nack or anything like this.
Thanks
Jason Gunthorpe
maintainerQuoted 5 lines · Gal Pressman
Quoted 4 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
Quoted 7 lines
Quoted 5 lines
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalAnything stopping this series from being merged?
Honestly, I'm not very keen on this
Why does this have to go through a kernel driver, can't you collect OS telemetry some other way?
Jason
Quoted 12 lines · Jason Gunthorpe
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
Gal
Quoted 6 lines
Quoted 1 line
Anything stopping this series from being merged?
Honestly, I'm not very keen on this
Why does this have to go through a kernel driver, can't you collect OS telemetry some other way?
Hmm, it has to go through rdma-core somehow, what sort of component can rdma-core interact with to pass such data? The only one I could think of is the RDMA driver :).
As I said, I get your concern, I was going on and off about this as well, but the userspace version is a very useful piece of information in the context of a kernel bypass device. It's just as important as the kernel version. I agree that this is not the place to pass things like gcc version, but I don't think that's the case here :).
Do you absolutely hate the idea of passing the userspace version, or are you worried about what's next to come?
If it's the latter, we don't really have plans to push anything similar anytime soon, and even if we did, I don't think it should block this series.
Jason Gunthorpe
maintainerQuoted 24 lines · Gal Pressman
Quoted 12 lines · Jason Gunthorpe
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalQuoted 6 lines
Quoted 1 line
Anything stopping this series from being merged?
Honestly, I'm not very keen on this
Why does this have to go through a kernel driver, can't you collect OS telemetry some other way?
Hmm, it has to go through rdma-core somehow, what sort of component can rdma-core interact with to pass such data? The only one I could think of is the RDMA driver :).
Quoted 5 lines
As I said, I get your concern, I was going on and off about this as well, but the userspace version is a very useful piece of information in the context of a kernel bypass device. It's just as important as the kernel version. I agree that this is not the place to pass things like gcc version, but I don't think that's the case here :).
Well, if we were to do this for mlx5 we'd want to pass UCX and maybe other stuff, it seems like it gets quickly out of hand.
I think telemetry is better done as some telemetry subsystem, not integrated all over the place
Jason
Quoted 25 lines · Jason Gunthorpe
Quoted 24 lines · Gal Pressman
Quoted 12 lines · Jason Gunthorpe
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalQuoted 6 lines
Quoted 1 line
Anything stopping this series from being merged?
Honestly, I'm not very keen on this
Why does this have to go through a kernel driver, can't you collect OS telemetry some other way?
Hmm, it has to go through rdma-core somehow, what sort of component can rdma-core interact with to pass such data? The only one I could think of is the RDMA driver :).
Quoted 8 lines
Quoted 5 lines
As I said, I get your concern, I was going on and off about this as well, but the userspace version is a very useful piece of information in the context of a kernel bypass device. It's just as important as the kernel version. I agree that this is not the place to pass things like gcc version, but I don't think that's the case here :).
Well, if we were to do this for mlx5 we'd want to pass UCX and maybe other stuff, it seems like it gets quickly out of hand.
Agree, that's why I think this should be limited to things in rdma-core's reach, sounds like a reasonable limit to me.
Quoted 2 lines
I think telemetry is better done as some telemetry subsystem, not integrated all over the place
Interesting, but that would still be all over the place as each package would have to report its version to that telemetry driver.
And since this currently doesn't exist, should we stay without a solution? Specifically talking about rdma-core version, do you think it could be merged?
Quoted 38 lines · Gal Pressman
Quoted 25 lines · Jason Gunthorpe
Quoted 24 lines · Gal Pressman
Quoted 12 lines · Jason Gunthorpe
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalQuoted 6 lines
Quoted 1 line
Anything stopping this series from being merged?
Honestly, I'm not very keen on this
Why does this have to go through a kernel driver, can't you collect OS telemetry some other way?
Hmm, it has to go through rdma-core somehow, what sort of component can rdma-core interact with to pass such data? The only one I could think of is the RDMA driver :).
Quoted 8 lines
Quoted 5 lines
As I said, I get your concern, I was going on and off about this as well, but the userspace version is a very useful piece of information in the context of a kernel bypass device. It's just as important as the kernel version. I agree that this is not the place to pass things like gcc version, but I don't think that's the case here :).
Well, if we were to do this for mlx5 we'd want to pass UCX and maybe other stuff, it seems like it gets quickly out of hand.
Agree, that's why I think this should be limited to things in rdma-core's reach, sounds like a reasonable limit to me.
Quoted 9 lines
Quoted 2 lines
I think telemetry is better done as some telemetry subsystem, not integrated all over the place
Interesting, but that would still be all over the place as each package would have to report its version to that telemetry driver.
And since this currently doesn't exist, should we stay without a solution? Specifically talking about rdma-core version, do you think it could be merged?
Jason?
Jason Gunthorpe
maintainerQuoted 42 lines · Gal Pressman
Quoted 41 lines · Gal Pressman
Quoted 25 lines · Jason Gunthorpe
Quoted 24 lines · Gal Pressman
Quoted 12 lines · Jason Gunthorpe
Quoted 11 lines · Gal Pressman
Quoted 9 lines · Gal Pressman
The following two patches add the userspace version to the host information struct reported to the device, used for debugging and troubleshooting purposes.
PR was sent:
https://github.com/linux-rdma/rdma-core/pull/918Thanks,
GalQuoted 6 lines
Quoted 1 line
Anything stopping this series from being merged?
Honestly, I'm not very keen on this
Why does this have to go through a kernel driver, can't you collect OS telemetry some other way?
Hmm, it has to go through rdma-core somehow, what sort of component can rdma-core interact with to pass such data? The only one I could think of is the RDMA driver :).
Quoted 8 lines
Quoted 5 lines
As I said, I get your concern, I was going on and off about this as well, but the userspace version is a very useful piece of information in the context of a kernel bypass device. It's just as important as the kernel version. I agree that this is not the place to pass things like gcc version, but I don't think that's the case here :).
Well, if we were to do this for mlx5 we'd want to pass UCX and maybe other stuff, it seems like it gets quickly out of hand.
Agree, that's why I think this should be limited to things in rdma-core's reach, sounds like a reasonable limit to me.
Quoted 2 lines
I think telemetry is better done as some telemetry subsystem, not integrated all over the place
Quoted 8 lines
Quoted 6 lines
Interesting, but that would still be all over the place as each package would have to report its version to that telemetry driver.
And since this currently doesn't exist, should we stay without a solution? Specifically talking about rdma-core version, do you think it could be merged?
Jason?
I'm not keen on it, it doesn't work well for other use-cases, it seems too hacky.
Jason