drm: panel-backlight-quirks: Do partial refactor and apply OLED fix
Subsystems (4)
v3 cover drm: panel-backlight-quirks: Do partial refactor and apply OLED fix
This is an alternative to [1], since Phil found out there are still invalid values. We need to reconsider the other patch in that series anyway because the latest AMD firmware update might have fixed the Z13.
This series refactors the panel-backlight-quirks code to make it easier to add new quirks. Specifically, it adds the ability to bind to a secondary DMI match so that the make of a device can be specified. Then, it makes EDID optional, for devices we know the value should be applied universally.
This is then used to add a quirk for OLED panels that have an issue when their backlight is set with a value that contains a 0/1 value in their minor byte. This issue affects four handhelds from three different vendors, three of which are in the field. This quirk applies a |3 mask to the backlight value, which avoids this issue. In addition, the value change is minor enough so that it is essentially a NOOP. There is no need for ensuring it runs only on panels with faulty firmwares.
Finally, since allowed by this refactor, a quirk for Steam Decks is added that lowers their minimum brightness to 0, matching SteamOS. This is a nicety commit, which allows for mildly lower minimum brightness, so there is no time sensitivity for having it merged. Mario noted that if that quirk was refactored to use an EDID match via the current interface, it could go through the fixes tree and land sooner, but perhaps it is not worth the effort.
[1] https://lore.kernel.org/all/[email protected]/
---
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
Changes since V2:
- Apply SD quirks at the middle so that backlight quirks stay together
- Add log when quirks are applied. Has to be separate because we need to grab a reference to the drm_device first and add it to min brightness first.
- Capitalize OR in patch 4
Changes since v1:
- Remove leftover quirk from patch 3 (refactor)
- Add dangling comma in patch 4 (oled quirk)
- Add the next generation Zotac Zone in patch 4 (currently unreleased)
- Reword patch 1 and 5 subjects
Antheas Kapenekakis (6):
drm: panel-backlight-quirks: Make EDID match optional
drm: panel-backlight-quirks: Convert brightness quirk to generic
structure
drm: panel-backlight-quirks: Add secondary DMI match
drm: panel-backlight-quirks: Add brightness mask quirk
drm: panel-backlight-quirks: Add Steam Deck brightness quirk
drm: panel-backlight-quirks: Log applied panel brightness quirks
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 31 ++++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 5 + drivers/gpu/drm/drm_panel_backlight_quirks.c | 113 ++++++++++++++---- include/drm/drm_utils.h | 8 +- 4 files changed, 125 insertions(+), 32 deletions(-)
base-commit: 1b237f190eb3d36f52dffe07a40b5eb210280e00
Signature · 1 line
2.51.0
PATCH v3 1/6 drm: panel-backlight-quirks: Make EDID match optional
Currently, having a valid panel_id match is required to use the quirk system. For certain devices, we know that all SKUs need a certain quirk. Therefore, allow not specifying ident by only checking for a match if panel_id is non-zero.
--- drivers/gpu/drm/drm_panel_backlight_quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_panel_backlight_quirks.c +1 -1
@@ -50,7 +50,7 @@ static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_bacif (!dmi_match (quirk->dmi_match.field, quirk->dmi_match.value))return false; -if (!drm_edid_match (edid, &quirk->ident)) +if (quirk->ident.panel_id && !drm_edid_match (edid, &quirk->ident))return false;return true;
Signature · 1 line
2.51.0
PATCH v3 2/6 drm: panel-backlight-quirks: Convert brightness quirk to generic structure
In reply to Antheas KapenekakisCurrently, the brightness quirk is limited to minimum brightness only. Refactor it to a structure, so that more quirks can be added in the future. Reserve 0 value for "no quirk", and use u16 to allow minimum brightness up to 255.
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++++-- drivers/gpu/drm/drm_panel_backlight_quirks.c | 41 ++++++++++--------- include/drm/drm_utils.h | 7 +++- 3 files changed, 35 insertions(+), 25 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +8 -4
@@ -3612,11 +3612,11 @@ static struct drm_mode_config_helper_funcs amdgpu_dm_mode_config_helperfuncs = {static void update_connector_ext_caps (struct amdgpu_dm_connector *aconnector) { +const struct drm_panel_backlight_quirk *panel_backlight_quirk;struct amdgpu_dm_backlight_caps *caps;struct drm_connector *conn_base;struct amdgpu_device *adev;struct drm_luminance_range_info *luminance_range; -int min_input_signal_override;if (aconnector->bl_idx ==-1 || aconnector->dc_link->connector_signal !=SIGNAL_TYPE_EDP )
@@ -3656,9 +3656,13 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)else caps->aux_min_input_signal =1 ; - min_input_signal_override =drm_get_panel_min_brightness_quirk (aconnector->drm_edid); -if (min_input_signal_override >=0 ) - caps->min_input_signal = min_input_signal_override; + panel_backlight_quirk = +drm_get_panel_backlight_quirk (aconnector->drm_edid); +if (!IS_ERR_OR_NULL (panel_backlight_quirk)) { +if (panel_backlight_quirk->min_brightness) + caps->min_input_signal = + panel_backlight_quirk->min_brightness -1 ; + } } DEFINE_FREE(sink_release, struct dc_sink *, if (_T) dc_sink_release(_T))
drivers/gpu/drm/drm_panel_backlight_quirks.c +21 -20
102 lines not on this page · raw message
include/drm/drm_utils.h +6 -1
@@ -16,7 +16,12 @@ struct drm_edid;int drm_get_panel_orientation_quirk (int width,int height); -int drm_get_panel_min_brightness_quirk (const struct drm_edid *edid); +struct drm_panel_backlight_quirk { +u16 min_brightness; +}; + +const struct drm_panel_backlight_quirk * +drm_get_panel_backlight_quirk (const struct drm_edid *edid);signed long drm_timeout_abs_to_jiffies (int64_t timeout_nsec);
Signature · 1 line
2.51.0
PATCH v3 3/6 drm: panel-backlight-quirks: Add secondary DMI match
In reply to Antheas KapenekakisUsing a single DMI match only allows matching per manufacturer. Introduce a second optional match to allow matching make/model. In addition, make DMI optional to allow matching only by EDID.
--- drivers/gpu/drm/drm_panel_backlight_quirks.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
drivers/gpu/drm/drm_panel_backlight_quirks.c +14 -5
@@ -8,11 +8,14 @@#include <drm/drm_edid.h> #include <drm/drm_utils.h> +struct drm_panel_match { +enum dmi_field field; +const char *const value; +}; +struct drm_get_panel_backlight_quirk { -struct { -enum dmi_field field; -const char *const value; - } dmi_match; +struct drm_panel_match dmi_match; +struct drm_panel_match dmi_match_other;struct drm_edid_ident ident;struct drm_panel_backlight_quirk quirk; };
@@ -48,7 +51,13 @@ static bool drm_panel_min_backlight_quirk_matches( const struct drm_get_panel_backlight_quirk *quirk, const struct drm_edid *edid) { - if (!dmi_match(quirk->dmi_match.field, quirk->dmi_match.value)) + if (quirk->dmi_match.field && + !dmi_match(quirk->dmi_match.field, quirk->dmi_match.value)) + return false; + +if (quirk->dmi_match_other.field && + !dmi_match (quirk->dmi_match_other.field, + quirk->dmi_match_other.value))return false;if (quirk->ident.panel_id && !drm_edid_match (edid, &quirk->ident))
Signature · 1 line
2.51.0
PATCH v3 4/6 drm: panel-backlight-quirks: Add brightness mask quirk
In reply to Antheas KapenekakisCertain OLED devices malfunction on specific brightness levels. Specifically, when DP_SOURCE_BACKLIGHT_LEVEL is written to with the first byte being 0x00 and sometimes 0x01, the panel forcibly turns off until the device sleeps again.
Below are some examples. This was found by iterating over brighness ranges while printing DP_SOURCE_BACKLIGHT_LEVEL. It was found that the screen would malfunction on specific values, and some of them were collected.
Therefore, introduce a quirk where the minor byte of brightness is OR'd with 0x03 to avoid the range of invalid values.
This quirk was tested by removing the workarounds and iterating from 0 to 50_000 value ranges with a cadence of 0.2s/it. The range of the panel is 1000...400_000, so the values were slightly interpolated during testing. The custom brightness curve added on 6.15 was disabled.
86016: 10101000000000000 86272: 10101000100000000 87808: 10101011100000000
251648: 111101011100000000
251649: 111101011100000001
86144: 10101000010000000
87809: 10101011100000001
251650: 111101011100000010
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 5 +++ drivers/gpu/drm/drm_panel_backlight_quirks.c | 36 +++++++++++++++++++ include/drm/drm_utils.h | 1 + 4 files changed, 49 insertions(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +7 -0
@@ -3662,6 +3662,9 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)if (panel_backlight_quirk->min_brightness) caps->min_input_signal = panel_backlight_quirk->min_brightness -1 ; +if (panel_backlight_quirk->brightness_mask) + caps->brightness_mask = + panel_backlight_quirk->brightness_mask; } }
@@ -4862,6 +4865,10 @@ static void amdgpu_dm_backlight_set_level(struct amdgpu_display_manager *dm, brightness =convert_brightness_from_user (caps, dm->brightness[bl_idx]); link = (struct dc_link *)dm->backlight_link[bl_idx]; +/* Apply brightness quirk */ +if (caps->brightness_mask) + brightness |= caps->brightness_mask; +/* Change brightness based on AUX property */ mutex_lock (&dm->dc_lock);if (dm->dc->caps.ips_support && dm->dc->ctx->dmub_srv->idle_allowed) {
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h +5 -0
@@ -200,6 +200,11 @@ struct amdgpu_dm_backlight_caps {* @aux_support: Describes if the display supports AUX backlight. */ bool aux_support; +/** +* @brightness_mask: After deriving brightness, OR it with this mask. +* Workaround for panels with issues with certain brightness values. +*/ +u32 brightness_mask;/** * @ac_level: the default brightness if booted on AC */
drivers/gpu/drm/drm_panel_backlight_quirks.c +36 -0
@@ -45,6 +45,42 @@ static const struct drm_get_panel_backlight_quirk drm_panel_min_backlight_quirks .ident.name = "NE135A1M-NY1", .quirk = { .min_brightness = 1, }, }, +/* Have OLED Panels with brightness issue when last byte is 0/1 */ + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "AYANEO", + .dmi_match_other.field = DMI_PRODUCT_NAME, + .dmi_match_other.value = "AYANEO 3", + .quirk = { .brightness_mask = 3, }, + }, + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "ZOTAC", + .dmi_match_other.field = DMI_BOARD_NAME, + .dmi_match_other.value = "G0A1W", + .quirk = { .brightness_mask = 3, }, + }, + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "ZOTAC", + .dmi_match_other.field = DMI_BOARD_NAME, + .dmi_match_other.value = "G1A1W", + .quirk = { .brightness_mask = 3, }, + }, + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "ONE-NETBOOK", + .dmi_match_other.field = DMI_PRODUCT_NAME, + .dmi_match_other.value = "ONEXPLAYER F1Pro", + .quirk = { .brightness_mask = 3, }, + }, + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "ONE-NETBOOK", + .dmi_match_other.field = DMI_PRODUCT_NAME, + .dmi_match_other.value = "ONEXPLAYER F1 EVA-02", + .quirk = { .brightness_mask = 3, }, + }, }; static bool drm_panel_min_backlight_quirk_matches(
include/drm/drm_utils.h +1 -0
@@ -18,6 +18,7 @@ int drm_get_panel_orientation_quirk(int width, int height);struct drm_panel_backlight_quirk {u16 min_brightness; +u32 brightness_mask; }; const struct drm_panel_backlight_quirk *
Signature · 1 line
2.51.0
PATCH v3 5/6 drm: panel-backlight-quirks: Add Steam Deck brightness quirk
In reply to Antheas KapenekakisOn the SteamOS kernel, Valve universally makes minimum brightness 0 for all devices. SteamOS is (was?) meant for the Steam Deck, so enabling it universally is reasonable. However, it causes issues in certain devices. Therefore, introduce it just for the Steam Deck here.
SteamOS kernel does not have a public mirror, but this replaces commit 806dd74bb225 ("amd/drm: override backlight min value from 12 -> 0") in the latest, as of this writing, SteamOS kernel (6.11.11-valve24). See unofficial mirror reconstructed from sources below.
--- drivers/gpu/drm/drm_panel_backlight_quirks.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/gpu/drm/drm_panel_backlight_quirks.c +15 -0
@@ -45,6 +45,21 @@ static const struct drm_get_panel_backlight_quirk drm_panel_min_backlight_quirks .ident.name = "NE135A1M-NY1", .quirk = { .min_brightness = 1, }, }, +/* Steam Deck models */ + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "Valve", + .dmi_match_other.field = DMI_PRODUCT_NAME, + .dmi_match_other.value = "Jupiter", + .quirk = { .min_brightness = 1, }, + }, + { + .dmi_match.field = DMI_SYS_VENDOR, + .dmi_match.value = "Valve", + .dmi_match_other.field = DMI_PRODUCT_NAME, + .dmi_match_other.value = "Galileo", + .quirk = { .min_brightness = 1, }, + },/* Have OLED Panels with brightness issue when last byte is 0/1 */ { .dmi_match.field = DMI_SYS_VENDOR,
Signature · 1 line
2.51.0
PATCH v3 6/6 drm: panel-backlight-quirks: Log applied panel brightness quirks
In reply to Antheas KapenekakisCurrently, when a panel brightness quirk is applied, there is no log indicating that a quirk was applied. Unwrap the drm device on its own and use drm_info() to log when a quirk is applied.
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +13 -3
@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)struct drm_connector *conn_base;struct amdgpu_device *adev;struct drm_luminance_range_info *luminance_range; +struct drm_device *drm;if (aconnector->bl_idx ==-1 || aconnector->dc_link->connector_signal !=SIGNAL_TYPE_EDP )return ; conn_base = &aconnector->base; - adev =drm_to_adev (conn_base->dev); + drm = conn_base->dev; + adev =drm_to_adev (drm); caps = &adev->dm.backlight_caps[aconnector->bl_idx]; caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;
@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector) panel_backlight_quirk =drm_get_panel_backlight_quirk (aconnector->drm_edid);if (!IS_ERR_OR_NULL (panel_backlight_quirk)) { -if (panel_backlight_quirk->min_brightness) +if (panel_backlight_quirk->min_brightness) { +drm_info (drm, +"Applying panel backlight quirk, min_brightness: %d\n" , + panel_backlight_quirk->min_brightness); caps->min_input_signal = panel_backlight_quirk->min_brightness -1 ; -if (panel_backlight_quirk->brightness_mask) + } +if (panel_backlight_quirk->brightness_mask) { +drm_info (drm, +"Applying panel backlight quirk, brightness_mask: 0x%X\n" , + panel_backlight_quirk->brightness_mask); caps->brightness_mask = panel_backlight_quirk->brightness_mask; + } } }
Signature · 1 line
2.51.0
Re: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks
Quoted 33 lines · Antheas Kapenekakis
Currently, when a panel brightness quirk is applied, there is no log indicating that a quirk was applied. Unwrap the drm device on its own and use
drm_info()to log when a quirk is applied.Suggested-by Mario Limonciello <[email protected]>Signed-off-by Antheas Kapenekakis <[email protected]>--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +3
-1@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)struct drm_connector *conn_base;struct amdgpu_device *adev;struct drm_luminance_range_info *luminance_range; +struct drm_device *drm;if (aconnector->bl_idx ==-1 || aconnector->dc_link->connector_signal !=SIGNAL_TYPE_EDP )return ; conn_base = &aconnector->base; - adev =drm_to_adev (conn_base->dev); + drm = conn_base->dev; + adev =drm_to_adev (drm); caps = &adev->dm.backlight_caps[aconnector->bl_idx]; caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector) · line 3667
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4
-1@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector) panel_backlight_quirk =drm_get_panel_backlight_quirk (aconnector->drm_edid);if (!IS_ERR_OR_NULL (panel_backlight_quirk)) { -if (panel_backlight_quirk->min_brightness) +if (panel_backlight_quirk->min_brightness) { +drm_info (drm, +"Applying panel backlight quirk, min_brightness: %d\n" , + panel_backlight_quirk->min_brightness);
mmm, needs a -1 here
Quoted 18 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +6
-2caps->min_input_signal = panel_backlight_quirk->min_brightness -1 ; -if (panel_backlight_quirk->brightness_mask) + } +if (panel_backlight_quirk->brightness_mask) { +drm_info (drm, +"Applying panel backlight quirk, brightness_mask: 0x%X\n" , + panel_backlight_quirk->brightness_mask); caps->brightness_mask = panel_backlight_quirk->brightness_mask; + } } } --2.51.0
Re: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks
Quoted 31 lines · Antheas Kapenekakis
Quoted 30 lines · Antheas Kapenekakis
Currently, when a panel brightness quirk is applied, there is no log indicating that a quirk was applied. Unwrap the drm device on its own and use
drm_info()to log when a quirk is applied.Suggested-by Mario Limonciello <[email protected]>Signed-off-by Antheas Kapenekakis <[email protected]>--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +3
-1@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)struct drm_connector *conn_base;struct amdgpu_device *adev;struct drm_luminance_range_info *luminance_range; +struct drm_device *drm;if (aconnector->bl_idx ==-1 || aconnector->dc_link->connector_signal !=SIGNAL_TYPE_EDP )return ; conn_base = &aconnector->base; - adev =drm_to_adev (conn_base->dev); + drm = conn_base->dev; + adev =drm_to_adev (drm);
Quoted 14 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector) · line 3667
Quoted 11 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4
-1caps = &adev->dm.backlight_caps[aconnector->bl_idx]; caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector) panel_backlight_quirk =drm_get_panel_backlight_quirk (aconnector->drm_edid);if (!IS_ERR_OR_NULL (panel_backlight_quirk)) { -if (panel_backlight_quirk->min_brightness) +if (panel_backlight_quirk->min_brightness) { +drm_info (drm, +"Applying panel backlight quirk, min_brightness: %d\n" , + panel_backlight_quirk->min_brightness);mmm, needs a -1 here
You may as well re-order it too so that you set caps->min_input_signal and access it in this message.
Quoted 19 lines
Quoted 18 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +6
-2caps->min_input_signal = panel_backlight_quirk->min_brightness -1 ; -if (panel_backlight_quirk->brightness_mask) + } +if (panel_backlight_quirk->brightness_mask) { +drm_info (drm, +"Applying panel backlight quirk, brightness_mask: 0x%X\n" , + panel_backlight_quirk->brightness_mask); caps->brightness_mask = panel_backlight_quirk->brightness_mask; + } } } --2.51.0
RE: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks
[Public]
Quoted 59 lines
-----Original Message-----
From: Mario Limonciello <[email protected]>
Sent: Wednesday, September 3, 2025 12:53 AM
To: Antheas Kapenekakis <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Robert Beckett <[email protected]>
Subject: Re: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirksQuoted 12 lines · Antheas Kapenekakis
Quoted 11 lines · Antheas Kapenekakis
Currently, when a panel brightness quirk is applied, there is no log indicating that a quirk was applied. Unwrap the drm device on its own and use
drm_info()to log when a quirk is applied.Suggested-by Mario Limonciello <[email protected]>Signed-off-by Antheas Kapenekakis <[email protected]>--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)Quoted 6 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct
Quoted 6 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct
amdgpu_dm_connector*aconnector)Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-0struct drm_connector *conn_base;struct amdgpu_device *adev;struct drm_luminance_range_info *luminance_range; +struct drm_device *drm;if (aconnector->bl_idx ==-1 || aconnector->dc_link->connector_signal !=SIGNAL_TYPE_EDP )return ;Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-1conn_base = &aconnector->base; - adev =drm_to_adev (conn_base->dev); + drm = conn_base->dev; + adev =drm_to_adev (drm); caps = &adev->dm.backlight_caps[aconnector->bl_idx]; caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct
amdgpu_dm_connector*aconnector)Quoted 10 lines
Quoted 9 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +5
-1panel_backlight_quirk =drm_get_panel_backlight_quirk (aconnector->drm_edid);if (!IS_ERR_OR_NULL (panel_backlight_quirk)) { -if (panel_backlight_quirk->min_brightness) +if (panel_backlight_quirk->min_brightness) { +drm_info (drm, +"Applying panel backlight quirk, min_brightness: %d\n" , + + panel_backlight_quirk->min_brightness);
Quoted 6 lines
Quoted 2 lines
mmm, needs a -1 here
You may as well re-order it too so that you set
caps->min_input_signaland access it in this message.
With that fixed up, the series is:
Quoted 22 lines
Quoted 7 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
Quoted 7 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4
-1caps->min_input_signal = panel_backlight_quirk->min_brightness -1 ; -if (panel_backlight_quirk->brightness_mask) + } +if (panel_backlight_quirk->brightness_mask) { + drm_info(drm, + "Applying panel backlight quirk, brightness_mask:0x%X\n",
Quoted 14 lines
Quoted 13 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +3
-1+ + panel_backlight_quirk->brightness_mask); caps->brightness_mask = panel_backlight_quirk->brightness_mask; + } } } --2.51.0
Mario Limonciello
Reviewed-byRe: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks
Quoted 22 lines · Alexander
[Public]
Quoted 20 lines
-----Original Message-----
From: Mario Limonciello <[email protected]>
Sent: Wednesday, September 3, 2025 12:53 AM
To: Antheas Kapenekakis <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Robert Beckett <[email protected]>
Subject: Re: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirksQuoted 8 lines · Antheas Kapenekakis
Quoted 7 lines · Antheas Kapenekakis
Currently, when a panel brightness quirk is applied, there is no log indicating that a quirk was applied. Unwrap the drm device on its own and use
drm_info()to log when a quirk is applied.Suggested-by Mario Limonciello <[email protected]>Signed-off-by Antheas Kapenekakis <[email protected]>
Besides the one thing you identified this looks fine to me.
Quoted 42 lines
Quoted 42 lines
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct
Quoted 10 lines
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct
amdgpu_dm_connector*aconnector)Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-0struct drm_connector *conn_base;struct amdgpu_device *adev;struct drm_luminance_range_info *luminance_range; +struct drm_device *drm;if (aconnector->bl_idx ==-1 || aconnector->dc_link->connector_signal !=SIGNAL_TYPE_EDP )return ;Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-1conn_base = &aconnector->base; - adev =drm_to_adev (conn_base->dev); + drm = conn_base->dev; + adev =drm_to_adev (drm); caps = &adev->dm.backlight_caps[aconnector->bl_idx]; caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct
amdgpu_dm_connector*aconnector)Quoted 12 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector) · line 3667
Quoted 9 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +5
-1panel_backlight_quirk =drm_get_panel_backlight_quirk (aconnector->drm_edid);if (!IS_ERR_OR_NULL (panel_backlight_quirk)) { -if (panel_backlight_quirk->min_brightness) +if (panel_backlight_quirk->min_brightness) { +drm_info (drm, +"Applying panel backlight quirk, min_brightness: %d\n" , + + panel_backlight_quirk->min_brightness);mmm, needs a -1 here
Quoted 8 lines
Quoted 3 lines
You may as well re-order it too so that you set
caps->min_input_signaland access it in this message.With that fixed up, the series is:
Acked-by Alex Deucher <[email protected]>
I've added a manual fixup for that change in the last patch and pushed the series to drm-misc-next.
a3ae3384be770 (HEAD -> drm-misc-next, drm-misc/for-linux-next, drm-misc/drm-misc-next) drm: panel-backlight-quirks: Log applied panel brightness quirks bf0365b005d9a drm: panel-backlight-quirks: Add Steam Deck brightness quirkaef10b1138e99 drm: panel-backlight-quirks: Add brightness mask quirkf7033fab81d82 drm: panel-backlight-quirks: Add secondary DMI match6eee1ef9e5985 drm: panel-backlight-quirks: Convert brightness quirk to generic structure9931e4be11f21 drm: panel-backlight-quirks: Make EDID match optional