drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
PATCH 1/1 drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance
Per the ABI specification[1], each mdev_supported_types entry should have an available_instances, with an "s", not available_instance.
[1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
---
This should really be fixed before initial release in v4.10
drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gvt/kvmgt.c +4 -4
@@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,return NULL ; } -static ssize_t available_instance_show (struct kobject *kobj,struct device *dev, -char *buf) +static ssize_t available_instances_show (struct kobject *kobj, +struct device *dev,char *buf) {struct intel_vgpu_type *type;unsigned int num =0 ;
@@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev, type->fence); } -static MDEV_TYPE_ATTR_RO (available_instance); +static MDEV_TYPE_ATTR_RO (available_instances);static MDEV_TYPE_ATTR_RO (device_api);static MDEV_TYPE_ATTR_RO (description);static struct attribute *type_attrs[] = { - &mdev_type_attr_available_instance.attr, + &mdev_type_attr_available_instances.attr, &mdev_type_attr_device_api.attr, &mdev_type_attr_description.attr,NULL ,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Alex Williamson
Per the ABI specification[1], each
mdev_supported_typesentry should have anavailable_instances, with an "s", notavailable_instance.[1]
Documentation/ABI/testing/sysfs-bus-vfio-mdevSigned-off-by Alex Williamson <[email protected]>---
This should really be fixed before initial release in v4.10
Thanks for finding this!
--
Thanks,
Jike
Quoted 25 lines
drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/gvt/kvmgt.c +2
-3@@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,return NULL ; } -static ssize_t available_instance_show (struct kobject *kobj,struct device *dev, -char *buf) +static ssize_t available_instances_show (struct kobject *kobj, +struct device *dev,char *buf) {struct intel_vgpu_type *type;unsigned int num =0 ;@@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev, type->fence); } -static MDEV_TYPE_ATTR_RO (available_instance);
drivers/gpu/drm/i915/gvt/kvmgt.c static ssize_t description_show(struct kobject *kobj, struct device *dev, · line 280
Quoted 10 lines
drivers/gpu/drm/i915/gvt/kvmgt.c +2
-1+static MDEV_TYPE_ATTR_RO (available_instances);static MDEV_TYPE_ATTR_RO (device_api);static MDEV_TYPE_ATTR_RO (description);static struct attribute *type_attrs[] = { - &mdev_type_attr_available_instance.attr, + &mdev_type_attr_available_instances.attr, &mdev_type_attr_device_api.attr, &mdev_type_attr_description.attr,NULL ,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Alex Williamson
Per the ABI specification[1], each
mdev_supported_typesentry should have anavailable_instances, with an "s", notavailable_instance.[1]
Documentation/ABI/testing/sysfs-bus-vfio-mdevSigned-off-by Alex Williamson <[email protected]>---
This should really be fixed before initial release in v4.10
Will queue this up for 4.10 fixes. Thanks!
Signature · 3 lines
Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827