usb: ohci: fix error return code in servicing iso td
PATCH 1/1 usb: ohci: fix error return code in servicing iso td
From: Li Qiang <[email protected]>
It should return 1 if an error occurs when reading iso td. This will avoid an infinite loop issue in ohci_service_ed_list.
Signed-off-by Li Qiang <[email protected]>
--- hw/usb/hcd-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/usb/hcd-ohci.c +1 -1
@@ -727,7 +727,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed,if (ohci_read_iso_td (ohci, addr, &iso_td)) {trace_usb_ohci_iso_td_read_failed (addr);ohci_die (ohci); -return 0 ; +return 1 ; } starting_frame =OHCI_BM (iso_td.flags,TD_SF );
Signature · 1 line
1.8.3.1
Ping...
2017-02-07 19:15 GMT+08:00 Li Qiang <[email protected]>:
Quoted 28 lines
From: Li Qiang <[email protected]>
It should return 1 if an error occurs when reading iso td. This will avoid an infinite loop issue in
ohci_service_ed_list.Signed-off-by Li Qiang <[email protected]>--- hw/usb/hcd-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/usb/hcd-ohci.c +1
-1@@ -727,7 +727,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed, if (ohci_read_iso_td(ohci, addr, &iso_td)) {trace_usb_ohci_iso_td_read_failed (addr);ohci_die (ohci); -return 0 ; +return 1 ; }starting_frame = OHCI_BM(iso_td.flags, TD_SF);--
1.8.3.1