Skip to contentSkip to conversation

usb: ohci: fix error return code in servicing iso td

PATCH In review Li Qiang 1 participant 2 messages Feb 7, 2017 – Feb 15, 2017

lore
Share & tools
lore

Li Qiang

author
#0 lore raw

PATCH 1/1 usb: ohci: fix error return code in servicing iso td

From: Li Qiang <[email protected]>

It should return 1 if an error occurs when reading iso td. This will avoid an infinite loop issue in ohci_service_ed_list.

---
 hw/usb/hcd-ohci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/usb/hcd-ohci.c +1 -1
index 4a63f3b..21c93e0 100644
@@ -727,7 +727,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed,
     if (ohci_read_iso_td(ohci, addr, &iso_td)) {
         trace_usb_ohci_iso_td_read_failed(addr);
         ohci_die(ohci);
-        return 0;
+        return 1;
     }
 
     starting_frame = OHCI_BM(iso_td.flags, TD_SF);
Signature · 1 line
1.8.3.1
author
#1 lore raw

Ping...

2017-02-07 19:15 GMT+08:00 Li Qiang <[email protected]>:

Quoted 28 lines

From: Li Qiang <[email protected]>

It should return 1 if an error occurs when reading iso td. This will avoid an infinite loop issue in ohci_service_ed_list.

---
 hw/usb/hcd-ohci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/usb/hcd-ohci.c +1 -1
index 4a63f3b..21c93e0 100644
@@ -727,7 +727,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct
 ohci_ed *ed,
     if (ohci_read_iso_td(ohci, addr, &iso_td)) {
         trace_usb_ohci_iso_td_read_failed(addr);
         ohci_die(ohci);
-        return 0;
+        return 1;
     }
 
     starting_frame = OHCI_BM(iso_td.flags, TD_SF);

--
1.8.3.1