Skip to contentSkip to conversation

rockchip: firefly: configs: remove config_spl_of_platdata

PATCH New Jacob Chen 5 participants 7 messages Feb 15, 2017 – Feb 23, 2017

lore
Share & tools
lore

Jacob Chen

author
#0 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin since we use spl_back_to_brom.

I miss it because i forget to clean build-dir..

---

 configs/firefly-rk3288_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/firefly-rk3288_defconfig +0 -1
index 18e050d..e5222da 100644
@@ -32,7 +32,6 @@ CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
-CONFIG_SPL_OF_PLATDATA=y
 CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

Hi Jacob,

Quoted 2 lines · Jacob Chen

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin since we use spl_back_to_brom.

Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?

If this works on firefly, then we can still leave it as an example to show how both way works.

Thanks,
- Kever

Quoted 21 lines

I miss it because i forget to clean build-dir..

---

  configs/firefly-rk3288_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/firefly-rk3288_defconfig +0 -1
index 18e050d..e5222da 100644
@@ -32,7 +32,6 @@ CONFIG_CMD_FAT=y
  CONFIG_CMD_FS_GENERIC=y
  CONFIG_SPL_OF_CONTROL=y
  CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
-CONFIG_SPL_OF_PLATDATA=y
  CONFIG_REGMAP=y
  CONFIG_SPL_REGMAP=y
  CONFIG_SYSCON=y
#2 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

Hi Kever,

Kever Yang wrote on 2017?02?15? 14:13:

Quoted 12 lines

Hi Jacob,

Quoted 3 lines · Jacob Chen

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin
since we use spl_back_to_brom.

Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?

If this works on firefly, then we can still leave it as an example to show how both way works.

Firefly had been using CONFIG_SPL_OF_PLATDATA and it works well. Just it will make trouble for other things to generate the u-boot blob, like yocto, sdk build scripts, guides...

At first, I also want to keep CONFIG_SPL_OF_PLATDATA in firefly, but later I find that i have to do a lot of unnecessary work to deal with it, so now I would like one chip use one way to generate the u-boot blob.

Quoted 29 lines

Thanks,
- Kever

Quoted 24 lines

I miss it because i forget to clean build-dir..

---

  configs/firefly-rk3288_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/firefly-rk3288_defconfig +0 -0
index 18e050d..e5222da 100644
@@ -32,7 +32,6 @@ CONFIG_CMD_FAT=y
  CONFIG_CMD_FS_GENERIC=y
  CONFIG_SPL_OF_CONTROL=y
  CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names 

interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" -CONFIG_SPL_OF_PLATDATA=y
CONFIG_REGMAP=y
CONFIG_SPL_REGMAP=y
CONFIG_SYSCON=y

#3 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

Hi,

Quoted 20 lines · Jacob Chen

Hi Kever,

Kever Yang wrote on 2017?02?15? 14:13:

Quoted 10 lines

Hi Jacob,

Quoted 4 lines · Jacob Chen

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin
since we use spl_back_to_brom.

Quoted 5 lines

Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?

If this works on firefly, then we can still leave it as an example to show how both way works.

Quoted 7 lines

Firefly had been using CONFIG_SPL_OF_PLATDATA and it works well. Just it will make trouble for other things to generate the u-boot blob, like yocto, sdk build scripts, guides...

At first, I also want to keep CONFIG_SPL_OF_PLATDATA in firefly, but later I find that i have to do a lot of unnecessary work to deal with it, so now I would like one chip use one way to generate the u-boot blob.

How about having a separate board config like firefly-rk3288-dt so that we keep the non-of-platdata alive? It only needs a separate defconfig, which is pretty esay.

Regards,
Simon

#4 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

Hi,

2017-02-17 4:44 GMT+08:00 Simon Glass <[email protected]>:

Quoted 35 lines

Hi,

Quoted 20 lines · Jacob Chen

Hi Kever,

Kever Yang wrote on 2017?02?15? 14:13:

Quoted 10 lines

Hi Jacob,

Quoted 4 lines · Jacob Chen

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin
since we use spl_back_to_brom.

Quoted 5 lines

Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?

If this works on firefly, then we can still leave it as an example to show how both way works.

Quoted 7 lines

Firefly had been using CONFIG_SPL_OF_PLATDATA and it works well. Just it will make trouble for other things to generate the u-boot blob, like yocto, sdk build scripts, guides...

At first, I also want to keep CONFIG_SPL_OF_PLATDATA in firefly, but later I find that i have to do a lot of unnecessary work to deal with it, so now I would like one chip use one way to generate the u-boot blob.

How about having a separate board config like firefly-rk3288-dt so that we keep the non-of-platdata alive? It only needs a separate defconfig, which is pretty esay.

Quoted 6 lines

Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

I send a patch "rockchip: firefly: configs: add a new config to keep non-of-platdata" to save old config.

#5 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

Quoted 46 lines · Jacob Chen

Hi,

2017-02-17 4:44 GMT+08:00 Simon Glass <[email protected]>:

Quoted 35 lines

Hi,

Quoted 20 lines · Jacob Chen

Hi Kever,

Kever Yang wrote on 2017?02?15? 14:13:

Quoted 10 lines

Hi Jacob,

Quoted 4 lines · Jacob Chen

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin
since we use spl_back_to_brom.

Quoted 5 lines

Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?

If this works on firefly, then we can still leave it as an example to show how both way works.

Quoted 7 lines

Firefly had been using CONFIG_SPL_OF_PLATDATA and it works well. Just it will make trouble for other things to generate the u-boot blob, like yocto, sdk build scripts, guides...

At first, I also want to keep CONFIG_SPL_OF_PLATDATA in firefly, but later I find that i have to do a lot of unnecessary work to deal with it, so now I would like one chip use one way to generate the u-boot blob.

How about having a separate board config like firefly-rk3288-dt so that we keep the non-of-platdata alive? It only needs a separate defconfig, which is pretty esay.

Quoted 6 lines

Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 2 lines

I send a patch "rockchip: firefly: configs: add a new config to keep non-of-platdata" to save old config.

OK thanks.

#6 lore raw

PATCH 1/1 rockchip: firefly: configs: remove config_spl_of_platdata

Quoted 47 lines · Simon Glass
Quoted 46 lines · Jacob Chen

Hi,

2017-02-17 4:44 GMT+08:00 Simon Glass <[email protected]>:

Quoted 41 lines

Hi,

Quoted 20 lines · Jacob Chen

Hi Kever,

Kever Yang wrote on 2017?02?15? 14:13:

Quoted 10 lines

Hi Jacob,

Quoted 4 lines · Jacob Chen

We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin rather than u-boot-spl-nodtb.bin
since we use spl_back_to_brom.

Quoted 5 lines

Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?

If this works on firefly, then we can still leave it as an example to show how both way works.

Quoted 7 lines

Firefly had been using CONFIG_SPL_OF_PLATDATA and it works well. Just it will make trouble for other things to generate the u-boot blob, like yocto, sdk build scripts, guides...

At first, I also want to keep CONFIG_SPL_OF_PLATDATA in firefly, but later I find that i have to do a lot of unnecessary work to deal with it, so now I would like one chip use one way to generate the u-boot blob.

How about having a separate board config like firefly-rk3288-dt so that we keep the non-of-platdata alive? It only needs a separate defconfig, which is pretty esay.

Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 6 lines
Quoted 2 lines

I send a patch "rockchip: firefly: configs: add a new config to keep non-of-platdata" to save old config.

OK thanks.

Applied to u-boot-rockchip, thanks!