Skip to contentSkip to conversation

travis-ci: Temporarily disable using a newer device tree compiler

PATCH New Tom Rini 3 participants 6 messages Feb 27, 2017

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 travis-ci: Temporarily disable using a newer device tree compiler

For a long while dtc has warned about various constructs. This is now leading to log file size being exceeded in travis, and as the majority of these errors need to be fixed in the kernel, switch to using the stock device-tree-compiler package.

---
 .travis.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
.travis.yml +3 -2
index 48b7b101f1c6..8333fae9b333 100644
@@ -28,11 +28,12 @@ addons:
     - grub-efi-ia32-bin
     - rpm2cpio
     - wget
+    - device-tree-compiler
 
 install:
  # install latest device tree compiler
- - git clone --depth=1 git://git.kernel.org/pub/scm/utils/dtc/dtc.git /tmp/dtc
- - make -j4 -C /tmp/dtc
+ #- git clone --depth=1 git://git.kernel.org/pub/scm/utils/dtc/dtc.git /tmp/dtc
+ #- make -j4 -C /tmp/dtc
  # Clone uboot-test-hooks
  - git clone --depth=1 git://github.com/swarren/uboot-test-hooks.git /tmp/uboot-test-hooks
  - ln -s travis-ci /tmp/uboot-test-hooks/bin/`hostname`
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 travis-ci: Temporarily disable using a newer device tree compiler

Quoted 6 lines · Tom Rini

For a long while dtc has warned about various constructs. This is now leading to log file size being exceeded in travis, and as the majority of these errors need to be fixed in the kernel, switch to using the stock device-tree-compiler package.

Applied to u-boot/master, thanks!

But I'm not happy to have to apply it, either. I do not wish to break travis-ci, but sun7i is now exceeding the allowed stdout size. And these are problems that need to be fixed in the kernel first, rather than here first. The patches to fix u-boot local issues (such as x86 never got picked up either, but likely need to be respun. I expect that once the new DTC version is tagged and populated upstream in the kernel as well, we will be able to re-enable the changes we had here.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170226/9fa1844f/attachment.sig>
#2 lore raw

PATCH 1/1 travis-ci: Temporarily disable using a newer device tree compiler

Quoted 11 lines · Tom Rini
Quoted 6 lines · Tom Rini

For a long while dtc has warned about various constructs. This is now leading to log file size being exceeded in travis, and as the majority of these errors need to be fixed in the kernel, switch to using the stock device-tree-compiler package.

Applied to u-boot/master, thanks!

Quoted 7 lines

But I'm not happy to have to apply it, either. I do not wish to break travis-ci, but sun7i is now exceeding the allowed stdout size. And these are problems that need to be fixed in the kernel first, rather than here first. The patches to fix u-boot local issues (such as x86 never got picked up either, but likely need to be respun. I expect that once the new DTC version is tagged and populated upstream in the kernel as well, we will be able to re-enable the changes we had here.

This was fixed (aka a hidden bandaid) in the linux kernel via:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/
#3 lore raw

PATCH 1/1 travis-ci: Temporarily disable using a newer device tree compiler

Hello Robert,

Am 27.02.2017 um 05:34 schrieb Robert Nelson:

Quoted 20 lines · Tom Rini
Quoted 11 lines · Tom Rini
Quoted 7 lines

For a long while dtc has warned about various constructs. This is now leading to log file size being exceeded in travis, and as the majority of these errors need to be fixed in the kernel, switch to using the stock device-tree-compiler package.

Applied to u-boot/master, thanks!

Quoted 7 lines

But I'm not happy to have to apply it, either. I do not wish to break travis-ci, but sun7i is now exceeding the allowed stdout size. And these are problems that need to be fixed in the kernel first, rather than here first. The patches to fix u-boot local issues (such as x86 never got picked up either, but likely need to be respun. I expect that once the new DTC version is tagged and populated upstream in the kernel as well, we will be able to re-enable the changes we had here.

Quoted 3 lines

This was fixed (aka a hidden bandaid) in the linux kernel via:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d

Heh... IIRC, I tried to fix a lot of this messages (in U-Boot), around a year ago, and we decided to not apply them in u-boot, instead they should go away via kernel resyncs, when the warnings are fixed in the kernel!

Also I think, I tried a similiar approach as the commit you mentioned... Ah, yes, here:
http://lists.denx.de/pipermail/u-boot/2016-April/252408.html

We decided (for u-boot) it would be better to fix the problems and not supress the warning, but it seems, the problems get not really fixed in the kernel ...

I wasn;t aware of the above patch in the kernel... thanks for pointing!

@Tom:
So, I feel, the problems get not fixed fast in the kernel (if ever), may we want to cherry-pick this patch from the kernel (or make a similiar patch for U-Boot)?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#4 lore raw

PATCH 1/1 travis-ci: Temporarily disable using a newer device tree compiler

Quoted 42 lines · Heiko Schocher

Hello Robert,

Am 27.02.2017 um 05:34 schrieb Robert Nelson:

Quoted 24 lines · Tom Rini
Quoted 13 lines · Tom Rini
Quoted 7 lines

For a long while dtc has warned about various constructs. This is now leading to log file size being exceeded in travis, and as the majority of these errors need to be fixed in the kernel, switch to using the stock device-tree-compiler package.

Applied to u-boot/master, thanks!

Quoted 7 lines

But I'm not happy to have to apply it, either. I do not wish to break travis-ci, but sun7i is now exceeding the allowed stdout size. And these are problems that need to be fixed in the kernel first, rather than here first. The patches to fix u-boot local issues (such as x86 never got picked up either, but likely need to be respun. I expect that once the new DTC version is tagged and populated upstream in the kernel as well, we will be able to re-enable the changes we had here.

Quoted 4 lines

This was fixed (aka a hidden bandaid) in the linux kernel via:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d

Heh... IIRC, I tried to fix a lot of this messages (in U-Boot), around a year ago, and we decided to not apply them in u-boot, instead they should go away via kernel resyncs, when the warnings are fixed in the kernel!

Also I think, I tried a similiar approach as the commit you mentioned... Ah, yes, here:
http://lists.denx.de/pipermail/u-boot/2016-April/252408.html

Quoted 5 lines

We decided (for u-boot) it would be better to fix the problems and not supress the warning, but it seems, the problems get not really fixed in the kernel ...

I wasn;t aware of the above patch in the kernel... thanks for pointing!

and i think by moving the kernel to disable that patch, it's slowed down the number of register fix patches..

ps, this just came in on kbuild list just a few minutes ago:

https://marc.info/?l=linux-kbuild&m=148817429929267&w=2

one of the issues with bc553986a2f7c56d0de811485d5312ea29692d5d is that it breaks the build with older version of dtc that don't know what to do with the -Wno-unit_address_vs_reg flag..

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/
author
#5 lore raw

PATCH 1/1 travis-ci: Temporarily disable using a newer device tree compiler

Quoted 52 lines · Robert Nelson
Quoted 42 lines · Heiko Schocher

Hello Robert,

Am 27.02.2017 um 05:34 schrieb Robert Nelson:

Quoted 24 lines · Tom Rini
Quoted 13 lines · Tom Rini
Quoted 7 lines

For a long while dtc has warned about various constructs. This is now leading to log file size being exceeded in travis, and as the majority of these errors need to be fixed in the kernel, switch to using the stock device-tree-compiler package.

Applied to u-boot/master, thanks!

Quoted 7 lines

But I'm not happy to have to apply it, either. I do not wish to break travis-ci, but sun7i is now exceeding the allowed stdout size. And these are problems that need to be fixed in the kernel first, rather than here first. The patches to fix u-boot local issues (such as x86 never got picked up either, but likely need to be respun. I expect that once the new DTC version is tagged and populated upstream in the kernel as well, we will be able to re-enable the changes we had here.

Quoted 4 lines

This was fixed (aka a hidden bandaid) in the linux kernel via:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/scripts/Makefile.lib?id=bc553986a2f7c56d0de811485d5312ea29692d5d

Heh... IIRC, I tried to fix a lot of this messages (in U-Boot), around a year ago, and we decided to not apply them in u-boot, instead they should go away via kernel resyncs, when the warnings are fixed in the kernel!

Also I think, I tried a similiar approach as the commit you mentioned... Ah, yes, here:
http://lists.denx.de/pipermail/u-boot/2016-April/252408.html

Quoted 5 lines

We decided (for u-boot) it would be better to fix the problems and not supress the warning, but it seems, the problems get not really fixed in the kernel ...

I wasn;t aware of the above patch in the kernel... thanks for pointing!

and i think by moving the kernel to disable that patch, it's slowed down the number of register fix patches..

Quoted 7 lines

ps, this just came in on kbuild list just a few minutes ago:

https://marc.info/?l=linux-kbuild&m=148817429929267&w=2

one of the issues with bc553986a2f7c56d0de811485d5312ea29692d5d is that it breaks the build with older version of dtc that don't know what to do with the -Wno-unit_address_vs_reg flag..

Coalescing things back in to one thread, yes, for the next release, we should switch over to key'ing the warning based on KBUILD_ENABLE_EXTRA_GCC_CHECKS and only once the patch to conditionally pass the flag in question is possible as well. Thanks all!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170227/3f56de1b/attachment.sig>