Skip to contentSkip to conversation

Fix build for XServer 1.13

PATCH In review Jochen Rollwagen 2 participants 2 messages Mar 5, 2017 – Mar 6, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix build for XServer 1.13

Latest git build stops with the error message

radeon_kms.c: In function 'RADEONWindowExposures_oneshot':
radeon_kms.c:1644:45: error: expected expression before 'RegionPtr'

     pScreen->WindowExposures(pWin, pRegion, RegionPtr pBSRegion);

This patch fixes the build.

---
 src/radeon_kms.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/radeon_kms.c +1 -1
index 572dfcc..7a561fa 100644
@@ -1641,7 +1641,7 @@ static void RADEONWindowExposures_oneshot(WindowPtr pWin, RegionPtr pRegion
 
     pScreen->WindowExposures = info->WindowExposures;
 #if XORG_VERSION_CURRENT < XORG_VERSION_NUMERIC(1,16,99,901,0)
-    pScreen->WindowExposures(pWin, pRegion, RegionPtr pBSRegion);
+    pScreen->WindowExposures(pWin, pRegion, pBSRegion);
 #else
     pScreen->WindowExposures(pWin, pRegion);
 #endif
Signature · 1 line
1.7.9.5
Quoted 1 line

From 8246f1af42cd174501c95c0ba5c00908ace41de9 Mon Sep 17 00:00:00 2001

From: Jochen Rollwagen <[email protected]>
Date: Sun, 5 Mar 2017 11:32:38 +0100
Subject: [PATCH xf86-video-ati] Fix build for XServer 1.13

Latest git build stops with the error message

radeon_kms.c: In function 'RADEONWindowExposures_oneshot':
radeon_kms.c:1644:45: error: expected expression before 'RegionPtr'

     pScreen->WindowExposures(pWin, pRegion, RegionPtr pBSRegion);

This patch fixes the build.

---
 src/radeon_kms.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/radeon_kms.c +1 -1
index 572dfcc..7a561fa 100644
@@ -1641,7 +1641,7 @@ static void RADEONWindowExposures_oneshot(WindowPtr pWin, RegionPtr pRegion
 
     pScreen->WindowExposures = info->WindowExposures;
 #if XORG_VERSION_CURRENT < XORG_VERSION_NUMERIC(1,16,99,901,0)
-    pScreen->WindowExposures(pWin, pRegion, RegionPtr pBSRegion);
+    pScreen->WindowExposures(pWin, pRegion, pBSRegion);
 #else
     pScreen->WindowExposures(pWin, pRegion);
 #endif
Signature · 1 line
1.7.9.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 20 lines · Jochen Rollwagen

Latest git build stops with the error message

radeon_kms.c: In function 'RADEONWindowExposures_oneshot':
radeon_kms.c:1644:45: error: expected expression before 'RegionPtr'

     pScreen->WindowExposures(pWin, pRegion, RegionPtr pBSRegion);

This patch fixes the build.

---
 src/radeon_kms.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/radeon_kms.c +0 -0
index 572dfcc..7a561fa 100644
@@ -1641,7 +1641,7 @@ static void

RADEONWindowExposures_oneshot(WindowPtr pWin, RegionPtr pRegion

     pScreen->WindowExposures = info->WindowExposures;

#if XORG_VERSION_CURRENT < XORG_VERSION_NUMERIC(1,16,99,901,0)

src/radeon_kms.c static void RADEONWindowExposures_oneshot(WindowPtr pWin, RegionPtr pRegion · line 1647

Quoted 5 lines
src/radeon_kms.c +1 -1
-    pScreen->WindowExposures(pWin, pRegion, RegionPtr pBSRegion);
+    pScreen->WindowExposures(pWin, pRegion, pBSRegion);
 #else
     pScreen->WindowExposures(pWin, pRegion);
 #endif

Reviewed and pushed, thanks!

P.S. In the future, please add your Signed-off-by to patches you want to be applied.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx