Skip to contentSkip to conversation

32-bit x86 system reboots automatically on resume from hibernate (ASLR issue?)

DISCUSSION Evgenii Shatokhin 3 participants 5 messages Mar 21, 2017 – Mar 22, 2017

lore
Share & tools
lore
#0 lore raw

Hi,

One of my x86 machines with a 32-bit Linux system (ROSA Linux in this case) automatically reboots when it tries to resume from hibernate. This happens shortly after "Image loading progress 100%" message is shown on the screen.

No traces of the error are in the system log after reboot though.

The problem is present at least in the mainline kernels 4.8 - 4.10. With earlier versions (I tried 4.4, 4.5, etc.), the system resumes OK.

The bisection pointed to the following commit as the first "bad" one:

commit 65fe935dd2387a4faf15314c73f5e6d31ef0217e

Author: Kees Cook <[email protected]>
Date:   Mon Jun 13 15:10:02 2016 -0700

x86/KASLR, x86/power: Remove x86 hibernation restrictions

Hardware: https://linux-hardware.org/index.php?probe=e6a06c64c7
Config used to build the kernel at rev. 65fe935: http://pastebin.com/AxEA6ahb

If I understand it correctly, this commit just enabled ASLR by default regardless of whether hibernation support was present or not. Before this commit, ASLR was disabled on that system because hibernation was supported.

To check if ASLR is really involved here, I rebuilt the kernel with CONFIG_RANDOMIZE_BASE unset - now the system resumes OK from hibernation, no auto reboots, no other visible problems so far.

The problem does not show up in a 64-bit Linux system installed on the same machine. Only the 32-bit system is affected.

Regards,
Evgenii

#1 lore raw
Quoted 11 lines · Evgenii Shatokhin

Hi,

One of my x86 machines with a 32-bit Linux system (ROSA Linux in this case) automatically reboots when it tries to resume from hibernate. This happens shortly after "Image loading progress 100%" message is shown on the screen.

No traces of the error are in the system log after reboot though.

The problem is present at least in the mainline kernels 4.8 - 4.10. With earlier versions (I tried 4.4, 4.5, etc.), the system resumes OK.

Quoted 7 lines

The bisection pointed to the following commit as the first "bad" one:

commit 65fe935dd2387a4faf15314c73f5e6d31ef0217e

Author: Kees Cook <[email protected]>
Date:   Mon Jun 13 15:10:02 2016 -0700

x86/KASLR, x86/power: Remove x86 hibernation restrictions

Hrm, perhaps the 32-bit hibernation code still isn't KASLR-safe. If you boot with nokaslr on the kernel command line, does the problem go away?

Quoted 8 lines

Hardware: https://linux-hardware.org/index.php?probe=e6a06c64c7
Config used to build the kernel at rev. 65fe935:
http://pastebin.com/AxEA6ahb

If I understand it correctly, this commit just enabled ASLR by default regardless of whether hibernation support was present or not. Before this commit, ASLR was disabled on that system because hibernation was supported.

Quoted 6 lines

To check if ASLR is really involved here, I rebuilt the kernel with CONFIG_RANDOMIZE_BASE unset - now the system resumes OK from hibernation, no auto reboots, no other visible problems so far.

The problem does not show up in a 64-bit Linux system installed on the same machine. Only the 32-bit system is affected.

(Why would you want to run 32-bit kernels on a 64-bit system?)

-Kees

Signature · 2 lines
Kees Cook
Pixel Security
#2 lore raw
Quoted 19 lines · Kees Cook
Quoted 17 lines · Evgenii Shatokhin

Hi,

One of my x86 machines with a 32-bit Linux system (ROSA Linux in this case) automatically reboots when it tries to resume from hibernate. This happens shortly after "Image loading progress 100%" message is shown on the screen.

No traces of the error are in the system log after reboot though.

The problem is present at least in the mainline kernels 4.8 - 4.10. With earlier versions (I tried 4.4, 4.5, etc.), the system resumes OK.

The bisection pointed to the following commit as the first "bad" one:

commit 65fe935dd2387a4faf15314c73f5e6d31ef0217e

Author: Kees Cook <[email protected]>
Date:   Mon Jun 13 15:10:02 2016 -0700
Quoted 5 lines
Quoted 1 line

x86/KASLR, x86/power: Remove x86 hibernation restrictions

Hrm, perhaps the 32-bit hibernation code still isn't KASLR-safe. If you boot with nokaslr on the kernel command line, does the problem go away?

Yes. The problem does not show up when I boot the system with 'nokaslr'.

Quoted 9 lines
Quoted 9 lines

Hardware: https://linux-hardware.org/index.php?probe=e6a06c64c7
Config used to build the kernel at rev. 65fe935:
http://pastebin.com/AxEA6ahb

If I understand it correctly, this commit just enabled ASLR by default regardless of whether hibernation support was present or not. Before this commit, ASLR was disabled on that system because hibernation was supported.

Quoted 8 lines
Quoted 6 lines

To check if ASLR is really involved here, I rebuilt the kernel with CONFIG_RANDOMIZE_BASE unset - now the system resumes OK from hibernation, no auto reboots, no other visible problems so far.

The problem does not show up in a 64-bit Linux system installed on the same machine. Only the 32-bit system is affected.

(Why would you want to run 32-bit kernels on a 64-bit system?)

Mostly for testing and debugging.

While most of ROSA Linux users are OK with the 64-bit version of the distro, some still need its 32-bit variant. They reported (unrelated) problems with hibernate. I was debugging these and stumbled upon this problem as well.

Regards,
Evgenii

Quoted 3 lines

-Kees

#3 lore raw
Quoted 28 lines · Evgenii Shatokhin
Quoted 27 lines · Kees Cook
Quoted 22 lines · Evgenii Shatokhin

Hi,

One of my x86 machines with a 32-bit Linux system (ROSA Linux in this case)
automatically reboots when it tries to resume from hibernate. This happens
shortly after "Image loading progress 100%" message is shown on the screen.

No traces of the error are in the system log after reboot though.

The problem is present at least in the mainline kernels 4.8 - 4.10. With earlier versions (I tried 4.4, 4.5, etc.), the system resumes OK.

The bisection pointed to the following commit as the first "bad" one:

commit 65fe935dd2387a4faf15314c73f5e6d31ef0217e

Author: Kees Cook <[email protected]>
Date:   Mon Jun 13 15:10:02 2016 -0700

x86/KASLR, x86/power: Remove x86 hibernation restrictions

Quoted 6 lines
Quoted 3 lines

Hrm, perhaps the 32-bit hibernation code still isn't KASLR-safe. If you boot with nokaslr on the kernel command line, does the problem go away?

Yes. The problem does not show up when I boot the system with 'nokaslr'.

Okay, it looks like we need to either partially revert that commit (i.e. make the by-default-prefer-hibernation logic only happen on 32-bit x86), swap the logic (i.e. by-default-prefer-KASLR on 32-bit), or make KASLR be blocked by hibernation in Kconfig (as it was a long time ago).

Rafael, do you have a preference here?

-Kees

Signature · 2 lines
Kees Cook
Pixel Security
#4 lore raw
Quoted 37 lines · Kees Cook
Quoted 28 lines · Evgenii Shatokhin
Quoted 27 lines · Kees Cook
Quoted 22 lines · Evgenii Shatokhin

Hi,

One of my x86 machines with a 32-bit Linux system (ROSA Linux in this case)
automatically reboots when it tries to resume from hibernate. This happens
shortly after "Image loading progress 100%" message is shown on the screen.

No traces of the error are in the system log after reboot though.

The problem is present at least in the mainline kernels 4.8 - 4.10. With earlier versions (I tried 4.4, 4.5, etc.), the system resumes OK.

The bisection pointed to the following commit as the first "bad" one:

commit 65fe935dd2387a4faf15314c73f5e6d31ef0217e

Author: Kees Cook <[email protected]>
Date:   Mon Jun 13 15:10:02 2016 -0700

x86/KASLR, x86/power: Remove x86 hibernation restrictions

Quoted 6 lines
Quoted 3 lines

Hrm, perhaps the 32-bit hibernation code still isn't KASLR-safe. If you boot with nokaslr on the kernel command line, does the problem go away?

Yes. The problem does not show up when I boot the system with 'nokaslr'.

Quoted 7 lines

Okay, it looks like we need to either partially revert that commit (i.e. make the by-default-prefer-hibernation logic only happen on 32-bit x86), swap the logic (i.e. by-default-prefer-KASLR on 32-bit), or make KASLR be blocked by hibernation in Kconfig (as it was a long time ago).

Rafael, do you have a preference here?

I'd say let's make KASLR and hibernation mutually exclusive on 32-bit and it really doesn't matter to me which one is preferred as long as it is clear that one will be disabled by the other (each way).

And I don't see why 64-bit would need to be affected by this at all, frankly.

I still have a patch from Pavel to improve things in 32-bit hibernation land, but it still requires some time and effort and I don't see volunteers for that work.

Thanks,
Rafael