staging: rtl8712: Fix multiple checkpatch issues.
cover staging: rtl8712: Fix multiple checkpatch issues.
Fixes multiple checkpatch issues in rtl8712 driver.
Varsha Rao (4):
staging: rtl8712: Remove unnecessary parentheses.
staging: rtl8712: Removes the FSF mailing address.
staging: rtl8712: Remove space after a cast.
staging: rtl8712: Match alignment with open parenthesis.
drivers/staging/rtl8712/os_intfs.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
Signature · 1 line
2.9.3
Quoted 10 lines · Varsha Rao
Fixes multiple checkpatch issues in rtl8712 driver.
Varsha Rao (4):
staging: rtl8712: Remove unnecessary parentheses.
staging: rtl8712: Removes the FSF mailing address.
staging: rtl8712: Remove space after a cast.
staging: rtl8712: Match alignment with open parenthesis.drivers/staging/rtl8712/os_intfs.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
Can you resend a whole version 2 (or is it 3) of this patch series? I've dropped your previous patches as they seemed to need more work based on the reviews.
thanks,
greg k-h
Quoted 10 lines · gregkh
Quoted 8 lines · Varsha Rao
Fixes multiple checkpatch issues in rtl8712 driver.
Varsha Rao (4):
staging: rtl8712: Remove unnecessary parentheses.
staging: rtl8712: Removes the FSF mailing address.
staging: rtl8712: Remove space after a cast.
staging: rtl8712: Match alignment with open parenthesis.
Quoted 8 lines
Quoted 2 lines
drivers/staging/rtl8712/os_intfs.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)Can you resend a whole version 2 (or is it 3) of this patch series? I've dropped your previous patches as they seemed to need more work based on the reviews.
I don't know but two patches from the patchset, are already applied.
Those are the following:
1] https://groups.google.com/forum/#!topic/outreachy-kernel/73QR9IxiLnY
2] https://groups.google.com/forum/#!topic/outreachy-kernel/GQMhL7pqSvk
The following are the patches which have not been applied but they are
acknowledged by Julia:
1] https://groups.google.com/forum/#!topic/outreachy-kernel/pnbl9sz45ao 2]
https://groups.google.com/forum/#!topic/outreachy-kernel/aCvHU5BguH0
So do I have to resend them?
Quoted 4 lines
thanks,
greg k-h
Quoted 21 lines · Varsha Rao
On Friday, February 24, 2017 at 10:58:31 PM UTC+5:30, gregkh wrote:
On Sat, Feb 18, 2017 at 01:25:04AM +0530, Varsha Rao wrote:
> Fixes multiple checkpatch issues in rtl8712 driver. >
> Varsha Rao (4):
> staging: rtl8712: Remove unnecessary parentheses. > staging: rtl8712: Removes the FSF mailing address. > staging: rtl8712: Remove space after a cast.
> staging: rtl8712: Match alignment with open parenthesis. >
> drivers/staging/rtl8712/os_intfs.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-)Can you resend a whole version 2 (or is it 3) of this patch series?
I've dropped your previous patches as they seemed to need more work
based on the reviews.
Quoted 13 lines
I don't know but two patches from the patchset, are already applied. Those are the following:
1] https://groups.google.com/forum/#!topic/outreachy-kernel/73QR9IxiLnY
2] https://groups.google.com/forum/#!topic/outreachy-kernel/GQMhL7pqSvk
The following are the patches which have not been applied but they are acknowledged by Julia:
1] https://groups.google.com/forum/#!topic/outreachy-kernel/pnbl9sz45ao
2]
https://groups.google.com/forum/#!topic/outreachy-kernel/aCvHU5BguH0
So do I have to resend them?
Yes. My ack just means that I looked at it an it looks OK. It doesn't mean that it is integrated into the Linux kernel code in any way. Patches get out of date after a while, due to changes on the same or nearby lines of code. So after some time, it is better to update your kernel, redo the changes, and resend the patches.
You can keep my ack in the new version.
julia
Quoted 16 lines
thanks,greg k-h
--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/9b276508-b8aa-4484-970f- 82303cb3d8b4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.