Skip to contentSkip to conversation

ide1=ata66 -- OBSOLETE OPTION, WILL BE REMOVED SOON!

2.6.10-rc2+ Rene Herman 4 participants 7 messages Dec 5, 2004 – Dec 16, 2004

lore
Share & tools
lore
#0 lore raw

Hi Bart.

I see your 2004-11-01 IDE update:

http://lkml.org/lkml/2004/11/1/158

obsoleted the idex=ata66 option, saying that it "should be handled by host drivers needing it". As far as I can see, amd74xx does not handle this?

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Regards,
Rene.

#1 lore raw
Quoted 1 line · Rene Herman

Hi Bart.

Hi,

Quoted 9 lines

I see your 2004-11-01 IDE update:

http://lkml.org/lkml/2004/11/1/158

obsoleted the idex=ata66 option, saying that it "should be handled by host drivers needing it". As far as I can see, amd74xx does not handle this?

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host side cable detection. Well, we can try doing disk side only for it. [ ATi and ITE (in -ac kernels) drivers are also doing this. ]

amd74xx.c renamed from amd74xx.c.orig +2 -4
@@ -344,10 +344,8 @@
 			break;
 
 		case AMD_UDMA_66:
-			pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
-			for (i = 24; i >= 0; i -= 8)
-				if ((u >> i) & 4)
-					amd_80w |= (1 << (1 - (i >> 4)));
+			/* no host side cable detection */
+			amd_80w = 0x03;
 			break;
 	}
#2 lore raw

Bart,

Recall there is a mixed breed out there ... some do some don't. Also I need your snail mail address, I have a case of hardware to send you way. Since you have managed to not go insane yet ... I want to help you get there with ease.

Cheers,

Andre

Andre Hedrick
LAD Storage Consulting Group

Quoted 40 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Rene Herman

Hi Bart.

Hi,

Quoted 9 lines

I see your 2004-11-01 IDE update:

http://lkml.org/lkml/2004/11/1/158

obsoleted the idex=ata66 option, saying that it "should be handled by host drivers needing it". As far as I can see, amd74xx does not handle this?

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host side cable detection. Well, we can try doing disk side only for it. [ ATi and ITE (in -ac kernels) drivers are also doing this. ]

amd74xx.c renamed from amd74xx.c.orig +2 -5
@@ -344,10 +344,8 @@
 			break;
 
 		case AMD_UDMA_66:
-			pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
-			for (i = 24; i >= 0; i -= 8)
-				if ((u >> i) & 4)
-					amd_80w |= (1 << (1 - (i >> 4)));
+			/* no host side cable detection */
+			amd_80w = 0x03;
 			break;
 	}
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 13 lines · Bartlomiej Zolnierkiewicz
Quoted 2 lines

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host side cable detection. Well, we can try doing disk side only for it. [ ATi and ITE (in -ac kernels) drivers are also doing this. ]

amd74xx.c renamed from amd74xx.c.orig +0 -0
@@ -344,10 +344,8 @@
 			break;
 

amd74xx.c line 351

Quoted 10 lines
amd74xx.c renamed from amd74xx.c.orig +2 -4
 		case AMD_UDMA_66:
-			pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
-			for (i = 24; i >= 0; i -= 8)
-				if ((u >> i) & 4)
-					amd_80w |= (1 << (1 - (i >> 4)));
+			/* no host side cable detection */
+			amd_80w = 0x03;
 			break;
 	}
 

Well, yes, works for me I guess. Was playing around to see if I could find something a bit more subtle but it seems nothing's available. My BIOS does show hdc (a DVD-ROM by the way) to be udma4 in its summary screen but it does not enable udma for it. I saw AMD_DRIVE_TIMINGS is not used for udma (and programmed by my BIOS to the highest PIO mode the device offers for all devices present) so also of no use...

Attached patch combines this and deleting a "use ide0=ata66" advice from the driver.

One slight cosmetic problem, with amd_80w set unconditionally the /proc/ide/amd74xx file's "cable type" line will now always show "80w" and seems likely to confuse people that have 40w cables installed. I believe the proc file may be on its way out anyway? If not, one option could be to print "n/a" for amd_config->flags & AMD_UDMA == AMD_UDMA_66 (<= ?).

Rene.

drivers/ide/pci/amd74xx.c renamed from drivers/ide/pci/amd74xx.c.orig +2 -6
@@ -344,10 +344,8 @@
 			break;
 
 		case AMD_UDMA_66:
-			pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
-			for (i = 24; i >= 0; i -= 8)
-				if ((u >> i) & 4)
-					amd_80w |= (1 << (1 - (i >> 4)));
+			/* no host side cable detection */
+			amd_80w = 0x03;
 			break;
 	}
 
@@ -383,8 +381,6 @@
 	if (amd_clock < 20000 || amd_clock > 50000) {
 		printk(KERN_WARNING "%s: User given PCI clock speed impossible (%d), using 33 MHz instead.\n",
 			amd_chipset->name, amd_clock);
-		printk(KERN_WARNING "%s: Use ide0=ata66 if you want to assume 80-wire cable\n",
-			amd_chipset->name);
 		amd_clock = 33333;
 	}
 
#4 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 6 lines · Bartlomiej Zolnierkiewicz
Quoted 2 lines

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host side cable detection. Well, we can try doing disk side only for it. [ ATi and ITE (in -ac kernels) drivers are also doing this. ]

That is probably a good change but not sufficient for things like bladeservers where some vendors use short 40c cables which are within specification but break drive side detection. Removing ata66 forcing doesn't work because of these although perhaps it could be done using subvendor ids so it is automatic ?

Right now I plan to keep ata66 overrides in -ac.

Alan

#5 lore raw
Quoted 8 lines · Alan Cox
Quoted 6 lines · Bartlomiej Zolnierkiewicz
Quoted 2 lines

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host side cable detection. Well, we can try doing disk side only for it. [ ATi and ITE (in -ac kernels) drivers are also doing this. ]

Quoted 5 lines

That is probably a good change but not sufficient for things like bladeservers where some vendors use short 40c cables which are within specification but break drive side detection. Removing ata66 forcing doesn't work because of these although perhaps it could be done using subvendor ids so it is automatic ?

Yes, one of the aims of deprecating ata66 override was to see what can be done automatically. The fewer special kernel parameters the better (w/o sacrificing functionality of course).

Quoted 1 line

Right now I plan to keep ata66 overrides in -ac.

Fine but I'm not going to remove them soon (warning is a bit strong to help us gain more knowledge :), however it would be nice if somebody could move them from IDE core to specific host drivers.

Bartlomiej

#6 lore raw
Quoted 15 lines · Bartlomiej Zolnierkiewicz
Quoted 8 lines · Alan Cox
Quoted 6 lines · Bartlomiej Zolnierkiewicz
Quoted 2 lines

I do need a way to force an 80c cable on this AMD756 (ATA66 max) board, since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host side cable detection. Well, we can try doing disk side only for it. [ ATi and ITE (in -ac kernels) drivers are also doing this. ]

Quoted 5 lines

That is probably a good change but not sufficient for things like bladeservers where some vendors use short 40c cables which are within specification but break drive side detection. Removing ata66 forcing doesn't work because of these although perhaps it could be done using subvendor ids so it is automatic ?

Quoted 3 lines

Yes, one of the aims of deprecating ata66 override was to see what can be done automatically. The fewer special kernel parameters the better (w/o sacrificing functionality of course).

One thing I forgot - ata66 override alone ("idex=ata66") currently doesn't help in the case you've described - it overrides host side only.

Quoted 7 lines
Quoted 1 line

Right now I plan to keep ata66 overrides in -ac.

Fine but I'm not going to remove them soon (warning is a bit strong to help us gain more knowledge :), however it would be nice if somebody could move them from IDE core to specific host drivers.

Bartlomiej