Potential concurrency bug in ide-disk.c ?
Hi,
The way file ide-disk.c handles usage count, it seems to me that its concurrency bug.
In open method and release, it uses code as follows
static int idedisk_open(struct inode *inode, struct file *filp)
{
ide_drive_t *drive = inode->i_bdev->bd_disk->private_data;
drive->usage++;
if (drive->removable && drive->usage == 1) {
ide_task_t args;
memset(&args, 0, sizeof(ide_task_t));
args.tfRegister[IDE_COMMAND_OFFSET] = WIN_DOORLOCK;
args.command_type = IDE_DRIVE_TASK_NO_DATA;
args.handler = &task_no_data_intr;
check_disk_change(inode->i_bdev);
/*
* Ignore the return code from door_lock,
* since the open() has already succeeded,
* and the door_lock is irrelevant at this point.
*/
if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL))
drive->doorlocking = 0;
}
return 0;
}Here, if drive->usage=0 initially and two process concurrently executes drive->usage++, then drive->usage will become 2. Both of them will think that drive is already initialized. Something similar can happen in case of release.
I think a semaphore need to be added inide_drive_t structure and method should be modified as
static int idedisk_open(struct inode *inode, struct file *filp)
{
ide_drive_t *drive = inode->i_bdev->bd_disk->private_data;
if(down_interruptible(&drive->sem)){
/*error handling code*/
}
drive->usage++;
if (drive->removable && drive->usage == 1) {
ide_task_t args;
memset(&args, 0, sizeof(ide_task_t));
args.tfRegister[IDE_COMMAND_OFFSET] = WIN_DOORLOCK;
args.command_type = IDE_DRIVE_TASK_NO_DATA;
args.handler = &task_no_data_intr;
check_disk_change(inode->i_bdev);
/*
* Ignore the return code from door_lock,
* since the open() has already succeeded,
* and the door_lock is irrelevant at this point.
*/
if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL))
drive->doorlocking = 0;
}
up(&drive->sem);
return 0;
}Similar modifications are also required in release.
Please let me know if there is anything wrong in above code. Also let me know to whom I should offer patches for this.
Signature · 4 lines
Regards, Tushar -------------------- It's not a problem, it's an opportunity for improvement. Lets improve.
Quoted 61 lines · Tushar Adeshara
Hi,
The way fileide-disk.chandles usage count, it seems to me that its concurrency bug.
In open method and release, it uses code as followsstatic int
idedisk_open(struct inode *inode, struct file *filp){ ide_drive_t *drive = inode->i_bdev->bd_disk->private_data; drive->usage++; if (drive->removable && drive->usage == 1) { ide_task_t args; memset(&args, 0, sizeof(ide_task_t)); args.tfRegister[IDE_COMMAND_OFFSET] = WIN_DOORLOCK; args.command_type = IDE_DRIVE_TASK_NO_DATA; args.handler = &task_no_data_intr; check_disk_change(inode->i_bdev); /* * Ignore the return code from door_lock, * since the open() has already succeeded, * and the door_lock is irrelevant at this point. */ if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL)) drive->doorlocking = 0; } return 0; }Here, if drive->usage=0 initially and two process concurrently executes drive->usage++, then
drive->usagewill become 2. Both of them will think that drive is already initialized. Something similar can happen in case of release.
I think a semaphore need to be added inide_drive_tstructure and method should be modified asstatic int
idedisk_open(struct inode *inode, struct file *filp){ ide_drive_t *drive = inode->i_bdev->bd_disk->private_data; if(down_interruptible(&drive->sem)){ /*error handling code*/ } drive->usage++; if (drive->removable && drive->usage == 1) { ide_task_t args; memset(&args, 0, sizeof(ide_task_t)); args.tfRegister[IDE_COMMAND_OFFSET] = WIN_DOORLOCK; args.command_type = IDE_DRIVE_TASK_NO_DATA; args.handler = &task_no_data_intr; check_disk_change(inode->i_bdev); /* * Ignore the return code from door_lock, * since the open() has already succeeded, * and the door_lock is irrelevant at this point. */ if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL)) drive->doorlocking = 0; } up(&drive->sem); return 0; }
Quoted 1 line
Similar modifications are also required in release.
Not a problem in practice as idedisk_open() and idedisk_release() are only used in fs/block_dev.c (grep for fops->open and fops->release) and are protected against concurrent execution by bdev->bd_sem.
Bartlomiej
Quoted 4 lines · Bartlomiej Zolnierkiewicz
Quoted 3 lines · Tushar Adeshara
Hi,
The way fileide-disk.chandles usage count, it seems to me that its concurrency bug.roblem in practice asidedisk_open()andidedisk_release()
are only used in fs/block_dev.c (grep for fops->open and fops
Quoted 44 lines
Quoted 44 lines
In open method and release, it uses code as follows
static int
idedisk_open(struct inode *inode, struct file *filp){ ide_drive_t *drive = inode->i_bdev->bd_disk->private_data; drive->usage++; if (drive->removable && drive->usage == 1) { ide_task_t args; memset(&args, 0, sizeof(ide_task_t)); args.tfRegister[IDE_COMMAND_OFFSET] = WIN_DOORLOCK; args.command_type = IDE_DRIVE_TASK_NO_DATA; args.handler = &task_no_data_intr; check_disk_change(inode->i_bdev); /* * Ignore the return code from door_lock, * since the open() has already succeeded, * and the door_lock is irrelevant at this point. */ if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL)) drive->doorlocking = 0; } return 0; }Here, if drive->usage=0 initially and two process concurrently executes drive->usage++, then
drive->usagewill become 2. Both of them will think that drive is already initialized. Something similar can happen in case of release.
I think a semaphore need to be added inide_drive_tstructure and method should be modified asstatic int
idedisk_open(struct inode *inode, struct file *filp){ ide_drive_t *drive = inode->i_bdev->bd_disk->private_data; if(down_interruptible(&drive->sem)){ /*error handling code*/ } drive->usage++; if (drive->removable && drive->usage == 1) { ide_task_t args; memset(&args, 0, sizeof(ide_task_t)); args.tfRegister[IDE_COMMAND_OFFSET] = WIN_DOORLOCK;
Quoted 8 lines
Quoted 8 lines
args.command_type = IDE_DRIVE_TASK_NO_DATA; args.handler = &task_no_data_intr; check_disk_change(inode->i_bdev); /* * Ignore the return code from door_lock, * since the open() has already succeeded, * and the door_lock is irrelevant at this point. */roblem in practice as idedisk_open() and idedisk_release()
are only used in fs/block_dev.c (grep for fops->open and fops
Quoted 8 lines
Quoted 7 lines
if (drive->doorlocking && ide_raw_taskfile(drive, &args, NULL)) drive->doorlocking = 0; } up(&drive->sem); return 0; }Similar modifications are also required in release.
Quoted 5 lines
Not a problem in practice as
idedisk_open()andidedisk_release()are only used infs/block_dev.c(grep forfops->openandfops->release) and are protected against concurrent execution bybdev->bd_sem.Bartlomiej
Its ok. Thanks.
Quoted 1 line
--
Regards,
Tushar
--------------------
It's not a problem, it's an opportunity for improvement. Lets improve.