Skip to contentSkip to conversation

drm/amdgpu/swsmu: add missing callback for gfx state change

PATCH In review Alex Deucher 3 participants 4 messages Nov 13, 2020 – Nov 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amdgpu/swsmu: add missing callback for gfx state change

The function was added, but the callback was not registered, possibly lost in a rebase.

---
 drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c +1 -0
index c4e205c33aef..46c44f0abdfb 100644
@@ -1177,6 +1177,7 @@ static const struct pptable_funcs renoir_ppt_funcs = {
 	.get_pp_feature_mask = smu_cmn_get_pp_feature_mask,
 	.set_pp_feature_mask = smu_cmn_set_pp_feature_mask,
 	.get_gpu_metrics = renoir_get_gpu_metrics,
+	.gfx_state_change_set = renoir_gfx_state_change_set,
 };
 
 void renoir_set_ppt_funcs(struct smu_context *smu)
Signature · 6 lines
2.25.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

PATCH 2/2 drm/amdgpu/powerplay/smu10: drop unused variable

Never used so drop it.

---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +0 -2
index 50308a5573e4..04226b1544e4 100644
@@ -1441,8 +1441,6 @@ static int smu10_set_fine_grain_clk_vol(struct pp_hwmgr *hwmgr,
 
 static int smu10_gfx_state_change(struct pp_hwmgr *hwmgr, uint32_t state)
 {
-	struct amdgpu_device *adev = hwmgr->adev;
-
 	smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_GpuChangeState, state, NULL);
 
 	return 0;
Signature · 6 lines
2.25.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/amdgpu/powerplay/smu10: drop unused variable

For the series:

Quoted 13 lines · Alex Deucher

Never used so drop it.

---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +0 -0
index 50308a5573e4..04226b1544e4 100644

drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c static int smu10_set_fine_grain_clk_vol(struct pp_hwmgr *hwmgr, · line 1446

Quoted 8 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +0 -2
@@ -1441,8 +1441,6 @@ static int smu10_set_fine_grain_clk_vol(struct pp_hwmgr *hwmgr,
 
 static int smu10_gfx_state_change(struct pp_hwmgr *hwmgr, uint32_t state)
 {
-	struct amdgpu_device *adev = hwmgr->adev;
-
 	smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_GpuChangeState, state, NULL);
 
 	return 0;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw

RE: [PATCH 2/2] drm/amdgpu/powerplay/smu10: drop unused variable

In reply to Alex Deucher

[AMD Official Use Only - Internal Distribution Only]

Thanks help handle this and that should be also handled in my last patch series sent out. Sorry for this rebase splash error and will take care on this.

Thanks,
Prike

Quoted 34 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Saturday, November 14, 2020 4:41 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH 2/2] drm/amdgpu/powerplay/smu10: drop unused variable

Never used so drop it.

---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +0 -2
index 50308a5573e4..04226b1544e4 100644
@@ -1441,8 +1441,6 @@ static int smu10_set_fine_grain_clk_vol(struct
 pp_hwmgr *hwmgr,
 
 static int smu10_gfx_state_change(struct pp_hwmgr *hwmgr, uint32_t state)
 {
-struct amdgpu_device *adev = hwmgr->adev;
-
 smum_send_msg_to_smc_with_parameter(hwmgr,
 PPSMC_MSG_GpuChangeState, state, NULL);

return 0;
--
2.25.4

Quoted 11 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=04%7C01%7CPrike.Liang%40amd.com%7Caf1fc360bf2b415a6 6f708d888146937%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 37408968554801059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdat a=AXA1E00WPiiOvYqJLcFCZbhLndwFn8T%2BqximgzLo2%2FQ%3D&amp;reser ved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx