Skip to contentSkip to conversation

Fixes for FS-Cache/CacheFiles [try #2]

GIT PULL David Howells 1 participant 1 message Sep 22, 2014

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Could you pull these fixes for FS-Cache and Cachefiles:

(1) Put a timeout in releasepage() to deal with a recursive hang between the memory allocator, writeback, ext4 and fscache under memory pressure.

(2) Fix a pair of refcount bugs in the fscache error handling.

(3) Remove a couple of unused pagevecs. This could be punted to -next if you'd rather.

(4) The cachefiles requirement that the base directory support rename should permit rename2 as an alternative - otherwise certain filesystems cannot now be used as backing stores (such as ext4).

I've fixed a bug in "FS-Cache: refcount becomes corrupt under vma pressure." whereby fscache_unuse_cookie() was being passed a cookie rather than an object pointing to that cookie.

Thanks,
David
---
The following changes since commit 68e370289c29e3beac99d59c6d840d470af9dfcf:

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (2014-08-26 13:50:23 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/fscache-fixes-20140917

for you to fetch changes up to e2cf1f1cc7636bd860e47cd0ad6194da8975f8b5:

CacheFiles: Handle rename2 (2014-09-17 23:29:53 +0100)

----------------------------------------------------------------
FS-Cache fixes

----------------------------------------------------------------
David Howells (1):
CacheFiles: Handle rename2

Milosz Tanski (3):
FS-Cache: Timeout for releasepage()
FS-Cache: Reduce cookie ref count if submit fails.
FS-Cache: refcount becomes corrupt under vma pressure.

NeilBrown (1):
cachefiles: remove two unused pagevecs.

 fs/cachefiles/namei.c |  3 ++-
 fs/cachefiles/rdwr.c  |  6 ------
 fs/fscache/object.c   |  1 +
 fs/fscache/page.c     | 25 +++++++++++++++++++++----
 4 files changed, 24 insertions(+), 11 deletions(-)