Request for review for 4.4-st64, 4.4-cip99
Hi!
Here's the manual backports for the upcoming 4.4 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
21503a13375d5 qlcnic: fix memory leak issues in qlcnic_sriov_common.c 952bc6f3a0ebb HID: ignore non-functional sensor in HP 5MP Camera ece0f8e21aa7f net_sched: Prevent creation of classes with TC_H_ROOT
There is also one new patch that I added mostly for my own benefit:
18a3ce42a20f0 mm/sparsemem: silence "'mem_section' will never be NULL" warning
Thanks for having a look!
CU
Uli
Hi!
Quoted 2 lines
Here's the manual backports for the upcoming 4.4 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
These are ok:
a GFP_KERNEL failures are mostly theoretical > 21503a13375d5 qlcnic: fix memory leak issues in qlcnic_sriov_common.c a just a hw bug workaround > 952bc6f3a0ebb HID: ignore non-functional sensor in HP 5MP Camera
Are you sure about this one?
!! > ece0f8e21aa7f net_sched: Prevent creation of classes with TC_H_ROOT
Unlike newer kernels, out: has non-trivial cleanup, so we probably want to goto there.
Quoted 3 lines
There is also one new patch that I added mostly for my own benefit:
18a3ce42a20f0mm/sparsemem: silence "'mem_section' will never be NULL" warning
Looks good. I'd quote commit id in the log ...
This is similar in function to the upstream patch a431dbbc540532b7465eae4fc8b56a85a9fc7d17 "mm/sparsemem: fix 'mem_section' will never be NULL gcc 12 warning" but avoids adding extra checks to minimize the potential for regressions.
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hi!
Thanks for the reviews.
Quoted 7 lines · CEST Pavel Machek via lists.cip-project.org
Are you sure about this one?
!! >
ece0f8e21aa7fnet_sched: Prevent creation of classes withTC_H_ROOTUnlike newer kernels, out: has non-trivial cleanup, so we probably want to goto there.
Good point. Fixed.
Quoted 3 lines
Quoted 1 line
18a3ce42a20f0mm/sparsemem: silence "'mem_section' will never be NULL" warningLooks good. I'd quote commit id in the log ...
Likewise.
CU
Uli