Skip to contentSkip to conversation

powerpc: Restore core of mpc8xx

PATCH Superseded Christophe Leroy 4 participants 6 messages Jun 23, 2017 – Jun 26, 2017

Subsystems (8)

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 powerpc: Restore core of mpc8xx

---
v4: Restored some common CONFIG_ removed by 5xx removal in README and config_whitelist
Removed all impacts on 4xx; Removed a few remaining references to 82xx Fixed unbalanced #ifdef in i2c

v3: Fixed build error in arch/powerpc/include/asm/ppc.h ; removed commproc.h from 4xx

v2: Tom squashed patches 1-10 of the serie

 .travis.yml                            |    2 +
 MAINTAINERS                            |    7 +-
 README                                 |  118 ++-
 api/api_platform-powerpc.c             |    3 +-
 arch/powerpc/Kconfig                   |    4 +
 arch/powerpc/cpu/mpc8xx/Kconfig        |   13 +
 arch/powerpc/cpu/mpc8xx/Makefile       |   25 +
 arch/powerpc/cpu/mpc8xx/bedbug_860.c   |  314 ++++++++
 arch/powerpc/cpu/mpc8xx/config.mk      |    8 +
 arch/powerpc/cpu/mpc8xx/cpu.c          |  580 +++++++++++++
 arch/powerpc/cpu/mpc8xx/cpu_init.c     |  218 +++++
 arch/powerpc/cpu/mpc8xx/fdt.c          |   27 +
 arch/powerpc/cpu/mpc8xx/fec.c          |  933 +++++++++++++++++++++
 arch/powerpc/cpu/mpc8xx/fec.h          |   12 +
 arch/powerpc/cpu/mpc8xx/interrupts.c   |  278 +++++++
 arch/powerpc/cpu/mpc8xx/kgdb.S         |   54 ++
 arch/powerpc/cpu/mpc8xx/plprcr_write.S |  119 +++
 arch/powerpc/cpu/mpc8xx/scc.c          |  472 +++++++++++
 arch/powerpc/cpu/mpc8xx/serial.c       |  676 ++++++++++++++++
 arch/powerpc/cpu/mpc8xx/speed.c        |  385 +++++++++
 arch/powerpc/cpu/mpc8xx/spi.c          |  533 ++++++++++++
 arch/powerpc/cpu/mpc8xx/start.S        |  650 +++++++++++++++
 arch/powerpc/cpu/mpc8xx/traps.c        |  216 +++++
 arch/powerpc/cpu/mpc8xx/upatch.c       |  194 +++++
 arch/powerpc/cpu/mpc8xx/video.c        | 1123 ++++++++++++++++++++++++++
 arch/powerpc/include/asm/8xx_immap.h   |  515 ++++++++++++
 arch/powerpc/include/asm/cache.h       |   41 +-
 arch/powerpc/include/asm/global_data.h |    3 +
 arch/powerpc/include/asm/iopin_8xx.h   |  379 +++++++++
 arch/powerpc/include/asm/ppc.h         |   16 +
 arch/powerpc/include/asm/processor.h   |   17 +-
 arch/powerpc/include/asm/status_led.h  |   73 ++
 arch/powerpc/lib/Makefile              |    1 +
 arch/powerpc/lib/ide.c                 |  184 +++++
 arch/powerpc/lib/ide.h                 |   15 +
 arch/powerpc/lib/immap.c               |  564 +++++++++++++
 arch/powerpc/lib/time.c                |   11 +
 cmd/bdinfo.c                           |    3 +-
 cmd/bedbug.c                           |    4 +
 cmd/ide.c                              |    9 +-
 cmd/pcmcia.c                           |    4 +
 cmd/reginfo.c                          |   59 +-
 cmd/source.c                           |    3 +
 common/board_f.c                       |    5 +-
 common/board_r.c                       |   14 +
 common/bootm_os.c                      |   14 +-
 common/lcd.c                           |    4 +
 doc/README.MPC866                      |   24 +
 doc/README.fsl-clk                     |    5 +
 doc/README.scrapyard                   |    1 +
 drivers/block/ide.c                    |   11 +
 drivers/block/sil680.c                 |    1 +
 drivers/bootcount/bootcount.c          |    5 +
 drivers/i2c/i2c_core.c                 |   11 +
 drivers/i2c/soft_i2c.c                 |    5 +
 drivers/pcmcia/Makefile                |    1 +
 drivers/pcmcia/mpc8xx_pcmcia.c         |  258 ++++++
 drivers/rtc/Makefile                   |    1 +
 drivers/rtc/mpc8xx.c                   |   60 ++
 drivers/serial/serial.c                |    3 -
 drivers/usb/gadget/Makefile            |    1 +
 drivers/usb/gadget/mpc8xx_udc.c        | 1386 ++++++++++++++++++++++++++++++++
 drivers/video/Makefile                 |    1 +
 drivers/video/mpc8xx_lcd.c             |  400 +++++++++
 examples/standalone/Makefile           |    2 +
 examples/standalone/test_burst.c       |  284 +++++++
 examples/standalone/test_burst.h       |   22 +
 examples/standalone/test_burst_lib.S   |  154 ++++
 examples/standalone/timer.c            |  333 ++++++++
 include/asm-generic/global_data.h      |    2 +-
 include/asm-generic/u-boot.h           |    3 +-
 include/commproc.h                     |  791 ++++++++++++++++++
 include/i2c.h                          |   24 +-
 include/lcd.h                          |    4 +-
 include/mpc823_lcd.h                   |   44 +
 include/net.h                          |    4 +
 include/pcmcia.h                       |   16 +-
 include/post.h                         |    7 +-
 include/ppc_asm.tmpl                   |   46 ++
 include/usb/mpc8xx_udc.h               |  178 ++++
 include/watchdog.h                     |    5 +
 post/Makefile                          |    1 +
 post/cpu/mpc8xx/Makefile               |    9 +
 post/cpu/mpc8xx/cache.c                |   62 ++
 post/cpu/mpc8xx/cache_8xx.S            |  477 +++++++++++
 post/cpu/mpc8xx/ether.c                |  530 ++++++++++++
 post/cpu/mpc8xx/spr.c                  |  132 +++
 post/cpu/mpc8xx/uart.c                 |  508 ++++++++++++
 post/cpu/mpc8xx/usb.c                  |  249 ++++++
 post/cpu/mpc8xx/watchdog.c             |   59 ++
 post/tests.c                           |   12 +
 scripts/config_whitelist.txt           |   68 +-
 92 files changed, 15047 insertions(+), 55 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc8xx/Kconfig
 create mode 100644 arch/powerpc/cpu/mpc8xx/Makefile
 create mode 100644 arch/powerpc/cpu/mpc8xx/bedbug_860.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/config.mk
 create mode 100644 arch/powerpc/cpu/mpc8xx/cpu.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/cpu_init.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fdt.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fec.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fec.h
 create mode 100644 arch/powerpc/cpu/mpc8xx/interrupts.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/kgdb.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/plprcr_write.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/scc.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/serial.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/speed.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/spi.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/start.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/traps.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/upatch.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/video.c
 create mode 100644 arch/powerpc/include/asm/8xx_immap.h
 create mode 100644 arch/powerpc/include/asm/iopin_8xx.h
 create mode 100644 arch/powerpc/include/asm/status_led.h
 create mode 100644 arch/powerpc/lib/ide.c
 create mode 100644 arch/powerpc/lib/ide.h
 create mode 100644 arch/powerpc/lib/immap.c
 create mode 100644 doc/README.MPC866
 create mode 100644 doc/README.fsl-clk
 create mode 100644 drivers/pcmcia/mpc8xx_pcmcia.c
 create mode 100644 drivers/rtc/mpc8xx.c
 create mode 100644 drivers/usb/gadget/mpc8xx_udc.c
 create mode 100644 drivers/video/mpc8xx_lcd.c
 create mode 100644 examples/standalone/test_burst.c
 create mode 100644 examples/standalone/test_burst.h
 create mode 100644 examples/standalone/test_burst_lib.S
 create mode 100644 examples/standalone/timer.c
 create mode 100644 include/commproc.h
 create mode 100644 include/mpc823_lcd.h
 create mode 100644 include/usb/mpc8xx_udc.h
 create mode 100644 post/cpu/mpc8xx/Makefile
 create mode 100644 post/cpu/mpc8xx/cache.c
 create mode 100644 post/cpu/mpc8xx/cache_8xx.S
 create mode 100644 post/cpu/mpc8xx/ether.c
 create mode 100644 post/cpu/mpc8xx/spr.c
 create mode 100644 post/cpu/mpc8xx/uart.c
 create mode 100644 post/cpu/mpc8xx/usb.c
 create mode 100644 post/cpu/mpc8xx/watchdog.c
.travis.yml +2 -0
index a534743911..c4d96a0338 100644
@@ -210,6 +210,8 @@ matrix:
     - env:
         - BUILDMAN="mpc86xx"
     - env:
+        - BUILDMAN="mpc8xx"
+    - env:
         - BUILDMAN="siemens"
     - env:
         - BUILDMAN="tegra"
MAINTAINERS +1 -6
index 37cefdbd53..a4a44174a2 100644
@@ -324,16 +324,11 @@ F:	arch/powerpc/
 
 POWERPC MPC8XX
 M:	Wolfgang Denk <[email protected]>
+M:	Christophe Leroy <[email protected]>
 S:	Maintained
 T:	git git://git.denx.de/u-boot-mpc8xx.git
 F:	arch/powerpc/cpu/mpc8xx/
 
-POWERPC MPC82XX
-M:	Wolfgang Denk <[email protected]>
-S:	Maintained
-T:	git git://git.denx.de/u-boot-mpc82xx.git
-F:	arch/powerpc/cpu/mpc82*/
-
 POWERPC MPC83XX
 M:	Mario Six <[email protected]>
 S:	Maintained
README +112 -6

200 lines not on this page · raw message

api/api_platform-powerpc.c +2 -1
index d1b54ea4e1..fcfa2ad8ff 100644
@@ -30,7 +30,8 @@ int platform_sys_info(struct sys_info *si)
 	si->clk_bus = gd->bus_clk;
 	si->clk_cpu = gd->cpu_clk;
 
-#if defined(CONFIG_E500) || defined(CONFIG_MPC86xx)
+#if defined(CONFIG_8xx) || \
+    defined(CONFIG_E500) || defined(CONFIG_MPC86xx)
 #define bi_bar	bi_immr_base
 #elif defined(CONFIG_MPC83xx)
 #define bi_bar	bi_immrbar
arch/powerpc/Kconfig +4 -0
index d030610105..8cab8508ac 100644
@@ -29,6 +29,9 @@ config MPC86xx
 	select SYS_FSL_DDR
 	select SYS_FSL_DDR_BE
 
+config 8xx
+	bool "MPC8xx"
+
 config 4xx
 	bool "PPC4xx"
 	select CREATE_ARCH_SYMLINK
@@ -39,6 +42,7 @@ endchoice
 source "arch/powerpc/cpu/mpc83xx/Kconfig"
 source "arch/powerpc/cpu/mpc85xx/Kconfig"
 source "arch/powerpc/cpu/mpc86xx/Kconfig"
+source "arch/powerpc/cpu/mpc8xx/Kconfig"
 source "arch/powerpc/cpu/ppc4xx/Kconfig"
 
 endmenu
arch/powerpc/cpu/mpc8xx/Kconfig new file +13 -0
new file mode 100644
index 0000000000..a425cba8aa
@@ -0,0 +1,13 @@
+menu "mpc8xx CPU"
+	depends on 8xx
+
+config SYS_CPU
+	default "mpc8xx"
+
+choice
+	prompt "Target select"
+	optional
+
+endchoice
+
+endmenu
arch/powerpc/cpu/mpc8xx/Makefile new file +25 -0
new file mode 100644
index 0000000000..fc91a054f0
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+# ccflags-y += -DET_DEBUG
+
+extra-y += start.o
+extra-y += traps.o
+obj-y	+= bedbug_860.o
+obj-y	+= cpu.o
+obj-y	+= cpu_init.o
+obj-y	+= fec.o
+obj-$(CONFIG_OF_LIBFDT) += fdt.o
+obj-y	+= interrupts.o
+obj-y	+= scc.o
+obj-y	+= serial.o
+obj-y	+= speed.o
+obj-y	+= spi.o
+obj-y	+= upatch.o
+obj-y	+= video.o
+obj-y	+= kgdb.o
+obj-y	+= plprcr_write.o
arch/powerpc/cpu/mpc8xx/bedbug_860.c new file +314 -0

314 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/config.mk new file +8 -0
new file mode 100644
index 0000000000..485e43d2de
@@ -0,0 +1,8 @@
+#
+# (C) Copyright 2000-2010
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+PLATFORM_CPPFLAGS += -mstring -mcpu=860 -msoft-float
arch/powerpc/cpu/mpc8xx/cpu.c new file +580 -0

580 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/cpu_init.c new file +218 -0

218 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/fdt.c new file +27 -0
new file mode 100644
index 0000000000..34d36478d3
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2008 (C) Bryan O'Donoghue
+ *
+ * Code copied & edited from Freescale mpc85xx stuff.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <common.h>
+#include <libfdt.h>
+#include <fdt_support.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+void ft_cpu_setup(void *blob, bd_t *bd)
+{
+	do_fixup_by_prop_u32(blob, "device_type", "cpu", 4,
+		"timebase-frequency", get_tbclk(), 1);
+	do_fixup_by_prop_u32(blob, "device_type", "cpu", 4,
+		"bus-frequency", bd->bi_busfreq, 1);
+	do_fixup_by_prop_u32(blob, "device_type", "cpu", 4,
+		"clock-frequency", bd->bi_intfreq, 1);
+	do_fixup_by_compat_u32(blob, "fsl,cpm-brg", "clock-frequency",
+		gd->arch.brg_clk, 1);
+
+	fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
+}
arch/powerpc/cpu/mpc8xx/fec.c new file +933 -0

933 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/fec.h new file +12 -0
new file mode 100644
index 0000000000..e025c3f464
@@ -0,0 +1,12 @@
+/*
+ * (C) Copyright 2000
+ * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef	_FEC_H_
+#define	_FEC_H_
+
+
+#endif	/* _FEC_H_ */
arch/powerpc/cpu/mpc8xx/interrupts.c new file +278 -0

278 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/kgdb.S new file +54 -0

54 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/plprcr_write.S new file +119 -0

119 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/scc.c new file +472 -0

169 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/serial.c new file +676 -0

676 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/speed.c new file +385 -0

385 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/spi.c new file +533 -0

533 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/start.S new file +650 -0

650 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/traps.c new file +216 -0

216 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/upatch.c new file +194 -0

194 lines not on this page · raw message

arch/powerpc/cpu/mpc8xx/video.c new file +1123 -0

1,123 lines not on this page · raw message

arch/powerpc/include/asm/8xx_immap.h new file +515 -0

515 lines not on this page · raw message

arch/powerpc/include/asm/cache.h +40 -1

41 lines not on this page · raw message

arch/powerpc/include/asm/global_data.h +3 -0
index d0c3fa05f8..2efa6240c5 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/include/asm/iopin_8xx.h new file +379 -0

379 lines not on this page · raw message

arch/powerpc/include/asm/ppc.h +16 -0
index 4d9af6c37c..1825813af0 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/include/asm/processor.h +4 -13
index 6549a0936f..965af636df 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/include/asm/status_led.h new file +73 -0

73 lines not on this page · raw message

arch/powerpc/lib/Makefile +1 -0
index 4e47e83930..6bbb8ca14d 100644

Lines of this file are not shown. View the raw message.

arch/powerpc/lib/ide.c new file +184 -0

184 lines not on this page · raw message

arch/powerpc/lib/ide.h new file +15 -0
new file mode 100644
index 0000000000..e0b2e6197b

Lines of this file are not shown. View the raw message.

arch/powerpc/lib/immap.c new file +564 -0

564 lines not on this page · raw message

arch/powerpc/lib/time.c +11 -0
index 3a5ad4d8d2..4cbb65eb68 100644

Lines of this file are not shown. View the raw message.

cmd/bdinfo.c +2 -1
index 48dba20936..24cae6385e 100644

Lines of this file are not shown. View the raw message.

cmd/bedbug.c +4 -0
index 32067575ed..2a96f0fae7 100644

Lines of this file are not shown. View the raw message.

cmd/ide.c +7 -2
index 10fb2f95a7..0fd401b3c4 100644

Lines of this file are not shown. View the raw message.

cmd/pcmcia.c +4 -0
index 0bf2bd654f..044fb9e618 100644

Lines of this file are not shown. View the raw message.

cmd/reginfo.c +57 -2

59 lines not on this page · raw message

cmd/source.c +3 -0
index 177f86bb54..db7ab7e5f4 100644

Lines of this file are not shown. View the raw message.

common/board_f.c +3 -2
index 850d19db75..d5afc87839 100644

Lines of this file are not shown. View the raw message.

common/board_r.c +14 -0
index adc1f1937e..15977e4bca 100644

Lines of this file are not shown. View the raw message.

common/bootm_os.c +13 -1
index d9e6e937f7..e102406976 100644

Lines of this file are not shown. View the raw message.

common/lcd.c +4 -0
index 7e399cee2d..2405146cf0 100644

Lines of this file are not shown. View the raw message.

doc/README.MPC866 new file +24 -0
new file mode 100644
index 0000000000..4707cb7df7

Lines of this file are not shown. View the raw message.

doc/README.fsl-clk new file +5 -0
new file mode 100644
index 0000000000..08309e70f2

Lines of this file are not shown. View the raw message.

doc/README.scrapyard +1 -0
index 5e5b07d95e..e43e3c0fa9 100644

Lines of this file are not shown. View the raw message.

drivers/block/ide.c +11 -0
index 308ad7396b..ac5b91c01a 100644

Lines of this file are not shown. View the raw message.

drivers/block/sil680.c +1 -0
index bca3397d94..b1db257838 100644

Lines of this file are not shown. View the raw message.

drivers/bootcount/bootcount.c +5 -0
index 0299a5a839..8c1d10e26e 100644

Lines of this file are not shown. View the raw message.

drivers/i2c/i2c_core.c +11 -0
index 911563be0b..19769dab67 100644

Lines of this file are not shown. View the raw message.

drivers/i2c/soft_i2c.c +5 -0
index de3758d946..afdfbb621e 100644

Lines of this file are not shown. View the raw message.

drivers/pcmcia/Makefile +1 -0
index b7e6188429..f39c1892e4 100644

Lines of this file are not shown. View the raw message.

drivers/pcmcia/mpc8xx_pcmcia.c new file +258 -0

258 lines not on this page · raw message

drivers/rtc/Makefile +1 -0
index 003e31aeba..420767286f 100644

Lines of this file are not shown. View the raw message.

drivers/rtc/mpc8xx.c new file +60 -0

60 lines not on this page · raw message

drivers/serial/serial.c +0 -3
index f2bd0e404c..6c5aa5d077 100644

Lines of this file are not shown. View the raw message.

drivers/usb/gadget/Makefile +1 -0
index 5e316a7cff..0fbbb7c82c 100644

Lines of this file are not shown. View the raw message.

drivers/usb/gadget/mpc8xx_udc.c new file +1386 -0

1,386 lines not on this page · raw message

drivers/video/Makefile +1 -0
index ac5371f2ae..58f5de5200 100644

Lines of this file are not shown. View the raw message.

drivers/video/mpc8xx_lcd.c new file +400 -0

400 lines not on this page · raw message

examples/standalone/Makefile +2 -0
index c9d6206f29..f6dea20071 100644

Lines of this file are not shown. View the raw message.

examples/standalone/test_burst.c new file +284 -0

284 lines not on this page · raw message

examples/standalone/test_burst.h new file +22 -0
new file mode 100644
index 0000000000..87f5927a8e

Lines of this file are not shown. View the raw message.

examples/standalone/test_burst_lib.S new file +154 -0

154 lines not on this page · raw message

examples/standalone/timer.c new file +333 -0

333 lines not on this page · raw message

include/asm-generic/global_data.h +1 -1
index fb90be9d3e..76c7c43606 100644

Lines of this file are not shown. View the raw message.

include/asm-generic/u-boot.h +2 -1
index 95930ad20e..8df28ed0ed 100644

Lines of this file are not shown. View the raw message.

include/commproc.h new file +791 -0

791 lines not on this page · raw message

include/i2c.h +23 -1
index 695cb7655f..83ae0b3c71 100644

Lines of this file are not shown. View the raw message.

include/lcd.h +3 -1
index 797d0b0de1..f76fca77f9 100644

Lines of this file are not shown. View the raw message.

include/mpc823_lcd.h new file +44 -0

44 lines not on this page · raw message

include/net.h +4 -0
index 2eaa88224c..ed5259a807 100644

Lines of this file are not shown. View the raw message.

include/pcmcia.h +15 -1
index 94b54c210d..03f0bdc301 100644

Lines of this file are not shown. View the raw message.

include/post.h +6 -1
index b9b9c3775b..201d7e46b9 100644

Lines of this file are not shown. View the raw message.

include/ppc_asm.tmpl +46 -0

46 lines not on this page · raw message

include/usb/mpc8xx_udc.h new file +178 -0

178 lines not on this page · raw message

include/watchdog.h +5 -0
index 322dda79f0..c1e7b7aeb3 100644

Lines of this file are not shown. View the raw message.

post/Makefile +1 -0
index 09bf408f4c..78ede8c629 100644

Lines of this file are not shown. View the raw message.

post/cpu/mpc8xx/Makefile new file +9 -0
new file mode 100644
index 0000000000..f8bb6c9343

Lines of this file are not shown. View the raw message.

post/cpu/mpc8xx/cache.c new file +62 -0

62 lines not on this page · raw message

post/cpu/mpc8xx/cache_8xx.S new file +477 -0

477 lines not on this page · raw message

post/cpu/mpc8xx/ether.c new file +530 -0

530 lines not on this page · raw message

post/cpu/mpc8xx/spr.c new file +132 -0

132 lines not on this page · raw message

post/cpu/mpc8xx/uart.c new file +508 -0

508 lines not on this page · raw message

post/cpu/mpc8xx/usb.c new file +249 -0

249 lines not on this page · raw message

post/cpu/mpc8xx/watchdog.c new file +59 -0

59 lines not on this page · raw message

post/tests.c +12 -0
index bc8e398051..d8ac54e758 100644

Lines of this file are not shown. View the raw message.

scripts/config_whitelist.txt +57 -11

68 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.12.0

Part of the diff is not shown here. View the raw message.

#1 lore raw

PATCH v4 1/1 powerpc: Restore core of mpc8xx

Dear Christophe Leroy,

Quoted 142 lines · In message <[email protected]> you wrote:

---
v4: Restored some common CONFIG_ removed by 5xx removal in README and config_whitelist
Removed all impacts on 4xx; Removed a few remaining references to 82xx Fixed unbalanced #ifdef in i2c

v3: Fixed build error in arch/powerpc/include/asm/ppc.h ; removed commproc.h from 4xx

v2: Tom squashed patches 1-10 of the serie

 .travis.yml                            |    2 +
 MAINTAINERS                            |    7 +-
 README                                 |  118 ++-
 api/api_platform-powerpc.c             |    3 +-
 arch/powerpc/Kconfig                   |    4 +
 arch/powerpc/cpu/mpc8xx/Kconfig        |   13 +
 arch/powerpc/cpu/mpc8xx/Makefile       |   25 +
 arch/powerpc/cpu/mpc8xx/bedbug_860.c   |  314 ++++++++
 arch/powerpc/cpu/mpc8xx/config.mk      |    8 +
 arch/powerpc/cpu/mpc8xx/cpu.c          |  580 +++++++++++++
 arch/powerpc/cpu/mpc8xx/cpu_init.c     |  218 +++++
 arch/powerpc/cpu/mpc8xx/fdt.c          |   27 +
 arch/powerpc/cpu/mpc8xx/fec.c          |  933 +++++++++++++++++++++
 arch/powerpc/cpu/mpc8xx/fec.h          |   12 +
 arch/powerpc/cpu/mpc8xx/interrupts.c   |  278 +++++++
 arch/powerpc/cpu/mpc8xx/kgdb.S         |   54 ++
 arch/powerpc/cpu/mpc8xx/plprcr_write.S |  119 +++
 arch/powerpc/cpu/mpc8xx/scc.c          |  472 +++++++++++
 arch/powerpc/cpu/mpc8xx/serial.c       |  676 ++++++++++++++++
 arch/powerpc/cpu/mpc8xx/speed.c        |  385 +++++++++
 arch/powerpc/cpu/mpc8xx/spi.c          |  533 ++++++++++++
 arch/powerpc/cpu/mpc8xx/start.S        |  650 +++++++++++++++
 arch/powerpc/cpu/mpc8xx/traps.c        |  216 +++++
 arch/powerpc/cpu/mpc8xx/upatch.c       |  194 +++++
 arch/powerpc/cpu/mpc8xx/video.c        | 1123 ++++++++++++++++++++++++++
 arch/powerpc/include/asm/8xx_immap.h   |  515 ++++++++++++
 arch/powerpc/include/asm/cache.h       |   41 +-
 arch/powerpc/include/asm/global_data.h |    3 +
 arch/powerpc/include/asm/iopin_8xx.h   |  379 +++++++++
 arch/powerpc/include/asm/ppc.h         |   16 +
 arch/powerpc/include/asm/processor.h   |   17 +-
 arch/powerpc/include/asm/status_led.h  |   73 ++
 arch/powerpc/lib/Makefile              |    1 +
 arch/powerpc/lib/ide.c                 |  184 +++++
 arch/powerpc/lib/ide.h                 |   15 +
 arch/powerpc/lib/immap.c               |  564 +++++++++++++
 arch/powerpc/lib/time.c                |   11 +
 cmd/bdinfo.c                           |    3 +-
 cmd/bedbug.c                           |    4 +
 cmd/ide.c                              |    9 +-
 cmd/pcmcia.c                           |    4 +
 cmd/reginfo.c                          |   59 +-
 cmd/source.c                           |    3 +
 common/board_f.c                       |    5 +-
 common/board_r.c                       |   14 +
 common/bootm_os.c                      |   14 +-
 common/lcd.c                           |    4 +
 doc/README.MPC866                      |   24 +
 doc/README.fsl-clk                     |    5 +
 doc/README.scrapyard                   |    1 +
 drivers/block/ide.c                    |   11 +
 drivers/block/sil680.c                 |    1 +
 drivers/bootcount/bootcount.c          |    5 +
 drivers/i2c/i2c_core.c                 |   11 +
 drivers/i2c/soft_i2c.c                 |    5 +
 drivers/pcmcia/Makefile                |    1 +
 drivers/pcmcia/mpc8xx_pcmcia.c         |  258 ++++++
 drivers/rtc/Makefile                   |    1 +
 drivers/rtc/mpc8xx.c                   |   60 ++
 drivers/serial/serial.c                |    3 -
 drivers/usb/gadget/Makefile            |    1 +
 drivers/usb/gadget/mpc8xx_udc.c        | 1386 ++++++++++++++++++++++++++++++++
 drivers/video/Makefile                 |    1 +
 drivers/video/mpc8xx_lcd.c             |  400 +++++++++
 examples/standalone/Makefile           |    2 +
 examples/standalone/test_burst.c       |  284 +++++++
 examples/standalone/test_burst.h       |   22 +
 examples/standalone/test_burst_lib.S   |  154 ++++
 examples/standalone/timer.c            |  333 ++++++++
 include/asm-generic/global_data.h      |    2 +-
 include/asm-generic/u-boot.h           |    3 +-
 include/commproc.h                     |  791 ++++++++++++++++++
 include/i2c.h                          |   24 +-
 include/lcd.h                          |    4 +-
 include/mpc823_lcd.h                   |   44 +
 include/net.h                          |    4 +
 include/pcmcia.h                       |   16 +-
 include/post.h                         |    7 +-
 include/ppc_asm.tmpl                   |   46 ++
 include/usb/mpc8xx_udc.h               |  178 ++++
 include/watchdog.h                     |    5 +
 post/Makefile                          |    1 +
 post/cpu/mpc8xx/Makefile               |    9 +
 post/cpu/mpc8xx/cache.c                |   62 ++
 post/cpu/mpc8xx/cache_8xx.S            |  477 +++++++++++
 post/cpu/mpc8xx/ether.c                |  530 ++++++++++++
 post/cpu/mpc8xx/spr.c                  |  132 +++
 post/cpu/mpc8xx/uart.c                 |  508 ++++++++++++
 post/cpu/mpc8xx/usb.c                  |  249 ++++++
 post/cpu/mpc8xx/watchdog.c             |   59 ++
 post/tests.c                           |   12 +
 scripts/config_whitelist.txt           |   68 +-
 92 files changed, 15047 insertions(+), 55 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc8xx/Kconfig
 create mode 100644 arch/powerpc/cpu/mpc8xx/Makefile
 create mode 100644 arch/powerpc/cpu/mpc8xx/bedbug_860.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/config.mk
 create mode 100644 arch/powerpc/cpu/mpc8xx/cpu.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/cpu_init.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fdt.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fec.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fec.h
 create mode 100644 arch/powerpc/cpu/mpc8xx/interrupts.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/kgdb.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/plprcr_write.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/scc.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/serial.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/speed.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/spi.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/start.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/traps.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/upatch.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/video.c
 create mode 100644 arch/powerpc/include/asm/8xx_immap.h
 create mode 100644 arch/powerpc/include/asm/iopin_8xx.h
 create mode 100644 arch/powerpc/include/asm/status_led.h
 create mode 100644 arch/powerpc/lib/ide.c
 create mode 100644 arch/powerpc/lib/ide.h
 create mode 100644 arch/powerpc/lib/immap.c
 create mode 100644 doc/README.MPC866
 create mode 100644 doc/README.fsl-clk
 create mode 100644 drivers/pcmcia/mpc8xx_pcmcia.c
 create mode 100644 drivers/rtc/mpc8xx.c
 create mode 100644 drivers/usb/gadget/mpc8xx_udc.c
 create mode 100644 drivers/video/mpc8xx_lcd.c
 create mode 100644 examples/standalone/test_burst.c
 create mode 100644 examples/standalone/test_burst.h
 create mode 100644 examples/standalone/test_burst_lib.S
 create mode 100644 examples/standalone/timer.c
 create mode 100644 include/commproc.h
 create mode 100644 include/mpc823_lcd.h
 create mode 100644 include/usb/mpc8xx_udc.h
Quoted 8 lines
 create mode 100644 post/cpu/mpc8xx/Makefile
 create mode 100644 post/cpu/mpc8xx/cache.c
 create mode 100644 post/cpu/mpc8xx/cache_8xx.S
 create mode 100644 post/cpu/mpc8xx/ether.c
 create mode 100644 post/cpu/mpc8xx/spr.c
 create mode 100644 post/cpu/mpc8xx/uart.c
 create mode 100644 post/cpu/mpc8xx/usb.c
 create mode 100644 post/cpu/mpc8xx/watchdog.c

See previous discussion.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
            - R.  Pirsig, "Zen and the Art of Motorcycle Maintenance"
#2 lore raw

PATCH v4 1/1 powerpc: Restore core of mpc8xx

Quoted 154 lines · Wolfgang Denk

Dear Christophe Leroy,

Quoted 142 lines · In message <[email protected]> you wrote:

---
v4: Restored some common CONFIG_ removed by 5xx removal in README and config_whitelist
Removed all impacts on 4xx; Removed a few remaining references to 82xx Fixed unbalanced #ifdef in i2c

v3: Fixed build error in arch/powerpc/include/asm/ppc.h ; removed commproc.h from 4xx

v2: Tom squashed patches 1-10 of the serie

 .travis.yml                            |    2 +
 MAINTAINERS                            |    7 +-
 README                                 |  118 ++-
 api/api_platform-powerpc.c             |    3 +-
 arch/powerpc/Kconfig                   |    4 +
 arch/powerpc/cpu/mpc8xx/Kconfig        |   13 +
 arch/powerpc/cpu/mpc8xx/Makefile       |   25 +
 arch/powerpc/cpu/mpc8xx/bedbug_860.c   |  314 ++++++++
 arch/powerpc/cpu/mpc8xx/config.mk      |    8 +
 arch/powerpc/cpu/mpc8xx/cpu.c          |  580 +++++++++++++
 arch/powerpc/cpu/mpc8xx/cpu_init.c     |  218 +++++
 arch/powerpc/cpu/mpc8xx/fdt.c          |   27 +
 arch/powerpc/cpu/mpc8xx/fec.c          |  933 +++++++++++++++++++++
 arch/powerpc/cpu/mpc8xx/fec.h          |   12 +
 arch/powerpc/cpu/mpc8xx/interrupts.c   |  278 +++++++
 arch/powerpc/cpu/mpc8xx/kgdb.S         |   54 ++
 arch/powerpc/cpu/mpc8xx/plprcr_write.S |  119 +++
 arch/powerpc/cpu/mpc8xx/scc.c          |  472 +++++++++++
 arch/powerpc/cpu/mpc8xx/serial.c       |  676 ++++++++++++++++
 arch/powerpc/cpu/mpc8xx/speed.c        |  385 +++++++++
 arch/powerpc/cpu/mpc8xx/spi.c          |  533 ++++++++++++
 arch/powerpc/cpu/mpc8xx/start.S        |  650 +++++++++++++++
 arch/powerpc/cpu/mpc8xx/traps.c        |  216 +++++
 arch/powerpc/cpu/mpc8xx/upatch.c       |  194 +++++
 arch/powerpc/cpu/mpc8xx/video.c        | 1123 ++++++++++++++++++++++++++
 arch/powerpc/include/asm/8xx_immap.h   |  515 ++++++++++++
 arch/powerpc/include/asm/cache.h       |   41 +-
 arch/powerpc/include/asm/global_data.h |    3 +
 arch/powerpc/include/asm/iopin_8xx.h   |  379 +++++++++
 arch/powerpc/include/asm/ppc.h         |   16 +
 arch/powerpc/include/asm/processor.h   |   17 +-
 arch/powerpc/include/asm/status_led.h  |   73 ++
 arch/powerpc/lib/Makefile              |    1 +
 arch/powerpc/lib/ide.c                 |  184 +++++
 arch/powerpc/lib/ide.h                 |   15 +
 arch/powerpc/lib/immap.c               |  564 +++++++++++++
 arch/powerpc/lib/time.c                |   11 +
 cmd/bdinfo.c                           |    3 +-
 cmd/bedbug.c                           |    4 +
 cmd/ide.c                              |    9 +-
 cmd/pcmcia.c                           |    4 +
 cmd/reginfo.c                          |   59 +-
 cmd/source.c                           |    3 +
 common/board_f.c                       |    5 +-
 common/board_r.c                       |   14 +
 common/bootm_os.c                      |   14 +-
 common/lcd.c                           |    4 +
 doc/README.MPC866                      |   24 +
 doc/README.fsl-clk                     |    5 +
 doc/README.scrapyard                   |    1 +
 drivers/block/ide.c                    |   11 +
 drivers/block/sil680.c                 |    1 +
 drivers/bootcount/bootcount.c          |    5 +
 drivers/i2c/i2c_core.c                 |   11 +
 drivers/i2c/soft_i2c.c                 |    5 +
 drivers/pcmcia/Makefile                |    1 +
 drivers/pcmcia/mpc8xx_pcmcia.c         |  258 ++++++
 drivers/rtc/Makefile                   |    1 +
 drivers/rtc/mpc8xx.c                   |   60 ++
 drivers/serial/serial.c                |    3 -
 drivers/usb/gadget/Makefile            |    1 +
 drivers/usb/gadget/mpc8xx_udc.c        | 1386 ++++++++++++++++++++++++++++++++
 drivers/video/Makefile                 |    1 +
 drivers/video/mpc8xx_lcd.c             |  400 +++++++++
 examples/standalone/Makefile           |    2 +
 examples/standalone/test_burst.c       |  284 +++++++
 examples/standalone/test_burst.h       |   22 +
 examples/standalone/test_burst_lib.S   |  154 ++++
 examples/standalone/timer.c            |  333 ++++++++
 include/asm-generic/global_data.h      |    2 +-
 include/asm-generic/u-boot.h           |    3 +-
 include/commproc.h                     |  791 ++++++++++++++++++
 include/i2c.h                          |   24 +-
 include/lcd.h                          |    4 +-
 include/mpc823_lcd.h                   |   44 +
 include/net.h                          |    4 +
 include/pcmcia.h                       |   16 +-
 include/post.h                         |    7 +-
 include/ppc_asm.tmpl                   |   46 ++
 include/usb/mpc8xx_udc.h               |  178 ++++
 include/watchdog.h                     |    5 +
 post/Makefile                          |    1 +
 post/cpu/mpc8xx/Makefile               |    9 +
 post/cpu/mpc8xx/cache.c                |   62 ++
 post/cpu/mpc8xx/cache_8xx.S            |  477 +++++++++++
 post/cpu/mpc8xx/ether.c                |  530 ++++++++++++
 post/cpu/mpc8xx/spr.c                  |  132 +++
 post/cpu/mpc8xx/uart.c                 |  508 ++++++++++++
 post/cpu/mpc8xx/usb.c                  |  249 ++++++
 post/cpu/mpc8xx/watchdog.c             |   59 ++
 post/tests.c                           |   12 +
 scripts/config_whitelist.txt           |   68 +-
 92 files changed, 15047 insertions(+), 55 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc8xx/Kconfig
 create mode 100644 arch/powerpc/cpu/mpc8xx/Makefile
 create mode 100644 arch/powerpc/cpu/mpc8xx/bedbug_860.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/config.mk
 create mode 100644 arch/powerpc/cpu/mpc8xx/cpu.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/cpu_init.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fdt.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fec.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/fec.h
 create mode 100644 arch/powerpc/cpu/mpc8xx/interrupts.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/kgdb.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/plprcr_write.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/scc.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/serial.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/speed.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/spi.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/start.S
 create mode 100644 arch/powerpc/cpu/mpc8xx/traps.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/upatch.c
 create mode 100644 arch/powerpc/cpu/mpc8xx/video.c
 create mode 100644 arch/powerpc/include/asm/8xx_immap.h
 create mode 100644 arch/powerpc/include/asm/iopin_8xx.h
 create mode 100644 arch/powerpc/include/asm/status_led.h
 create mode 100644 arch/powerpc/lib/ide.c
 create mode 100644 arch/powerpc/lib/ide.h
 create mode 100644 arch/powerpc/lib/immap.c
 create mode 100644 doc/README.MPC866
 create mode 100644 doc/README.fsl-clk
 create mode 100644 drivers/pcmcia/mpc8xx_pcmcia.c
 create mode 100644 drivers/rtc/mpc8xx.c
 create mode 100644 drivers/usb/gadget/mpc8xx_udc.c
 create mode 100644 drivers/video/mpc8xx_lcd.c
 create mode 100644 examples/standalone/test_burst.c
 create mode 100644 examples/standalone/test_burst.h
 create mode 100644 examples/standalone/test_burst_lib.S
 create mode 100644 examples/standalone/timer.c
 create mode 100644 include/commproc.h
 create mode 100644 include/mpc823_lcd.h
 create mode 100644 include/usb/mpc8xx_udc.h
Quoted 8 lines
 create mode 100644 post/cpu/mpc8xx/Makefile
 create mode 100644 post/cpu/mpc8xx/cache.c
 create mode 100644 post/cpu/mpc8xx/cache_8xx.S
 create mode 100644 post/cpu/mpc8xx/ether.c
 create mode 100644 post/cpu/mpc8xx/spr.c
 create mode 100644 post/cpu/mpc8xx/uart.c
 create mode 100644 post/cpu/mpc8xx/usb.c
 create mode 100644 post/cpu/mpc8xx/watchdog.c
Quoted 1 line

See previous discussion.

Since he addressed a number of the comments from the previous discussions, it would be helpful to point out the things that were overlooked, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170623/110ababa/attachment.sig>
#3 lore raw

PATCH v4 1/1 powerpc: Restore core of mpc8xx

Dear Tom,

Quoted 4 lines · In message <20170623140934.GD27196@bill-the-cat> you wrote:

Since he addressed a number of the comments from the previous discussions, it would be helpful to point out the things that were overlooked, thanks!

I thought this should be clear from the previous discussion. The major concern is that this patch brings back a large amount of ccode that will obviously remain unfixed, untested and unmaintained. Just to list a few examples:

arch/powerpc/cpu/mpc8xx/bedbug_860.c arch/powerpc/cpu/mpc8xx/kgdb.S arch/powerpc/cpu/mpc8xx/video.c drivers/block/sil680.c drivers/pcmcia/mpc8xx_pcmcia.c drivers/usb/gadget/mpc8xx_udc.c examples/standalone/test_burst.* examples/standalone/timer.c post/cpu/mpc8xx/usb.c (probably even post/cpu/mpc8xx/*)

etc.

Also, directory hierarchy should be fixed for a number of drivers.

It is IMO wrong to plan for a remove - revert - remove sequence.

This may be the way how Christophe actually starts developing his patches. As he mentioned, it might be useful for history reasons. But as I also explained before, going this route is a guarantee to keep a ton of unused, untested and unmaintained code which will not be removed as Christophe does not understand what it might be needed for. Please don't misunderstand me: I don't mean to suggest that I doubt on Christophe's qualification for this job - I mean nobody would be able to do this without being able to test the code on all the plethora of different boards that once needed such quirks.

Starting with all the old code and trying to remove unused stuff is _guaranteed_ to fail. We have to go the other way: start with minimal code and add only what is really needed - especially as this is a dead, obsolete processor architecture, and chances that any new boards be added is epsilon.

It is in Christophe's own interest to restrict the code to those parts that his boards really need. I admit that I am responsible for large parts of that code, and I well remeber the #ifdef mess that was added way back thento deal with all the subtleties of the many boards we had to support. Trust me, I know what I'm speaking about.

To make this clear: I am in no way against continuing to support mpc8xx. But we should not let him run into an unmaintainable mess of code.

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember thee Ay, thou poor ghost while memory holds a seat  In  this
distracted  globe.  Remember  thee!  Yea, from the table of my memory
I'll wipe away all trivial fond  records,  All  saws  of  books,  all
forms,  all  pressures past, That youth and observation copied there.
Hamlet, I : v : 95 William Shakespeare
#4 lore raw

PATCH v4 1/1 powerpc: Restore core of mpc8xx

Quoted 13 lines · Wolfgang Denk

Dear Tom,

Quoted 4 lines · In message <20170623140934.GD27196@bill-the-cat> you wrote:

Since he addressed a number of the comments from the previous discussions, it would be helpful to point out the things that were overlooked, thanks!

I thought this should be clear from the previous discussion. The major concern is that this patch brings back a large amount of ccode that will obviously remain unfixed, untested and unmaintained. Just to list a few examples:

Quoted 9 lines

arch/powerpc/cpu/mpc8xx/bedbug_860.c arch/powerpc/cpu/mpc8xx/kgdb.S arch/powerpc/cpu/mpc8xx/video.c drivers/block/sil680.c drivers/pcmcia/mpc8xx_pcmcia.c drivers/usb/gadget/mpc8xx_udc.c examples/standalone/test_burst.* examples/standalone/timer.c post/cpu/mpc8xx/usb.c (probably even post/cpu/mpc8xx/*)

OK, cool. Now we have concrete reminders and we also have some platforms coming in that will be making use of mpc8xx.

Quoted 27 lines

Also, directory hierarchy should be fixed for a number of drivers.

It is IMO wrong to plan for a remove - revert - remove sequence.

This may be the way how Christophe actually starts developing his patches. As he mentioned, it might be useful for history reasons. But as I also explained before, going this route is a guarantee to keep a ton of unused, untested and unmaintained code which will not be removed as Christophe does not understand what it might be needed for. Please don't misunderstand me: I don't mean to suggest that I doubt on Christophe's qualification for this job - I mean nobody would be able to do this without being able to test the code on all the plethora of different boards that once needed such quirks.

Starting with all the old code and trying to remove unused stuff is _guaranteed_ to fail. We have to go the other way: start with minimal code and add only what is really needed - especially as this is a dead, obsolete processor architecture, and chances that any new boards be added is epsilon.

It is in Christophe's own interest to restrict the code to those parts that his boards really need. I admit that I am responsible for large parts of that code, and I well remeber the #ifdef mess that was added way back thento deal with all the subtleties of the many boards we had to support. Trust me, I know what I'm speaking about.

Quoted 3 lines

To make this clear: I am in no way against continuing to support mpc8xx. But we should not let him run into an unmaintainable mess of code.

So, Christophe, please iterate on the mpc8xx patches so that you're bringing back just the parts of the code that you need. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170623/0efa93b3/attachment.sig>
#5 lore raw

PATCH v4 1/1 powerpc: Restore core of mpc8xx

Hello All,

Am 23.06.2017 um 21:54 schrieb Tom Rini:

Quoted 4 lines · Wolfgang Denk
Quoted 3 lines

Dear Tom,

In message <20170623140934.GD27196@bill-the-cat> you wrote:

[...]

Quoted 6 lines
Quoted 3 lines

To make this clear: I am in no way against continuing to support mpc8xx. But we should not let him run into an unmaintainable mess of code.

So, Christophe, please iterate on the mpc8xx patches so that you're bringing back just the parts of the code that you need. Thanks!

Yes, full ack. Thanks!

To make it clear, I am also happy to see *maintained* 8xx code in U-Boot ... and may I inventioned here a bit to nitpicking, sorry for that!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany