Skip to contentSkip to conversation

spl: Make UBI fastmap support Kconfig selectable

PATCH In review Ladislav Michl 3 participants 3 messages Jun 25, 2017 – Jul 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spl: Make UBI fastmap support Kconfig selectable

Fastmap was always enabled in ubispl, make it selectable by CONFIG_MTD_UBI_FASTMAP.

---
 common/spl/spl_ubi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_ubi.c +1 -1
index 24633f4766..83089335a7 100644
@@ -38,7 +38,7 @@ int spl_ubi_load_image(struct spl_image_info *spl_image,
 		goto out;
 	}
 	info.ubi = (struct ubi_scan_info *)CONFIG_SPL_UBI_INFO_ADDR;
-	info.fastmap = 1;
+	info.fastmap = IS_ENABLED(CONFIG_MTD_UBI_FASTMAP);
 
 	info.peb_offset = CONFIG_SPL_UBI_PEB_OFFSET;
 	info.vid_offset = CONFIG_SPL_UBI_VID_OFFSET;
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 spl: Make UBI fastmap support Kconfig selectable

Hello Ladislav,

Am 25.06.2017 um 10:26 schrieb Ladislav Michl:

Quoted 13 lines

Fastmap was always enabled in ubispl, make it selectable by CONFIG_MTD_UBI_FASTMAP.

---
  common/spl/spl_ubi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_ubi.c +0 -0
index 24633f4766..83089335a7 100644

common/spl/spl_ubi.c int spl_ubi_load_image(struct spl_image_info *spl_image, · line 41

Quoted 5 lines
common/spl/spl_ubi.c +1 -1
@@ -38,7 +38,7 @@ int spl_ubi_load_image(struct spl_image_info *spl_image,
  		goto out;
  	}
  	info.ubi = (struct ubi_scan_info *)CONFIG_SPL_UBI_INFO_ADDR;
-	info.fastmap = 1;
+	info.fastmap = IS_ENABLED(CONFIG_MTD_UBI_FASTMAP);

Thanks!

(I Ack here the patch, as I think this patch belongs to the following
board patches, so this patch should go in with the board patches)

bye,
Heiko

Quoted 4 lines
common/spl/spl_ubi.c +0 -0
  	info.peb_offset = CONFIG_SPL_UBI_PEB_OFFSET;
  	info.vid_offset = CONFIG_SPL_UBI_VID_OFFSET;
 
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw
In reply to Ladislav Michl
Quoted 5 lines · Ladislav Michl

Fastmap was always enabled in ubispl, make it selectable by CONFIG_MTD_UBI_FASTMAP.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170707/6fdb26fb/attachment.sig>