Skip to contentSkip to conversation

km/common: remove unused code

PATCH In review Holger Brunck 3 participants 3 messages Jun 30, 2017 – Jul 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 km/common: remove unused code

The 82xx board mgcoge3ne was removed from the codebase, so this is dead code.

---
 board/keymile/common/common.c | 3 ---
 1 file changed, 3 deletions(-)
board/keymile/common/common.c +0 -3
index 0829b7fa06..408079c9a1 100644
@@ -355,9 +355,6 @@ static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
 #if defined(CONFIG_POST)
 	testpin = post_hotkeys_pressed();
 #endif
-#if defined(CONFIG_MGCOGE3NE)
-	testpin = get_testpin();
-#endif
 	s = getenv("test_bank");
 	/* when test_bank is not set, act as if testpin is not asserted */
 	testboot = (testpin != 0) && (s);
Signature · 1 line
2.12.0.rc1
#1 lore raw

PATCH 1/1 km/common: remove unused code

Hello Holger,

Am 30.06.2017 um 15:33 schrieb Holger Brunck:

Quoted 8 lines

The 82xx board mgcoge3ne was removed from the codebase, so this is dead code.

---
  board/keymile/common/common.c | 3 ---
  1 file changed, 3 deletions(-)

nice catch! Thanks!

bye,
Heiko

Quoted 16 lines
board/keymile/common/common.c +0 -3
index 0829b7fa06..408079c9a1 100644
@@ -355,9 +355,6 @@ static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
  #if defined(CONFIG_POST)
  	testpin = post_hotkeys_pressed();
  #endif
-#if defined(CONFIG_MGCOGE3NE)
-	testpin = get_testpin();
-#endif
  	s = getenv("test_bank");
  	/* when test_bank is not set, act as if testpin is not asserted */
  	testboot = (testpin != 0) && (s);
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw
In reply to Holger Brunck
Quoted 6 lines · Holger Brunck

The 82xx board mgcoge3ne was removed from the codebase, so this is dead code.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170707/103baa90/attachment.sig>