Skip to contentSkip to conversation

dmaengine: tegra210-adma: use platform to ioremap

PATCH In review Rosen Penev 2 participants 2 messages Jan 19 – Feb 2

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dmaengine: tegra210-adma: use platform to ioremap

Simplify the code slightly with devm_platform_ioremap_resource.

---
v2: reword commit message

 drivers/dma/tegra210-adma.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/dma/tegra210-adma.c +3 -8
index 215bfef37ec6..5353fbb3d995 100644
@@ -1073,14 +1073,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
 		}
 	} else {
 		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);
-		} else {
-			return -ENODEV;
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);
 
 		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
 	}

--
2.52.0

Reviewed-by on v2 1/1
#1 lore raw
Quoted 31 lines · Rosen Penev

Simplify the code slightly with devm_platform_ioremap_resource.

---
v2: reword commit message

 drivers/dma/tegra210-adma.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/dma/tegra210-adma.c +3 -9
index 215bfef37ec6..5353fbb3d995 100644
@@ -1073,14 +1073,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
 		}
 	} else {
 		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);
-		} else {
-			return -ENODEV;
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);
 
 		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
 	}
--
Quoted 3 lines

2.52.0

The commit subject "use platform to remap" doesn't make much sense. I'd just say e.g. "use devm_platform_ioremap_resource".

With that,