Skip to contentSkip to conversation

devfreq: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 3 participants 7 messages Jul 18, 2017 – Aug 25, 2017

Subsystems (2)
Device frequency (devfreq) Device frequency event (devfreq-event)
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 devfreq: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]
---
 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +2 -2
index 8648b32ebc89..d67242d87744 100644
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
 						sizeof(u32));
 	if (count < 0) {
 		dev_err(dev,
-			"failed to get the count of devfreq-event in %s node\n",
-			dev->of_node->full_name);
+			"failed to get the count of devfreq-event in %pOF node\n",
+			dev->of_node);
 		return count;
 	}

--
2.11.0

maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 18 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]
---
 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +0 -0
index 8648b32ebc89..d67242d87744 100644

drivers/devfreq/devfreq-event.c int devfreq_event_get_edev_count(struct device *dev) · line 284

Quoted 10 lines
drivers/devfreq/devfreq-event.c +2 -2
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
 						sizeof(u32));
 	if (count < 0) {
 		dev_err(dev,
-			"failed to get the count of devfreq-event in %s node\n",
-			dev->of_node->full_name);
+			"failed to get the count of devfreq-event in %pOF node\n",
+			dev->of_node);
 		return count;
 	}
Reviewed-by Chanwoo Choi <[email protected]>
Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics
maintainer Acked-by
#2 lore raw
Quoted 54 lines · Rob Herring
Quoted 52 lines

Now that we have a custom printf format specifier, convert users of

full_name to use %pOF instead. This is preparation to remove storing

of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]

---

 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +0 -0

index 8648b32ebc89..d67242d87744 100644

--- a/drivers/devfreq/devfreq-event.c

+++ b/drivers/devfreq/devfreq-event.c

drivers/devfreq/devfreq-event.c +2 -2
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
 
 						sizeof(u32));
 
 	if (count < 0) {
 
 		dev_err(dev,
 
-			"failed to get the count of devfreq-event in %s node\n",
 
-			dev->of_node->full_name);
 
+			"failed to get the count of devfreq-event in %pOF node\n",
 
+			dev->of_node);
 
 		return count;
Quoted 9 lines
Quoted 3 lines

}

Reviewed-by Chanwoo Choi <[email protected]>
Acked-by MyungJoo Ham <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#3 lore raw
Quoted 33 lines · MyungJoo Ham
Quoted 23 lines · Rob Herring
Quoted 22 lines

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]
---
 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +0 -1
index 8648b32ebc89..d67242d87744 100644
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
                                            sizeof(u32));
    if (count < 0) {
            dev_err(dev,
-                   "failed to get the count of devfreq-event in %s node\n",
Quoted 9 lines

drivers/devfreq/devfreq-event.c int devfreq_event_get_edev_count(struct device *dev) · line 284

Quoted 6 lines
drivers/devfreq/devfreq-event.c +2 -1
-                   dev->of_node->full_name);
+                   "failed to get the count of devfreq-event in %pOF node\n",
+                   dev->of_node);
            return count;
    }
Reviewed-by Chanwoo Choi <[email protected]>
Quoted 1 line
Acked-by MyungJoo Ham <[email protected]>

Please take this thru the devfreq tree.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#4 lore raw

Hi Rob,

Quoted 34 lines · Rob Herring
Quoted 33 lines · MyungJoo Ham
Quoted 32 lines · Rob Herring
Quoted 18 lines

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]
---
 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +0 -0
index 8648b32ebc89..d67242d87744 100644

drivers/devfreq/devfreq-event.c int devfreq_event_get_edev_count(struct device *dev) · line 284

Quoted 10 lines
drivers/devfreq/devfreq-event.c +2 -2
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
                                            sizeof(u32));
    if (count < 0) {
            dev_err(dev,
-                   "failed to get the count of devfreq-event in %s node\n",
-                   dev->of_node->full_name);
+                   "failed to get the count of devfreq-event in %pOF node\n",
+                   dev->of_node);
            return count;
    }
Reviewed-by Chanwoo Choi <[email protected]>
Quoted 3 lines
Quoted 1 line
Acked-by MyungJoo Ham <[email protected]>

Please take this thru the devfreq tree.

This patch was merged on devfreq tree.
https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/commit/?h=for-next&id=7f46535e8a2e3c3e415e55eaadcb9d9a153a5300

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics
author
#5 lore raw
Quoted 37 lines · Chanwoo Choi

Hi Rob,

Quoted 34 lines · Rob Herring
Quoted 33 lines · MyungJoo Ham
Quoted 32 lines · Rob Herring
Quoted 18 lines

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]
---
 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +0 -0
index 8648b32ebc89..d67242d87744 100644

drivers/devfreq/devfreq-event.c int devfreq_event_get_edev_count(struct device *dev) · line 284

Quoted 10 lines
drivers/devfreq/devfreq-event.c +2 -2
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
                                            sizeof(u32));
    if (count < 0) {
            dev_err(dev,
-                   "failed to get the count of devfreq-event in %s node\n",
-                   dev->of_node->full_name);
+                   "failed to get the count of devfreq-event in %pOF node\n",
+                   dev->of_node);
            return count;
    }
Reviewed-by Chanwoo Choi <[email protected]>
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Acked-by MyungJoo Ham <[email protected]>

Please take this thru the devfreq tree.

This patch was merged on devfreq tree.
https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/commit/?h=for-next&id=7f46535e8a2e3c3e415e55eaadcb9d9a153a5300

Okay, it's not showing up in linux-next which is why I asked.

Rob

maintainer
#6 lore raw
Quoted 38 lines · Rob Herring
Quoted 37 lines · Chanwoo Choi

Hi Rob,

Quoted 34 lines · Rob Herring
Quoted 33 lines · MyungJoo Ham
Quoted 32 lines · Rob Herring
Quoted 18 lines

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Chanwoo Choi <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Kyungmin Park <[email protected]>
Cc [email protected]
---
 drivers/devfreq/devfreq-event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/devfreq-event.c +0 -0
index 8648b32ebc89..d67242d87744 100644

drivers/devfreq/devfreq-event.c int devfreq_event_get_edev_count(struct device *dev) · line 284

Quoted 10 lines
drivers/devfreq/devfreq-event.c +2 -2
@@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev)
                                            sizeof(u32));
    if (count < 0) {
            dev_err(dev,
-                   "failed to get the count of devfreq-event in %s node\n",
-                   dev->of_node->full_name);
+                   "failed to get the count of devfreq-event in %pOF node\n",
+                   dev->of_node);
            return count;
    }
Reviewed-by Chanwoo Choi <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Acked-by MyungJoo Ham <[email protected]>

Please take this thru the devfreq tree.

This patch was merged on devfreq tree.
https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/commit/?h=for-next&id=7f46535e8a2e3c3e415e55eaadcb9d9a153a5300

Okay, it's not showing up in linux-next which is why I asked.

As I knew, devfreq maintainer has not yet asked
the inclusion of devfreq tree in linux-next.

To Myungjoo,
You can ask to 'Stephen Rothwell <[email protected]>' for the inclusion of devfreq tree in linux-next.

git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git for-next

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics