reply: reply: [RFC PATCH v3 00/19] scsi: scsi_error: Introduce new error handle mechanism
Quoted 1 line · Jiangjianjun
Sorry for late message! I'm working on fixing and testing these issues before re-emailing.
What are you actually working on?
It seems that Hannes' "scsi: EH rework, main part" series and maybe this one can help resolve this following issue:
https://lore.kernel.org/linux-block/[email protected]/
with fix attempted in:
https://lore.kernel.org/linux-ide/[email protected]/
so that we don't see "fixes" like:
https://lore.kernel.org/linux-scsi/[email protected]/T/#m80bcb3f57fd176b7ce41b1f26e8560de6ad52c9d
Quoted 23 lines
-----邮件原件-----
发件人: Christoph Hellwig <[email protected]>
发送时间: 2025年3月20日 14:06
收件人: Hannes Reinecke <[email protected]>
抄送: Jiangjianjun <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; lixiaokeng <[email protected]>; hewenliang (C) <[email protected]>; Yangkunlin(Poincare) <[email protected]>
主题: Re: [RFC PATCH v3 00/19] scsi:scsi_error: Introduce new error handle mechanismQuoted 8 lines · Hannes Reinecke
3. The current EH framework is designed around 'struct
scsi_cmnd'. Which means that the command _initiating_ the error handling can only be returned once the _entire_ error handling (with all escalations) is finished. And more often than not, the application is waiting on that command to be completed before the next I/O is sent. And that really limits the effectiveness of any improved error handler; the application ultimatively has to wait for a host reset before it can contine.
Quoted 2 lines
And someone needs to get your old series to fix that merged before we even start talking about any major EH change.
Sorry, the previous engineer Wen Chao's work has changed. Now I will continue to complete this work. In the future. I will analyze the details of the solution, improve and refine the above suggestions, and carefully submit the email.
On 01/04/2025 04:32, Jiangjianjun wrote:
Please use standard mailing practice of inlining response.
Quoted 36 lines · Jiangjianjun
Quoted 1 line
Sorry for late message! I'm working on fixing and testing these issues before re-emailing.
What are you actually working on?
It seems that Hannes' "scsi: EH rework, main part" series and maybe this one can help resolve this following issue:
https://urldefense.com/v3/__https://lore.kernel.org/linux-block/ [email protected]/__;!!ACWV5N9M2RV99hQ! OO5I73jOVLARfumNZnn0L_cNWCWVmFHmNuzz74pUu12bSxsb7F1wQFuTJBCzEBZrdDE8cqBRf8e_Ddc4AmrbBgdRq9I$
with fix attempted in:
https://urldefense.com/v3/__https://lore.kernel.org/linux- ide/[email protected]/__;!!ACWV5N9M2RV99hQ! OO5I73jOVLARfumNZnn0L_cNWCWVmFHmNuzz74pUu12bSxsb7F1wQFuTJBCzEBZrdDE8cqBRf8e_Ddc4AmrbVJtRc_g$
so that we don't see "fixes" like:
https://urldefense.com/v3/__https://lore.kernel.org/linux- scsi/[email protected]/T/ *m80bcb3f57fd176b7ce41b1f26e8560de6ad52c9d__;Iw!!ACWV5N9M2RV99hQ! OO5I73jOVLARfumNZnn0L_cNWCWVmFHmNuzz74pUu12bSxsb7F1wQFuTJBCzEBZrdDE8cqBRf8e_Ddc4AmrbNUtxBIA$Quoted 21 lines
-----邮件原件-----
发件人: Christoph Hellwig<[email protected]>
发送时间: 2025年3月20日 14:06
收件人: Hannes Reinecke<[email protected]>
抄送: Jiangjianjun<[email protected]>;[email protected]; [email protected];[email protected]; [email protected]; lixiaokeng<[email protected]>; hewenliang (C)<[email protected]>; Yangkunlin(Poincare) <[email protected]>
主题: Re: [RFC PATCH v3 00/19] scsi:scsi_error: Introduce new error handle mechanismQuoted 8 lines · Hannes Reinecke
3. The current EH framework is designed around 'struct
scsi_cmnd'. Which means that thecommand_initiating_the error handling can only be returned oncethe_entire_error handling (with all escalations) is finished. And more often than not, the application is waiting on that command to be completed before the next I/O is sent. And that really limits the effectiveness of any improved error handler; the application ultimatively has to wait for a host reset before it can contine.
Quoted 4 lines
Quoted 2 lines
And someone needs to get your old series to fix that merged before we even start talking about any major EH change.
Sorry, the previous engineer Wen Chao's work has changed. Now I will continue to complete this work. In the future. I will analyze the details of the solution, improve and refine the above suggestions, and carefully submit the email.
JFYI, IIRC, that "scsi: EH rework, main part" or one of the prep series may require some form of SCSI reserved command support. Niklas raised that point here:
https://lore.kernel.org/linux-scsi/Zyo-E1PCvx_XULvg@ryzen/
I also remember commenting on this, but cannot find a reference.
The SCSI reserved commands series includes the following attempts:
https://lore.kernel.org/linux-scsi/[email protected]/
https://lore.kernel.org/linux-scsi/[email protected]/
Maybe to move format we can implement a basic solution for the concerned drivers, so that progress can be made.