Skip to contentSkip to conversation

phy: rockchip: fix Kconfig dependency more

PATCH Applied Arnd Bergmann 4 participants 4 messages Jan 22, 2025 – Jan 31, 2025

Subsystems (2)
Arm Rockchip Generic PHY framework
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 phy: rockchip: fix Kconfig dependency more

From: Arnd Bergmann <[email protected]>

A previous patch ensured that USB Type C connector support is enabled, but it is still possible to build the phy driver without enabling CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and in that case the common helper functions are unavailable:

aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe':
phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed'

Select CONFIG_USB_COMMON directly here, like we do in some other phy drivers, to make sure this is available even when actual USB support is disabled or in a loadable module that cannot be reached from a built-in phy driver.

Fixes 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/rockchip/Kconfig +1 -0
index 2f7a05f21dc5..dcb8e1628632 100644
@@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP
 	depends on ARCH_ROCKCHIP && OF
 	depends on TYPEC
 	select GENERIC_PHY
+	select USB_COMMON
 	help
 	  Enable this to support the Rockchip USB3.0/DP combo PHY with
 	  Samsung IP block. This is required for USB3 support on RK3588.
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A previous patch ensured that USB Type C connector support is enabled, but it is still possible to build the phy driver without enabling CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and in that case the common helper functions are unavailable:

aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe':
phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed'

Quoted 8 lines

Select CONFIG_USB_COMMON directly here, like we do in some other phy drivers, to make sure this is available even when actual USB support is disabled or in a loadable module that cannot be reached from a built-in phy driver.

Fixes 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency")
Signed-off-by Arnd Bergmann <[email protected]>

---

Reviewed-by Sebastian Reichel <[email protected]>

Thanks,

-- Sebastian

Quoted 19 lines
 drivers/phy/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/rockchip/Kconfig +1 -0
index 2f7a05f21dc5..dcb8e1628632 100644
@@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP
 	depends on ARCH_ROCKCHIP && OF
 	depends on TYPEC
 	select GENERIC_PHY
+	select USB_COMMON
 	help
 	  Enable this to support the Rockchip USB3.0/DP combo PHY with
 	  Samsung IP block. This is required for USB3 support on RK3588.
Signature · 1 line
2.39.5
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann

Am Mittwoch, 22. Januar 2025, 07:52:44 MEZ schrieb Arnd Bergmann:

Quoted 10 lines

From: Arnd Bergmann <[email protected]>

A previous patch ensured that USB Type C connector support is enabled, but it is still possible to build the phy driver without enabling CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and in that case the common helper functions are unavailable:

aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe':
phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed'

Quoted 7 lines

Select CONFIG_USB_COMMON directly here, like we do in some other phy drivers, to make sure this is available even when actual USB support is disabled or in a loadable module that cannot be reached from a built-in phy driver.

Fixes 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency")
Signed-off-by Arnd Bergmann <[email protected]>
Reviewed-by Heiko Stuebner <[email protected]>

@Vinod, I guess this should go into 6.14-rc?

Thanks
Heiko

Quoted 17 lines
---
 drivers/phy/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/rockchip/Kconfig +1 -0
index 2f7a05f21dc5..dcb8e1628632 100644
@@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP
 	depends on ARCH_ROCKCHIP && OF
 	depends on TYPEC
 	select GENERIC_PHY
+	select USB_COMMON
 	help
 	  Enable this to support the Rockchip USB3.0/DP combo PHY with
 	  Samsung IP block. This is required for USB3 support on RK3588.
maintainer Applied
#3 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

A previous patch ensured that USB Type C connector support is enabled, but it is still possible to build the phy driver without enabling CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and in that case the common helper functions are unavailable:

aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe':
phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed'

[...]

Applied, thanks!

[1/1] phy: rockchip: fix Kconfig dependency more

      commit: ca996321d32a732ee12e7af8ccd0c84bf885fd6f

Best regards,

Signature · 1 line
~Vinod