Enable the read ECC before program the page
Subsystems (3)
PATCH 1/1 Enable the read ECC before program the page
Current program_page function did following operation:
1. read page (with ECC OFF)
2. modify the page
3. write the page (with ECC ON)
For some case(buggy flash Chip), while read the page without ECC ON, we may read the page with bit flip error and modify that bad page without knowing the bit flip error on that page.
also we re-calculate the hash for bad page and write it.
This could bring potential in-consistency problem with Flash data.
Verify this logic with GIGA DEVICE Part(GD5F2GQ4RCFIG):
we see this in-conststency problem wit Giga Device and fix on this patch resovle that issue.
--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/staging/mt29f_spinand/mt29f_spinand.c +7 -2
@@ -496,8 +496,13 @@ static int spinand_program_page(struct spi_device *spi_nand,if (!wbuf)return -ENOMEM ; - enable_read_hw_ecc =0 ; -spinand_read_page (spi_nand, page_id,0 ,CACHE_BUF , wbuf); + enable_read_hw_ecc =1 ; + retval =spinand_read_page (spi_nand, page_id,0 ,CACHE_BUF , wbuf); +if ( retval <0 ) + { +dev_err (&spi_nand->dev,"ecc error on read page!!!\n" ); +return retval; + }for (i = offset, j =0 ; i < len; i++, j++) wbuf[i] &= buf[j];
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 26 lines · Arun Nagendran
Current
program_pagefunction did following operation:1. read page (with ECC OFF)
2. modify the page
3. write the page (with ECC ON)For some case(buggy flash Chip), while read the page without ECC ON, we may read the page with bit flip error and modify that bad page without knowing the bit flip error on that page.
also we re-calculate the hash for bad page and write it.
This could bring potential in-consistency problem with Flash data.Verify this logic with GIGA DEVICE Part(GD5F2GQ4RCFIG):
we see this in-conststency problem wit Giga Device and fix on this patch resovle that issue.--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/staging/mt29f_spinand/mt29f_spinand.c +0
-0@@ -496,8 +496,13 @@ static int spinand_program_page(struct spi_device *spi_nand,if (!wbuf)return -ENOMEM ;
drivers/staging/mt29f_spinand/mt29f_spinand.c static int spinand_program_page(struct spi_device *spi_nand, · line 505
Quoted 10 lines
drivers/staging/mt29f_spinand/mt29f_spinand.c +7
-2- enable_read_hw_ecc =0 ; -spinand_read_page (spi_nand, page_id,0 ,CACHE_BUF , wbuf); + enable_read_hw_ecc =1 ; + retval =spinand_read_page (spi_nand, page_id,0 ,CACHE_BUF , wbuf); +if ( retval <0 ) + { +dev_err (&spi_nand->dev,"ecc error on read page!!!\n" ); +return retval; + }
Always use scripts/checkpatch.pl so you don't get grumpy maintainers telling you to use scripts/checkpatch.pl :(