Skip to contentSkip to conversation

ocfs2/dlm: clean dead code up

PATCH Applied Changwei Ge 2 participants 2 messages Nov 24, 2017 OCFS2

lore
Share & tools
lore

Changwei Ge

author
#0 lore raw

PATCH 1/1 ocfs2/dlm: clean dead code up

This code snippet is no longer used. So trim it, thus to make code neat.

Signed-off-by Changwei Ge <[email protected]>
---
  fs/ocfs2/dlm/dlmmaster.c | 7 -------
  1 file changed, 7 deletions(-)
fs/ocfs2/dlm/dlmmaster.c +0 -0
index 3e04279446e8..93b61c6c409e 100644
@@ -1122,13 +1122,6 @@ static int dlm_wait_for_lock_mastery(struct

dlm_ctxt *dlm,
/* sleep if we haven't finished voting yet */
if (sleep) {
unsigned long timeo = msecs_to_jiffies(DLM_MASTERY_TIMEOUT_MS);
-
- /*
- if (kref_read(&mle->mle_refs) < 2)
- mlog(ML_ERROR, "mle (%p) refs=%d, name=%.*s\n", mle,
- kref_read(&mle->mle_refs),
- res->lockname.len, res->lockname.name);
- */
atomic_set(&mle->woken, 0); (void)wait_event_timeout(mle->wq,
(atomic_read(&mle->woken) == 1),

Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ocfs2/dlm: clean dead code up

It looks good to me.

Quoted 3 lines · Changwei Ge

This code snippet is no longer used. So trim it, thus to make code neat.

Signed-off-by Changwei Ge <[email protected]>
Reviewed-by Alex Chen <[email protected]>
Quoted 24 lines
---
  fs/ocfs2/dlm/dlmmaster.c | 7 -------
  1 file changed, 7 deletions(-)
fs/ocfs2/dlm/dlmmaster.c +0 -7
index 3e04279446e8..93b61c6c409e 100644
@@ -1122,13 +1122,6 @@ static int dlm_wait_for_lock_mastery(struct 
 dlm_ctxt *dlm,
  	/* sleep if we haven't finished voting yet */
  	if (sleep) {
  		unsigned long timeo = msecs_to_jiffies(DLM_MASTERY_TIMEOUT_MS);
-
-		/*
-		if (kref_read(&mle->mle_refs) < 2)
-			mlog(ML_ERROR, "mle (%p) refs=%d, name=%.*s\n", mle,
-			kref_read(&mle->mle_refs),
-			res->lockname.len, res->lockname.name);
-		*/
  		atomic_set(&mle->woken, 0);
  		(void)wait_event_timeout(mle->wq,

(atomic_read(&mle->woken) == 1),