Skip to contentSkip to conversation

ocfs2/cluster: neaten a member of o2net_msg_handler

PATCH Applied Changwei Ge 3 participants 3 messages Dec 5, 2017 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2/cluster: neaten a member of o2net_msg_handler

It's odd that o2net_msg_handler::nh_func_data is declared as type o2net_msg_handler_func*.
So neaten it.

---
  fs/ocfs2/cluster/tcp_internal.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/fs/ocfs2/cluster/tcp_internal.h
index b95e7df5b76a..0276f7f8d5e6 100644

fs/ocfs2/cluster/tcp_internal.h +1 -1
@@ -196,7 +196,7 @@ struct o2net_msg_handler {
  	u32			nh_msg_type;
  	u32			nh_key;
  	o2net_msg_handler_func	*nh_func;
-	o2net_msg_handler_func	*nh_func_data;
+	void			*nh_func_data;
  	o2net_post_msg_handler_func
  				*nh_post_func;
  	struct kref		nh_kref;
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ocfs2/cluster: neaten a member of o2net_msg_handler

Hi Changwei,

Thank you for your patch.

Quoted 5 lines · Changwei Ge

It's odd that o2net_msg_handler::nh_func_data is declared as type o2net_msg_handler_func*.
So neaten it.

Quoted 19 lines
---
  fs/ocfs2/cluster/tcp_internal.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/ocfs2/cluster/tcp_internal.h +1 -1
index b95e7df5b76a..0276f7f8d5e6 100644
@@ -196,7 +196,7 @@ struct o2net_msg_handler {
  	u32			nh_msg_type;
  	u32			nh_key;
  	o2net_msg_handler_func	*nh_func;
-	o2net_msg_handler_func	*nh_func_data;
+	void			*nh_func_data;
  	o2net_post_msg_handler_func
  				*nh_post_func;
  	struct kref		nh_kref;
#2 lore raw

PATCH 1/1 ocfs2/cluster: neaten a member of o2net_msg_handler

In reply to Changwei Ge
Quoted 5 lines · Changwei Ge

It's odd that o2net_msg_handler::nh_func_data is declared as type o2net_msg_handler_func*.
So neaten it.

Quoted 19 lines
---
  fs/ocfs2/cluster/tcp_internal.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/ocfs2/cluster/tcp_internal.h +1 -1
index b95e7df5b76a..0276f7f8d5e6 100644
@@ -196,7 +196,7 @@ struct o2net_msg_handler {
  	u32			nh_msg_type;
  	u32			nh_key;
  	o2net_msg_handler_func	*nh_func;
-	o2net_msg_handler_func	*nh_func_data;
+	void			*nh_func_data;
  	o2net_post_msg_handler_func
  				*nh_post_func;
  	struct kref		nh_kref;