Skip to contentSkip to conversation

ocfs2/dlm: clean unrelated comment

PATCH New ge.changwei at h3c.com 3 participants 5 messages Feb 23, 2018 – Feb 24, 2018 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2/dlm: clean unrelated comment

From: Changwei Ge <[email protected]>

Obviously, the comment before dlm_do_local_recovery_cleanup() has nothing to do with it. So remove it.

---
 fs/ocfs2/dlm/dlmrecovery.c | 7 -------
 1 file changed, 7 deletions(-)
fs/ocfs2/dlm/dlmrecovery.c +0 -7
index ec8f758..65f0c54 100644
@@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
 	__dlm_dirty_lockres(dlm, res);
 }
 
-/* if this node is the recovery master, and there are no
- * locks for a given lockres owned by this node that are in
- * either PR or EX mode, zero out the lvb before requesting.
- *
- */
-
-
 static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
 {
 	struct dlm_lock_resource *res;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ocfs2/dlm: clean unrelated comment

Hi changwei,

Quoted 1 line · On 2018/2/23 15:30, ge.changwei at h3c.com wrote:

From: Changwei Ge <[email protected]>

This line seems unnecessary, others looks good to me.

thanks,
Jun

Quoted 28 lines

Obviously, the comment before dlm_do_local_recovery_cleanup() has nothing to do with it. So remove it.

---
 fs/ocfs2/dlm/dlmrecovery.c | 7 -------
 1 file changed, 7 deletions(-)
fs/ocfs2/dlm/dlmrecovery.c +0 -7
index ec8f758..65f0c54 100644
@@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
 	__dlm_dirty_lockres(dlm, res);
 }
 
-/* if this node is the recovery master, and there are no
- * locks for a given lockres owned by this node that are in
- * either PR or EX mode, zero out the lvb before requesting.
- *
- */
-
-
 static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
 {
 	struct dlm_lock_resource *res;
#2 lore raw

PATCH 1/1 ocfs2/dlm: clean unrelated comment

Hi Jun,

Quoted 5 lines · piaojun

Hi changwei,

Quoted 1 line · On 2018/2/23 15:30, ge.changwei at h3c.com wrote:

From: Changwei Ge <[email protected]>

This line seems unnecessary, others looks good to me.

I used git send-email, thus this line was added by parameter --from. I suppose you could ignore it if it seems strange to you:-)

Thanks,
Changwei

Quoted 32 lines

thanks,
Jun

Quoted 28 lines

Obviously, the comment before dlm_do_local_recovery_cleanup() has nothing to do with it. So remove it.

---
  fs/ocfs2/dlm/dlmrecovery.c | 7 -------
  1 file changed, 7 deletions(-)
fs/ocfs2/dlm/dlmrecovery.c +0 -7
index ec8f758..65f0c54 100644
@@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
  	__dlm_dirty_lockres(dlm, res);
  }
 
-/* if this node is the recovery master, and there are no
- * locks for a given lockres owned by this node that are in
- * either PR or EX mode, zero out the lvb before requesting.
- *
- */
-
-
  static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
  {
  	struct dlm_lock_resource *res;
#3 lore raw

PATCH 1/1 ocfs2/dlm: clean unrelated comment

Hi Changwei,

Quoted 10 lines · Changwei Ge

Hi Jun,

Quoted 5 lines · piaojun

Hi changwei,

Quoted 1 line · On 2018/2/23 15:30, ge.changwei at h3c.com wrote:

From: Changwei Ge <[email protected]>

This line seems unnecessary, others looks good to me.

I used git send-email, thus this line was added by parameter --from. I suppose you could ignore it if it seems strange to you:-)

If this won't affect the patch format, you could add:

thanks,
Jun

Quoted 38 lines

Thanks,
Changwei

Quoted 20 lines

thanks,
Jun

Quoted 17 lines

Obviously, the comment before dlm_do_local_recovery_cleanup() has nothing to do with it. So remove it.

---
  fs/ocfs2/dlm/dlmrecovery.c | 7 -------
  1 file changed, 7 deletions(-)
fs/ocfs2/dlm/dlmrecovery.c +0 -0
index ec8f758..65f0c54 100644
@@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm,
  	__dlm_dirty_lockres(dlm, res);
  }
 
Quoted 12 lines

fs/ocfs2/dlm/dlmrecovery.c static void dlm_free_dead_locks(struct dlm_ctxt *dlm, · line 2336

Quoted 11 lines
fs/ocfs2/dlm/dlmrecovery.c +0 -7
-/* if this node is the recovery master, and there are no
- * locks for a given lockres owned by this node that are in
- * either PR or EX mode, zero out the lvb before requesting.
- *
- */
-
-
  static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node)
  {
  	struct dlm_lock_resource *res;

.

#4 lore raw

PATCH 1/1 ocfs2/dlm: clean unrelated comment

In reply to ge.changwei at h3c.com
Quoted 6 lines · On 18/2/23 15:30, ge.changwei at h3c.com wrote:

From: Changwei Ge <[email protected]>

Obviously, the comment before dlm_do_local_recovery_cleanup() has nothing to do with it. So remove it.

It seems to say we can no longer trust the lvb in this case. Maybe it should be placed somewhere to call dlm_revalidate_lvb()?

Anyway, this cleanup looks good to me.