Skip to contentSkip to conversation

ocfs2/dlm: clean up unused stack variable in dlm_do_local_ast()

PATCH New Changwei Ge 2 participants 3 messages Apr 10, 2018 – Apr 11, 2018 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2/dlm: clean up unused stack variable in dlm_do_local_ast()

---
 fs/ocfs2/dlm/dlmast.c | 2 --
 1 file changed, 2 deletions(-)
fs/ocfs2/dlm/dlmast.c +0 -2
index fd6bbbb..39831fc 100644
@@ -224,14 +224,12 @@ void dlm_do_local_ast(struct dlm_ctxt *dlm, struct dlm_lock_resource *res,
 		      struct dlm_lock *lock)
 {
 	dlm_astlockfunc_t *fn;
-	struct dlm_lockstatus *lksb;
 
 	mlog(0, "%s: res %.*s, lock %u:%llu, Local AST\n", dlm->name,
 	     res->lockname.len, res->lockname.name,
 	     dlm_get_lock_cookie_node(be64_to_cpu(lock->ml.cookie)),
 	     dlm_get_lock_cookie_seq(be64_to_cpu(lock->ml.cookie)));
 
-	lksb = lock->lksb;
 	fn = lock->ast;
 	BUG_ON(lock->ml.node != dlm->node_num);
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ocfs2/dlm: clean up unused stack variable in dlm_do_local_ast()

Hi Changwei,

This patch had been merged into mainline already.

Please see patch a43d24cb3b0b.

thanks,
Jun

Quoted 25 lines · Changwei Ge
---
 fs/ocfs2/dlm/dlmast.c | 2 --
 1 file changed, 2 deletions(-)
fs/ocfs2/dlm/dlmast.c +0 -2
index fd6bbbb..39831fc 100644
@@ -224,14 +224,12 @@ void dlm_do_local_ast(struct dlm_ctxt *dlm, struct dlm_lock_resource *res,
 		      struct dlm_lock *lock)
 {
 	dlm_astlockfunc_t *fn;
-	struct dlm_lockstatus *lksb;
 
 	mlog(0, "%s: res %.*s, lock %u:%llu, Local AST\n", dlm->name,
 	     res->lockname.len, res->lockname.name,
 	     dlm_get_lock_cookie_node(be64_to_cpu(lock->ml.cookie)),
 	     dlm_get_lock_cookie_seq(be64_to_cpu(lock->ml.cookie)));
 
-	lksb = lock->lksb;
 	fn = lock->ast;
 	BUG_ON(lock->ml.node != dlm->node_num);
 
#2 lore raw

PATCH 1/1 ocfs2/dlm: clean up unused stack variable in dlm_do_local_ast()

Hi Jun,

Quoted 5 lines · piaojun

Hi Changwei,

This patch had been merged into mainline already.

Please see patch a43d24cb3b0b.

Oops, I forgot to rebase my tree... :(

Thanks for your reminder.

Changwei

Quoted 31 lines

thanks,
Jun

Quoted 25 lines · Changwei Ge
---
  fs/ocfs2/dlm/dlmast.c | 2 --
  1 file changed, 2 deletions(-)
fs/ocfs2/dlm/dlmast.c +0 -2
index fd6bbbb..39831fc 100644
@@ -224,14 +224,12 @@ void dlm_do_local_ast(struct dlm_ctxt *dlm, struct dlm_lock_resource *res,
  		      struct dlm_lock *lock)
  {
  	dlm_astlockfunc_t *fn;
-	struct dlm_lockstatus *lksb;
 
  	mlog(0, "%s: res %.*s, lock %u:%llu, Local AST\n", dlm->name,
  	     res->lockname.len, res->lockname.name,
  	     dlm_get_lock_cookie_node(be64_to_cpu(lock->ml.cookie)),
  	     dlm_get_lock_cookie_seq(be64_to_cpu(lock->ml.cookie)));
 
-	lksb = lock->lksb;
  	fn = lock->ast;
  	BUG_ON(lock->ml.node != dlm->node_num);