arm64: dts: hikey960: Define wl1837 power capabilities
Subsystems (2)
PATCH 1/1 arm64: dts: hikey960: Define wl1837 power capabilities
These properties are required for compatibility with runtime PM. Without these properties, MMC host controller will not be aware of power capabilities. When the wlcore driver attempts to power on the device, it will erroneously fail with -EACCES. This fixes a regression found here: https://lkml.org/lkml/2018/6/12/930
--- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +2 -0
@@ -585,6 +585,8 @@ vmmc-supply = <&wlan_en>; ti,non-removable; non-removable; + cap-power-off-card; + keep-power-in-suspend; #address-cells = <0x1>; #size-cells = <0x0>; status = "ok";
Signature · 1 line
2.11.0
Quoted 7 lines · Ryan Grachek
These properties are required for compatibility with runtime PM. Without these properties, MMC host controller will not be aware of power capabilities. When the wlcore driver attempts to power on the device, it will erroneously fail with
-EACCES. This fixes a regression found here: https://lkml.org/lkml/2018/6/12/930Signed-off-by Ryan Grachek <[email protected]>
Wei Xu: This also fixes a functional regression with wifi on the HiKey960 board that was introduced in 4.18-rc with commit 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power").
Could you please be sure to queue this for the 4.18-rc too?
thanks
-john
Quoted 13 lines · John Stultz
Quoted 7 lines · Ryan Grachek
These properties are required for compatibility with runtime PM. Without these properties, MMC host controller will not be aware of power capabilities. When the wlcore driver attempts to power on the device, it will erroneously fail with
-EACCES. This fixes a regression found here: https://lkml.org/lkml/2018/6/12/930Signed-off-by Ryan Grachek <[email protected]>Fixes 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")Tested-by John Stultz <[email protected]>Acked-by John Stultz <[email protected]>
Quoted 5 lines
Wei Xu: This also fixes a functional regression with wifi on the HiKey960 board that was introduced in 4.18-rc with commit
60f36637bbbd("wlcore: sdio: allow pm to handle sdio power").Could you please be sure to queue this for the 4.18-rc too?
CCing wireless folks as well.
Signature · 1 line
Kalle Valo
Quoted 6 lines · Ryan Grachek
These properties are required for compatibility with runtime PM. Without these properties, MMC host controller will not be aware of power capabilities. When the wlcore driver attempts to power on the device, it will erroneously fail with
-EACCES. This fixes a regression found here: https://lkml.org/lkml/2018/6/12/930
Thanks! As mentioned in the above thread, this lets wlan0 come up properly, which otherwise doesn't come up and spits out:
[ 8.466097] wl1271_sdio mmc1:0001:2: wl12xx_sdio_power_on: failed to get_sync(-13)
Quoted 19 lines
Signed-off-by Ryan Grachek <[email protected]>--- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +2
-0@@ -585,6 +585,8 @@ vmmc-supply = <&wlan_en>; ti,non-removable; non-removable; + cap-power-off-card; + keep-power-in-suspend; #address-cells = <0x1>; #size-cells = <0x0>; status = "ok";
Hi Ryan,
Quoted 8 lines · Ryan Grachek
These properties are required for compatibility with runtime PM. Without these properties, MMC host controller will not be aware of power capabilities. When the wlcore driver attempts to power on the device, it will erroneously fail with
-EACCES. This fixes a regression found here: https://lkml.org/lkml/2018/6/12/930Signed-off-by Ryan Grachek <[email protected]>---
Applied to hisilicon fix tree.
Thanks!
Best Regards,
Wei
Quoted 17 lines
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +2
-0@@ -585,6 +585,8 @@ vmmc-supply = <&wlan_en>; ti,non-removable; non-removable; + cap-power-off-card; + keep-power-in-suspend; #address-cells = <0x1>; #size-cells = <0x0>; status = "ok";