Skip to contentSkip to conversation

KFD co-maintainership and branch model

DISCUSSION Felix Kuehling 6 participants 8 messages Aug 22, 2018 – Aug 27, 2018 6 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Please let me know what you think?

Regards,
  Felix

Signature · 13 lines
F e l i x   K u e h l i n g
PMTS Software Development Engineer | Linux Compute Kernel
1 Commerce Valley Dr. East, Markham, ON L3T 7X6 Canada
(O) +1(289)695-1597
   _     _   _   _____   _____
  / \   | \ / | |  _  \  \ _  |
 / A \  | \M/ | | |D) )  /|_| |
/_/ \_\ |_| |_| |_____/ |__/ \|   facebook.com/AMD | amd.com

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 705cc9da-7ccb-bafd-0dd8-86630b37a8ca-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 8 lines · Felix Kuehling

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

Quoted 7 lines

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Please let me know what you think?

Works for me.

Thanks,
Dave.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CAMwc25pqgoahob6NeJEB5DXr3R05gA05ZRMsgq-dsjWFUusZeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 15 lines · David Airlie
Quoted 13 lines · Felix Kuehling

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Quoted 7 lines
Quoted 2 lines

Please let me know what you think?

Works for me.

Thanks,
Dave.

Works for me as well.

Oded
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CAFCwf11FJpeDyFazspQNo26SNN7CA-CVpFMoKn2Q6hcNX6ymDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw

Am 23.08.2018 um 08:54 schrieb Oded Gabbay:

Quoted 15 lines · David Airlie
Quoted 14 lines · Felix Kuehling
Quoted 13 lines

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

Please let me know what you think?

Works for me.

Thanks,
Dave.

Works for me as well.

Sounds good to me as well.

Christian.

Quoted 6 lines

Oded
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): fdddff79-44f5-46ec-7a0b-b7695edd4219-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#8 lore raw
Quoted 28 lines

-----Original Message-----
From: Christian König <[email protected]>
Sent: Thursday, August 23, 2018 3:01 AM
To: Oded Gabbay <[email protected]>; Dave Airlie <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Kuehling, Felix <[email protected]>; amd-gfx list <[email protected]>
Subject: Re: KFD co-maintainership and branch model

Am 23.08.2018 um 08:54 schrieb Oded Gabbay:

Quoted 2 lines · David Airlie
Quoted 1 line

On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling

Quoted 15 lines · <[email protected]> wrote:
Quoted 15 lines
Quoted 15 lines

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Please let me know what you think?

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

Works for me.

Thanks,
Dave.

Works for me as well.

Sounds good to me as well.

Works for me as well.

Alex

Quoted 9 lines

Christian.

Quoted 6 lines

Oded
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN6PR12MB180964F09192A0BFDA4D0A8BF7370-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#10 lore raw
Quoted 28 lines · Alexander
Quoted 28 lines

-----Original Message-----
From: Christian König <[email protected]>
Sent: Thursday, August 23, 2018 3:01 AM
To: Oded Gabbay <[email protected]>; Dave Airlie <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Kuehling, Felix <[email protected]>; amd-gfx list <[email protected]>
Subject: Re: KFD co-maintainership and branch model

Am 23.08.2018 um 08:54 schrieb Oded Gabbay:

Quoted 2 lines · David Airlie
Quoted 1 line

On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling

Quoted 15 lines · <[email protected]> wrote:
Quoted 15 lines
Quoted 15 lines

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Please let me know what you think?

Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines

Works for me.

Thanks,
Dave.

Works for me as well.

Sounds good to me as well.

Works for me as well.

Thank you. We have agreement.

Right now KFD in amd-staging-drm-next is a bit behind what's drm-next. Alex, are you planning to rebase amd-staging-drm-next soon? If not, I'd like to cherry-pick the missing commits before applying anything new.

Regards,
  Felix

Quoted 10 lines

Alex

Quoted 7 lines

Christian.

Quoted 5 lines

Oded
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): ab96b343-a1cb-6f69-cac6-36f27e04ff29-5C7GfCeVMHo@public.gmane.org

#12 lore raw
Quoted 46 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Felix Kuehling
Sent: Friday, August 24, 2018 5:58 PM
To: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Oded Gabbay <[email protected]>; Dave Airlie <[email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: KFD co-maintainership and branch model

Quoted 12 lines · Alexander
Quoted 12 lines

-----Original Message-----
From: Christian König <[email protected]>
Sent: Thursday, August 23, 2018 3:01 AM
To: Oded Gabbay <[email protected]>; Dave Airlie <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Kuehling, Felix <[email protected]>; amd-gfx list <[email protected]>
Subject: Re: KFD co-maintainership and branch model

Am 23.08.2018 um 08:54 schrieb Oded Gabbay:

Quoted 1 line

On Thu, Aug 23, 2018 at 4:34 AM David Airlie <[email protected]>

Quoted 22 lines · wrote:
Quoted 22 lines
Quoted 1 line
Quoted 1 line

On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling

Quoted 20 lines · <[email protected]> wrote:
Quoted 13 lines
Quoted 13 lines

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Quoted 6 lines
Quoted 2 lines

Please let me know what you think?

Works for me.

Thanks,
Dave.

Works for me as well.

Quoted 9 lines
Quoted 2 lines
Quoted 1 line

Sounds good to me as well.

Works for me as well.

Thank you. We have agreement.

Right now KFD in amd-staging-drm-next is a bit behind what's drm-next. Alex, are you planning to rebase amd-staging-drm-next soon? If not, I'd like to cherry-pick the missing commits before applying anything new.

Yes. I can update it this week.

Alex

Quoted 14 lines

Regards,
  Felix

Quoted 10 lines

Alex

Quoted 7 lines

Christian.

Quoted 5 lines

Oded
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#13 lore raw
In reply to a message not in the archive
Quoted 8 lines · Felix Kuehling

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module.

Quoted 6 lines

With that in mind I'd like to propose to upstream KFD through Alex's branch in the future. It would avoid conflicts in shared code (amdgpu_vm.c is most active at the moment) when merging branches, and make the code flow and testing easier.

Please let me know what you think?

Shall we share the same style as DC upstream in amdgpu?

For the common code like amdgpu_vm.c, it's ideally to work for both KFD and amdgpu gfx. If a patch impacts gfx performance but improves compute ability, we may reserve that as a hybrid patch for production release only.

Regards,
Jerry

Quoted 4 lines

Regards,
Felix

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx