Skip to contentSkip to conversation

Are the trace APIs declared by "TRACE_EVENT(irq_handler_entry" allowed to be used in Ko?

Question Leizhen (ThunderTown) 2 participants 2 messages Sep 12, 2018

lore
Share & tools
lore
#0 lore raw

After patch 7e066fb870fc ("tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()"), the trace APIs declared by "TRACE_EVENT(irq_handler_entry" can not be directly used by ko, because it's not explicitly exported by EXPORT_TRACEPOINT_SYMBOL_GPL or EXPORT_TRACEPOINT_SYMBOL.

Did we miss it? or it's not recommended to be used in ko?

-------------

commit 7e066fb870fcd1025ec3ba7bbde5d541094f4ce1

Author: Mathieu Desnoyers <[email protected]>
Date:   Fri Nov 14 17:47:47 2008 -0500

tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()

Impact: API *CHANGE*. Must update all tracepoint users.

Add DEFINE_TRACE() to tracepoints to let them declare the tracepoint structure in a single spot for all the kernel. It helps reducing memory consumption, especially when declaring a lot of tracepoints, e.g. for kmalloc tracing.

*API CHANGE WARNING*: now, DECLARE_TRACE() must be used in headers for tracepoint declarations rather than DEFINE_TRACE(). This is the sane way to do it. The name previously used was misleading.

Updates scheduler instrumentation to follow this API change.

Signature · 2 lines
Thanks!
BestRegards
#1 lore raw
Quoted 7 lines · On Wed, 12 Sep 2018 10:08:37 +0800 "Leizhen (ThunderTown)"…

After patch 7e066fb870fc ("tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()"), the trace APIs declared by "TRACE_EVENT(irq_handler_entry" can not be directly used by ko, because it's not explicitly exported by EXPORT_TRACEPOINT_SYMBOL_GPL or EXPORT_TRACEPOINT_SYMBOL.

Did we miss it? or it's not recommended to be used in ko?

Why do you need it. This patch is almost 10 years old, and you are just now finding an issue with it?

-- Steve

Quoted 23 lines

-------------

commit 7e066fb870fcd1025ec3ba7bbde5d541094f4ce1

Author: Mathieu Desnoyers <[email protected]>
Date:   Fri Nov 14 17:47:47 2008 -0500

tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()

Impact: API *CHANGE*. Must update all tracepoint users.

Add DEFINE_TRACE() to tracepoints to let them declare the tracepoint structure in a single spot for all the kernel. It helps reducing memory consumption, especially when declaring a lot of tracepoints, e.g. for kmalloc tracing.

*API CHANGE WARNING*: now, DECLARE_TRACE() must be used in headers for tracepoint declarations rather than DEFINE_TRACE(). This is the sane way to do it. The name previously used was misleading.

Updates scheduler instrumentation to follow this API change.