bjam-native: do not search all PATHs variable
PATCH 1/1 bjam-native: do not search all PATHs variable
From: Li Wang <[email protected]>
By default, it searches all paths specified by $PATH.
But if the directory of the $PATH variable on build host includes nfs(build host as nfs client), it causes the build hung when the nfs server is unavailable.
--- meta/recipes-support/boost/bjam-native_1.69.0.bb | 1 + .../bjam-do-not-search-all-PATHs-varibale.patch | 53 ++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 meta/recipes-support/boost/files/bjam-do-not-search-all-PATHs-varibale.patch
meta/recipes-support/boost/bjam-native_1.69.0.bb +1 -0
@@ -6,6 +6,7 @@ SECTION = "devel" inherit native SRC_URI += "file://bjam-native-build-bjam.debug.patch \ + file://bjam-do-not-search-all-PATHs-varibale.patch \ " do_compile() {
meta/recipes-support/boost/files/bjam-do-not-search-all-PATHs-varibale.patch new file +53 -0
53 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v2 1/1 bjam-native: do not search all PATHs variable
From: Li Wang <[email protected]>
By default, it searches all paths specified by $PATH.
But if the directory of the $PATH variable on build host includes nfs(build host as nfs client), it causes the build hung when the nfs server is unavailable.
--- meta/recipes-support/boost/bjam-native_1.69.0.bb | 1 + .../bjam-do-not-search-all-PATHs-varibale.patch | 53 ++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 meta/recipes-support/boost/files/bjam-do-not-search-all-PATHs-varibale.patch
meta/recipes-support/boost/bjam-native_1.69.0.bb +1 -0
@@ -6,6 +6,7 @@ SECTION = "devel" inherit native SRC_URI += "file://bjam-native-build-bjam.debug.patch \ + file://bjam-do-not-search-all-PATHs-varibale.patch \ " do_compile() {
meta/recipes-support/boost/files/bjam-do-not-search-all-PATHs-varibale.patch new file +53 -0
53 lines not on this page · raw message
Signature · 1 line
2.7.4
Wait, why is this a problem for specifically bjam, but not the other tools that also look into PATH? Shouldn’t you fix the nfs instead?
Alex
Quoted 98 lines · On 28 Apr 2019, at 9.02, <[email protected]> <[email protected]>…
From: Li Wang <[email protected]>
By default, it searches all paths specified by $PATH.
But if the directory of the $PATH variable on build host includes nfs(build host as nfs client), it causes the build hung when the nfs server is unavailable.
Signed-off-by Li Wang <[email protected]>Signed-off-by Mingli Yu <[email protected]>---
meta/recipes-support/boost/bjam-native_1.69.0.bb | 1 +.../bjam-do-not-search-all-PATHs-varibale.patch| 53 ++++++++++++++++++++++2 files changed, 54 insertions(+)create mode 100644
meta/recipes-support/boost/files/bjam-do-not-search-all-PATHs-varibale.patchmeta/recipes-support/boost/bjam-native_1.69.0.bb +0
-0@@ -6,6 +6,7 @@ SECTION = "devel"inherit native
SRC_URI+= "file://bjam-native-build-bjam.debug.patch \
+ file://bjam-do-not-search-all-PATHs-varibale.patch \
"
do_compile(){meta/recipes-support/boost/files/bjam-do-not-search-all-PATHs-varibale.patch new file +53
-0@@ -0,0 +1,53 @@ +bjam: do not search all PATHs varibale + +By default, it searches all paths specified by $PATH. +But if the directory of the $PATH variable on +build host includes nfs, it causes system hung +when nfs server is unavailable. + +Upstream-Status: Inappropriate [oe specific] + +Signed-off-by: Li Wang <[email protected]> +Signed-off-by: Mingli Yu <[email protected]> +--- + tools/build/src/engine/build.jam | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/tools/build/src/engine/build.jam b/tools/build/src/engine/build.jam +index a92b70f..f866619 100644 +--- a/tools/build/src/engine/build.jam ++++ b/tools/build/src/engine/build.jam +@@ -781,8 +781,8 @@ if $(OS) = NT + } + SUFEXE ?= "" ; + +-yacc ?= [ GLOB $(PATH) : yacc$(SUFEXE) ] ; +-yacc ?= [ GLOB $(PATH) : bison$(SUFEXE) ] ; ++yacc ?= [ GLOB "" : yacc$(SUFEXE) ] ; ++yacc ?= [ GLOB "" : bison$(SUFEXE) ] ; + yacc ?= [ GLOB "$(ProgramFiles:J= )\\GnuWin32\\bin" + "C:\\Program Files\\GnuWin32\\bin" : bison$(SUFEXE) ] ; + yacc = $(yacc[1]) ; +@@ -966,7 +966,7 @@ if $(OS) = NT + } + if $(UNIX) = true + { +- tar ?= [ GLOB $(PATH) : star bsdtar tar ] ; ++ tar ?= [ GLOB "" : star bsdtar tar ] ; + tar = $(tar[1]) ; + switch $(tar:D=:S=) + { +@@ -1047,8 +1047,8 @@ rule .package ( dst-dir : src-files + ) + } + + # RPM distro file. +-rpm-tool = [ GLOB $(PATH) : "rpmbuild" ] ; +-rpm-tool ?= [ GLOB $(PATH) : "rpm" ] ; ++rpm-tool = [ GLOB "" : "rpmbuild" ] ; ++rpm-tool ?= [ GLOB "" : "rpm" ] ; + rpm-tool = $(rpm-tool[1]) ; + rule .rpm ( name : source ) + { +-- +2.18.1 +Signature · 7 lines
2.7.4 -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 2 lines · Alexander Kanavin
Wait, why is this a problem for specifically bjam, but not the other tools that also look into PATH? Shouldn’t you fix the nfs instead?
I have to agree that you really don't want invalids NFS paths in PATH. We're not carrying a patch for that.
Cheers,
Richard
Quoted 108 lines
Alex
Quoted 106 lines
On 28 Apr 2019, at 9.02, <[email protected]> < [email protected]> wrote:
From: Li Wang <[email protected]>
By default, it searches all paths specified by $PATH.
But if the directory of the $PATH variable on build host includes nfs(build host as nfs client), it causes the build hung when the nfs server is unavailable.
Signed-off-by Li Wang <[email protected]>Signed-off-by Mingli Yu <[email protected]>---
meta/recipes-support/boost/bjam-native_1.69.0.bb | 1 +.../bjam-do-not-search-all-PATHs-varibale.patch| 53
++++++++++++++++++++++2 files changed, 54 insertions(+)create mode 100644 meta/recipes-support/boost/files/bjam-do-not- search-all-PATHs-varibale.patch
meta/recipes-support/boost/bjam-native_1.69.0.bb +0
-0@@ -6,6 +6,7 @@ SECTION = "devel"inherit native
SRC_URI+= "file://bjam-native-build-bjam.debug.patch \
+ file://bjam-do-not-search-all-PATHs-varibale.patch \
"
do_compile(){(quoted diff) +0
-0all-PATHs-varibale.patch b/meta/recipes-support/boost/files/bjam- do-not-search-all-PATHs-varibale.patch
new file mode 100644
index 0000000..742603ameta/recipes-support/boost/files/bjam-do-not-search-all- new file +0
-0PATHs-varibale.patch
meta/recipes-support/boost/files/bjam-do-not-search-all- new file +16
-0@@ -0,0 +1,53 @@ +bjam: do not search all PATHs varibale + +By default, it searches all paths specified by $PATH. +But if the directory of the $PATH variable on +build host includes nfs, it causes system hung +when nfs server is unavailable. + +Upstream-Status: Inappropriate [oe specific] + +Signed-off-by: Li Wang <[email protected]> +Signed-off-by: Mingli Yu <[email protected]> +--- + tools/build/src/engine/build.jam | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/tools/build/src/engine/build.jamb/tools/build/src/engine/build.jam
meta/recipes-support/boost/files/bjam-do-not-search-all- new file +37
-0+index a92b70f..f866619 100644 +--- a/tools/build/src/engine/build.jam ++++ b/tools/build/src/engine/build.jam +@@ -781,8 +781,8 @@ if $(OS) = NT + } + SUFEXE ?= "" ; + +-yacc ?= [ GLOB $(PATH) : yacc$(SUFEXE) ] ; +-yacc ?= [ GLOB $(PATH) : bison$(SUFEXE) ] ; ++yacc ?= [ GLOB "" : yacc$(SUFEXE) ] ; ++yacc ?= [ GLOB "" : bison$(SUFEXE) ] ; + yacc ?= [ GLOB "$(ProgramFiles:J= )\\GnuWin32\\bin" + "C:\\Program Files\\GnuWin32\\bin" : bison$(SUFEXE) ] ; + yacc = $(yacc[1]) ; +@@ -966,7 +966,7 @@ if $(OS) = NT + } + if $(UNIX) = true + { +- tar ?= [ GLOB $(PATH) : star bsdtar tar ] ; ++ tar ?= [ GLOB "" : star bsdtar tar ] ; + tar = $(tar[1]) ; + switch $(tar:D=:S=) + { +@@ -1047,8 +1047,8 @@ rule .package ( dst-dir : src-files + ) + } + + # RPM distro file. +-rpm-tool = [ GLOB $(PATH) : "rpmbuild" ] ; +-rpm-tool ?= [ GLOB $(PATH) : "rpm" ] ; ++rpm-tool = [ GLOB "" : "rpmbuild" ] ; ++rpm-tool ?= [ GLOB "" : "rpm" ] ; + rpm-tool = $(rpm-tool[1]) ; + rule .rpm ( name : source ) + { +-- +2.18.1 +Signature · 7 lines
2.7.4 -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 6 lines · Richard Purdie
Quoted 2 lines · Alexander Kanavin
Wait, why is this a problem for specifically bjam, but not the other tools that also look into PATH? Shouldn’t you fix the nfs instead?
I have to agree that you really don't want invalids NFS paths in PATH. We're not carrying a patch for that.
Thanks RP and Alex's comments!
It makes sense, the patch is inappropriate.
Thanks,
Quoted 115 lines
Cheers,
Richard
Quoted 108 lines
Alex
Quoted 106 lines
On 28 Apr 2019, at 9.02, <[email protected]> < [email protected]> wrote:
From: Li Wang <[email protected]>
By default, it searches all paths specified by $PATH.
But if the directory of the $PATH variable on build host includes nfs(build host as nfs client), it causes the build hung when the nfs server is unavailable.
Signed-off-by Li Wang <[email protected]>Signed-off-by Mingli Yu <[email protected]>---
meta/recipes-support/boost/bjam-native_1.69.0.bb | 1 +.../bjam-do-not-search-all-PATHs-varibale.patch| 53
++++++++++++++++++++++2 files changed, 54 insertions(+)create mode 100644 meta/recipes-support/boost/files/bjam-do-not- search-all-PATHs-varibale.patch
meta/recipes-support/boost/bjam-native_1.69.0.bb +0
-0@@ -6,6 +6,7 @@ SECTION = "devel"inherit native
SRC_URI+= "file://bjam-native-build-bjam.debug.patch \
+ file://bjam-do-not-search-all-PATHs-varibale.patch \
"
do_compile(){(quoted diff) +0
-0all-PATHs-varibale.patch b/meta/recipes-support/boost/files/bjam- do-not-search-all-PATHs-varibale.patch
new file mode 100644
index 0000000..742603ameta/recipes-support/boost/files/bjam-do-not-search-all- new file +0
-0PATHs-varibale.patch
meta/recipes-support/boost/files/bjam-do-not-search-all- new file +16
-0@@ -0,0 +1,53 @@ +bjam: do not search all PATHs varibale + +By default, it searches all paths specified by $PATH. +But if the directory of the $PATH variable on +build host includes nfs, it causes system hung +when nfs server is unavailable. + +Upstream-Status: Inappropriate [oe specific] + +Signed-off-by: Li Wang <[email protected]> +Signed-off-by: Mingli Yu <[email protected]> +--- + tools/build/src/engine/build.jam | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/tools/build/src/engine/build.jamb/tools/build/src/engine/build.jam
meta/recipes-support/boost/files/bjam-do-not-search-all- new file +37
-1+index a92b70f..f866619 100644 +--- a/tools/build/src/engine/build.jam ++++ b/tools/build/src/engine/build.jam +@@ -781,8 +781,8 @@ if $(OS) = NT + } + SUFEXE ?= "" ; + +-yacc ?= [ GLOB $(PATH) : yacc$(SUFEXE) ] ; +-yacc ?= [ GLOB $(PATH) : bison$(SUFEXE) ] ; ++yacc ?= [ GLOB "" : yacc$(SUFEXE) ] ; ++yacc ?= [ GLOB "" : bison$(SUFEXE) ] ; + yacc ?= [ GLOB "$(ProgramFiles:J= )\\GnuWin32\\bin" + "C:\\Program Files\\GnuWin32\\bin" : bison$(SUFEXE) ] ; + yacc = $(yacc[1]) ; +@@ -966,7 +966,7 @@ if $(OS) = NT + } + if $(UNIX) = true + { +- tar ?= [ GLOB $(PATH) : star bsdtar tar ] ; ++ tar ?= [ GLOB "" : star bsdtar tar ] ; + tar = $(tar[1]) ; + switch $(tar:D=:S=) + { +@@ -1047,8 +1047,8 @@ rule .package ( dst-dir : src-files + ) + } + + # RPM distro file. +-rpm-tool = [ GLOB $(PATH) : "rpmbuild" ] ; +-rpm-tool ?= [ GLOB $(PATH) : "rpm" ] ; ++rpm-tool = [ GLOB "" : "rpmbuild" ] ; ++rpm-tool ?= [ GLOB "" : "rpm" ] ; + rpm-tool = $(rpm-tool[1]) ; + rule .rpm ( name : source ) + { +-- +2.18.1 + --2.7.4
--
_______________________________________________
Openembedded-core mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core