Skip to contentSkip to conversation

syscall/ioctl: fix compiler error

PATCH New Jinhui huang 3 participants 5 messages May 13, 2019 – May 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscall/ioctl: fix compiler error

"CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros, so include "lapi/namespaces_constants.h" to fix it.

---
 testcases/kernel/syscalls/ioctl/ioctl_ns01.c | 1 +
 testcases/kernel/syscalls/ioctl/ioctl_ns05.c | 1 +
 testcases/kernel/syscalls/ioctl/ioctl_ns06.c | 1 +
 3 files changed, 3 insertions(+)
testcases/kernel/syscalls/ioctl/ioctl_ns01.c +1 -0
index 59b215f..f2c77a0 100644
@@ -19,6 +19,7 @@
 #include <sched.h>
 #include "tst_test.h"
 #include "lapi/ioctl_ns.h"
+#include "lapi/namespaces_constants.h"
 
 #define STACK_SIZE (1024 * 1024)
 
testcases/kernel/syscalls/ioctl/ioctl_ns05.c +1 -0
index add6980..bdef4d6 100644
@@ -18,6 +18,7 @@
 #include <sched.h>
 #include "tst_test.h"
 #include "lapi/ioctl_ns.h"
+#include "lapi/namespaces_constants.h"
 
 #define STACK_SIZE (1024 * 1024)
 
testcases/kernel/syscalls/ioctl/ioctl_ns06.c +1 -0
index f077a3b..eabb7e4 100644
@@ -19,6 +19,7 @@
 #include <sched.h>
 #include "tst_test.h"
 #include "lapi/ioctl_ns.h"
+#include "lapi/namespaces_constants.h"
 
 #define STACK_SIZE (1024 * 1024)
 
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 syscall/ioctl: fix compiler error

Hi Jinhui,

Quoted 2 lines

"CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros, so include "lapi/namespaces_constants.h" to fix it.

Can you be more specific, which distros?
CLONE_* has been added into glibc in 2008 (released in glibc 2.8).

Quoted 1 line

@Cyril: this could go before release as well.

Kind regards,
Petr

#2 lore raw

PATCH 1/1 syscall/ioctl: fix compiler error

Hi!

Quoted 10 lines
Quoted 2 lines

"CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros, so include "lapi/namespaces_constants.h" to fix it.

Can you be more specific, which distros?
CLONE_* has been added into glibc in 2008 (released in glibc 2.8).

Quoted 1 line

@Cyril: this could go before release as well.

Let's wait a bit I would be happier if we had more info about the distros this patch is fixing. But other than that this is pretty much obvious fix.

Signature · 2 lines
Cyril Hrubis
[email protected]
#3 lore raw

PATCH 1/1 syscall/ioctl: fix compiler error

In reply to Petr Vorel

On 2019/05/14 21:02, Petr Vorel wrote:

Hi,

Quoted 7 lines

Hi Jinhui,

Quoted 2 lines

"CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros, so include "lapi/namespaces_constants.h" to fix it.

Can you be more specific, which distros?
CLONE_* has been added into glibc in 2008 (released in glibc 2.8).

The kernel version is 2.6.18-398.el5 and the glibc version is glibc-2.5-123.

Quoted 7 lines
Quoted 1 line

@Cyril: this could go before release as well.

Kind regards,
Petr

Kind regards,
Jinhui

#4 lore raw

PATCH 1/1 syscall/ioctl: fix compiler error

Hi Jinhui,

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

"CLONE_NEWPID" and "CLONE_NEWUSER" are not defined on some old distros, so include "lapi/namespaces_constants.h" to fix it.

Can you be more specific, which distros?
CLONE_* has been added into glibc in 2008 (released in glibc 2.8).

The kernel version is 2.6.18-398.el5 and the glibc version is glibc-2.5-123.

Thanks for info, merged!

Kind regards,
Petr