Skip to contentSkip to conversation

scenario_groups/default: run the kernel_misc test after the cve test

PATCH New Po-Hsu Lin 3 participants 9 messages Jun 28, 2019 – Jul 2, 2019

lore
Share & tools
lore

Po-Hsu Lin

author
#0 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

The block_dev test in kernel_misc will taint kernel with a warning flag, this is an expected behaviour.

However, if you run the cve-2017-17053 after it, as the test is looking for a warning / died flag for a tainted kernel, it will cause false alarm with:
tst_taint.c:88: BROK: Kernel is already tainted: 14849

The kernel_misc test was executed before the cve test in the default test plan. Move the kernel_misc test to the end of the list to workaround this issue.

---
 scenario_groups/default | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scenario_groups/default +1 -1
index 1f3e5b27f..e5b34782c 100644
@@ -22,7 +22,6 @@ power_management_tests
 hugetlb
 commands
 hyperthreading
-kernel_misc
 fs_ext4
 can
 cpuhotplug
@@ -30,3 +29,4 @@ net.ipv6_lib
 input
 cve
 crypto
+kernel_misc
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

Hi,

Your patch just workarounds the issue for now, because it still happens if a new test designed to taint
kernel is added to the group before cve group in future.

Could we save the value of tainted before running block_dev and then restore it after running block_dev?

Best Regards,
Xiao Yang

Quoted 34 lines · Po-Hsu Lin

The block_dev test in kernel_misc will taint kernel with a warning flag, this is an expected behaviour.

However, if you run the cve-2017-17053 after it, as the test is looking for a warning / died flag for a tainted kernel, it will cause false alarm with:
tst_taint.c:88: BROK: Kernel is already tainted: 14849

The kernel_misc test was executed before the cve test in the default test plan. Move the kernel_misc test to the end of the list to workaround this issue.

---
  scenario_groups/default | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
scenario_groups/default +1 -1
index 1f3e5b27f..e5b34782c 100644
@@ -22,7 +22,6 @@ power_management_tests
  hugetlb
  commands
  hyperthreading
-kernel_misc
  fs_ext4
  can
  cpuhotplug
@@ -30,3 +29,4 @@ net.ipv6_lib
  input
  cve
  crypto
+kernel_misc
author
#2 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

Hello,

I am not sure if we can restore the value in /proc/sys/kernel/tainted, which can be changed manually:

    # cat  /proc/sys/kernel/tainted
    0
    # echo 12800 > /proc/sys/kernel/tainted
    # cat  /proc/sys/kernel/tainted
    12800
But it can't be reset back to 0.

From the Documentation/admin-guide/tainted-kernels.rst, it states that:
"Note the kernel will remain tainted even after you undo what caused the taint (i.e. unload a proprietary kernel module), to indicate the kernel remains not trustworthy."

Thanks

Quoted 50 lines · Xiao Yang

Hi,

Your patch just workarounds the issue for now, because it still happens if a new test designed to taint
kernel is added to the group before cve group in future.

Could we save the value of tainted before running block_dev and then restore it after running block_dev?

Best Regards,
Xiao Yang

Quoted 34 lines · Po-Hsu Lin

The block_dev test in kernel_misc will taint kernel with a warning flag, this is an expected behaviour.

However, if you run the cve-2017-17053 after it, as the test is looking for a warning / died flag for a tainted kernel, it will cause false alarm with:
tst_taint.c:88: BROK: Kernel is already tainted: 14849

The kernel_misc test was executed before the cve test in the default test plan. Move the kernel_misc test to the end of the list to workaround this issue.

---
  scenario_groups/default | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
scenario_groups/default +1 -1
index 1f3e5b27f..e5b34782c 100644
@@ -22,7 +22,6 @@ power_management_tests
  hugetlb
  commands
  hyperthreading
-kernel_misc
  fs_ext4
  can
  cpuhotplug
@@ -30,3 +29,4 @@ net.ipv6_lib
  input
  cve
  crypto
+kernel_misc
#3 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

Quoted 10 lines · Po-Hsu Lin

Hello,

I am not sure if we can restore the value in /proc/sys/kernel/tainted, which can be changed manually:

     # cat  /proc/sys/kernel/tainted
     0
     # echo 12800>  /proc/sys/kernel/tainted
     # cat  /proc/sys/kernel/tainted
     12800
But it can't be reset back to 0.

Hi,

It seems that the value of /proc/sys/kernel/tainted only be increased.

Best Regards,
Xiao Yang

Quoted 58 lines
Quoted 1 line

From the Documentation/admin-guide/tainted-kernels.rst, it states that:

"Note the kernel will remain tainted even after you undo what caused the taint (i.e. unload a proprietary kernel module), to indicate the kernel remains not trustworthy."

Thanks

Quoted 48 lines · Xiao Yang

Hi,

Your patch just workarounds the issue for now, because it still happens if a new test designed to taint
kernel is added to the group before cve group in future.

Could we save the value of tainted before running block_dev and then restore it after running block_dev?

Best Regards,
Xiao Yang

Quoted 34 lines · Po-Hsu Lin

The block_dev test in kernel_misc will taint kernel with a warning flag, this is an expected behaviour.

However, if you run the cve-2017-17053 after it, as the test is looking for a warning / died flag for a tainted kernel, it will cause false alarm with:
tst_taint.c:88: BROK: Kernel is already tainted: 14849

The kernel_misc test was executed before the cve test in the default test plan. Move the kernel_misc test to the end of the list to workaround this issue.

---
   scenario_groups/default | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
scenario_groups/default +1 -1
index 1f3e5b27f..e5b34782c 100644
@@ -22,7 +22,6 @@ power_management_tests
   hugetlb
   commands
   hyperthreading
-kernel_misc
   fs_ext4
   can
   cpuhotplug
@@ -30,3 +29,4 @@ net.ipv6_lib
   input
   cve
   crypto
+kernel_misc
#4 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

Hi!

Quoted 1 line

It seems that the value of /proc/sys/kernel/tainted only be increased.

That is by design, since otherwise people would erase the track of unsigned/out-of-tree modules being loaded...

Signature · 2 lines
Cyril Hrubis
[email protected]
#5 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

In reply to Xiao Yang

Hi!

Quoted 3 lines

Your patch just workarounds the issue for now, because it still happens if a new test designed to taint
kernel is added to the group before cve group in future.

Unfortunately there is no better solution for this, so I pushed the patch.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#6 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

Hello,
thanks for the review,
do you think if we should put a comment (if possible) inside that file to avoid getting re-ordered for some reason in the future?

Quoted 12 lines · Cyril Hrubis

Hi!

Quoted 3 lines

Your patch just workarounds the issue for now, because it still happens if a new test designed to taint
kernel is added to the group before cve group in future.

Unfortunately there is no better solution for this, so I pushed the patch.

--
Cyril Hrubis
[email protected]

#7 lore raw

PATCH 1/1 scenario_groups/default: run the kernel_misc test after the cve test

Hi!

Quoted 3 lines

thanks for the review,
do you think if we should put a comment (if possible) inside that file to avoid getting re-ordered for some reason in the future?

We cannot, the scenari files are simply read line by line, the format does not support comments.

Signature · 2 lines
Cyril Hrubis
[email protected]