Skip to contentSkip to conversation

libseccomp: import from meta-security

PATCH In review [email protected] 4 participants 9 messages Jul 25, 2019 – Jul 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libseccomp: import from meta-security

From: Mingli Yu <[email protected]>

---
 .../recipes-security/libseccomp/files/run-ptest    |  4 +++
 .../libseccomp/libseccomp_2.4.1.bb                 | 41 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta-oe/recipes-security/libseccomp/files/run-ptest
 create mode 100644 meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
meta-oe/recipes-security/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 0000000..54b4a63
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · On Thu, Jul 25, 2019 at 3:06 AM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Can you share some details as to why this should be pulled from meta-security into a different repo ?

It seems to fit the mandate of meta-security quite nicely ;)

Is there some sort of dependency issue, or other technical problem that is causing a problem ?

Bruce

Quoted 74 lines
---
 .../recipes-security/libseccomp/files/run-ptest    |  4 +++
 .../libseccomp/libseccomp_2.4.1.bb                 | 41 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta-oe/recipes-security/libseccomp/files/run-ptest
 create mode 100644 meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
meta-oe/recipes-security/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 0000000..54b4a63
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +41 -1
new file mode 100644
index 0000000..dba1be5
@@ -0,0 +1,41 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.4 \
+           file://run-ptest \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "bash"
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#2 lore raw
Quoted 6 lines · Bruce Ashfield
Quoted 2 lines · On Thu, Jul 25, 2019 at 3:06 AM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Can you share some details as to why this should be pulled from meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

Meanwhile, the below yocto compliance check error disappears once we
move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb DEPENDS on or otherwise requires it). Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

Thanks,

Quoted 85 lines

It seems to fit the mandate of meta-security quite nicely ;)

Is there some sort of dependency issue, or other technical problem that is causing a problem ?

Bruce

Quoted 74 lines
---
  .../recipes-security/libseccomp/files/run-ptest    |  4 +++
  .../libseccomp/libseccomp_2.4.1.bb                 | 41 ++++++++++++++++++++++
  2 files changed, 45 insertions(+)

create mode 100644 meta-oe/recipes-security/libseccomp/files/run-ptest create mode 100644 meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb

meta-oe/recipes-security/libseccomp/files/run-ptest new file +4 -0
new file mode 100644
index 0000000..54b4a63
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +41 -1
new file mode 100644
index 0000000..dba1be5
@@ -0,0 +1,41 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use, platform independent,interface to the Linux Kernel's syscall filtering mechanism: seccomp."
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
+
+SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.4 \
+           file://run-ptest \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/* ${libdir}/${PN}/tools/.debug"
+
+RDEPENDS_${PN}-ptest = "bash"
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 5 lines · Mingli
Quoted 2 lines · Bruce Ashfield
Quoted 1 line · On Thu, Jul 25, 2019 at 3:06 AM <[email protected]> wrote:
Quoted 9 lines
Quoted 4 lines
Quoted 1 line

From: Mingli Yu <[email protected]>

Can you share some details as to why this should be pulled from meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

.. but it is literally churn for the sake of churn.

Meaning, that isn't a great reason to move something. If Armin wanted to put the recipe in meta-oe, he would have done it himself.

Quoted 12 lines

Meanwhile, the below yocto compliance check error disappears once we move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/ cri-o_git.bb
DEPENDS on or otherwise requires it).
Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Quoted 3 lines

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

Also not a valid reason. We've just fixed meta-virtualization, so there's no need to shuffle something like this around, just to keep another layers compliance check working.

Bruce

Quoted 98 lines

Thanks,

Quoted 13 lines

It seems to fit the mandate of meta-security quite nicely ;)

Is there some sort of dependency issue, or other technical problem that is causing a problem ?

Bruce

Quoted 5 lines
---
  .../recipes-security/libseccomp/files/run-ptest    |  4 +++
  .../libseccomp/libseccomp_2.4.1.bb                 | 41

++++++++++++++++++++++

Quoted 3 lines
Quoted 3 lines
  2 files changed, 45 insertions(+)

create mode 100644 meta-oe/recipes-security/libseccomp/files/run-ptest create mode 100644 meta-oe/recipes-security/libseccomp/

libseccomp_2.4.1.bb

Quoted 2 lines

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta-oe/recipes-security/libseccomp/files/run-ptest

Quoted 10 lines

Review

Quoted 10 lines

new file mode 100644
index 0000000..54b4a63

meta-oe/recipes-security/libseccomp/files/run-ptest new file +4 -0
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+cd tests
+./regression -a
(quoted diff) +0 -0

b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb

Quoted 7 lines

meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb line 2

Quoted 7 lines

new file mode 100644
index 0000000..dba1be5

meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +2 -0
@@ -0,0 +1,41 @@
+SUMMARY = "interface to seccomp filtering mechanism"
+DESCRIPTION = "The libseccomp library provides and easy to use,

platform independent,interface to the Linux Kernel's syscall filtering
mechanism: seccomp."

Quoted 3 lines

meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb

Quoted 3 lines
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +3 -0
+SECTION = "security"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM =

"file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"

Quoted 4 lines

meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb

Quoted 4 lines
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +4 -0
+
+SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
+
+SRC_URI = "git://github.com/seccomp/libseccomp.git;branch=release-2.4

\

Quoted 22 lines
Quoted 22 lines
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +22 -0
+           file://run-ptest \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep pkgconfig ptest
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
+
+do_compile_ptest() {
+    oe_runmake -C tests check-build
+}
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    install -d ${D}${PTEST_PATH}/tools
+    for file in $(find tests/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    for file in $(find tests/*.tests -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
Quoted 8 lines

meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb

Quoted 8 lines
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +8 -0
+    done
+    for file in $(find tools/* -executable -type f); do
+        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
+    done
+}
+
+FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
+FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*

${libdir}/${PN}/tools/.debug"

Quoted 13 lines
Quoted 10 lines
meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb new file +2 -1
+
+RDEPENDS_${PN}-ptest = "bash"
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#4 lore raw
Quoted 23 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:28 PM Yu, Mingli <[email protected] <mailto:[email protected]>> wrote:

On 2019年07月25日 21:45, Bruce Ashfield wrote:
> On Thu, Jul 25, 2019 at 3:06 AM <[email protected]
<mailto:[email protected]>> wrote:
>>
>> From: Mingli Yu <[email protected]
<mailto:[email protected]>>
>
> Can you share some details as to why this should be pulled from > meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

Quoted 4 lines

.. but it is literally churn for the sake of churn.

Meaning, that isn't a great reason to move something. If Armin wanted to put the recipe in meta-oe, he would have done it himself.

^_^, I noticed Armin did try to do this in this thread "[oe] [meta-oe][PATCH 1/2] libseccomp: move lib from meta-security to meta-oe" in Jun 1, 2018.

Quoted 137 lines

Meanwhile, the below yocto compliance check error disappears once we move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it).
Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

Also not a valid reason. We've just fixed meta-virtualization, so there's no need to shuffle something like this around, just to keep another layers compliance check working.

Bruce

    Thanks,

     >
     > It seems to fit the mandate of meta-security quite nicely ;)
     >
     > Is there some sort of dependency issue, or other technical problem
     > that is causing a problem ?
     >
     > Bruce
     >
     >>
     >> Signed-off-by: Mingli Yu <[email protected]
    <mailto:[email protected]>>
     >> ---
     >>   .../recipes-security/libseccomp/files/run-ptest    |  4 +++
     >>   .../libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>                 | 41 ++++++++++++++++++++++
     >>   2 files changed, 45 insertions(+)
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/files/run-ptest
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >>
     >> diff --git a/meta-oe/recipes-security/libseccomp/files/run-ptest
    b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> new file mode 100644
     >> index 0000000..54b4a63
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> @@ -0,0 +1,4 @@
     >> +#!/bin/sh
     >> +
     >> +cd tests
     >> +./regression -a
     >> diff --git
    a/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
    b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> new file mode 100644
     >> index 0000000..dba1be5
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> @@ -0,0 +1,41 @@
     >> +SUMMARY = "interface to seccomp filtering mechanism"
     >> +DESCRIPTION = "The libseccomp library provides and easy to use,
    platform independent,interface to the Linux Kernel's syscall
    filtering mechanism: seccomp."
     >> +SECTION = "security"
     >> +LICENSE = "LGPL-2.1"
     >> +LIC_FILES_CHKSUM =
    "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
     >> +
     >> +SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
     >> +
     >> +SRC_URI =
    "git://github.com/seccomp/libseccomp.git;branch=release-2.4
    <http://github.com/seccomp/libseccomp.git;branch=release-2.4> \
     >> +           file://run-ptest \
     >> +"
     >> +
     >> +S = "${WORKDIR}/git"
     >> +
     >> +inherit autotools-brokensep pkgconfig ptest
     >> +
     >> +PACKAGECONFIG ??= ""
     >> +PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
     >> +
     >> +do_compile_ptest() {
     >> +    oe_runmake -C tests check-build
     >> +}
     >> +
     >> +do_install_ptest() {
     >> +    install -d ${D}${PTEST_PATH}/tests
     >> +    install -d ${D}${PTEST_PATH}/tools
     >> +    for file in $(find tests/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tests/*.tests -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tools/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
     >> +    done
     >> +}
     >> +
     >> +FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
     >> +FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*
    ${libdir}/${PN}/tools/.debug"
     >> +
     >> +RDEPENDS_${PN}-ptest = "bash"
     >> --
     >> 2.7.4
     >>
     >> --
     >> _______________________________________________
     >> Openembedded-devel mailing list
     >> [email protected]
    <mailto:[email protected]>
     >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
     >
     >
     >

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

#5 lore raw
Quoted 27 lines · Mingli
Quoted 23 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:28 PM Yu, Mingli <[email protected] <mailto:[email protected]>> wrote:

On 2019年07月25日 21:45, Bruce Ashfield wrote:
> On Thu, Jul 25, 2019 at 3:06 AM <[email protected]
<mailto:[email protected]>> wrote:
>>
>> From: Mingli Yu <[email protected]
<mailto:[email protected]>>
>
> Can you share some details as to why this should be pulled from > meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

Quoted 8 lines
Quoted 4 lines

.. but it is literally churn for the sake of churn.

Meaning, that isn't a great reason to move something. If Armin wanted to put the recipe in meta-oe, he would have done it himself.

^_^, I noticed Armin did try to do this in this thread "[oe] [meta-oe][PATCH 1/2] libseccomp: move lib from meta-security to meta-oe" in Jun 1, 2018.

In that case, follow up to that thread so folks can remember why it didn't happen, or check to see if it was simply forgotten. Putting the maintainers on the cc' from the start of something like this helps immensely.

But I see you added Armin to this thread, so that should be enough.

Bruce

Quoted 138 lines
Quoted 138 lines

Meanwhile, the below yocto compliance check error disappears once we move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it).
Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

Also not a valid reason. We've just fixed meta-virtualization, so there's no need to shuffle something like this around, just to keep another layers compliance check working.

Bruce

    Thanks,

     >
     > It seems to fit the mandate of meta-security quite nicely ;)
     >
     > Is there some sort of dependency issue, or other technical problem
     > that is causing a problem ?
     >
     > Bruce
     >
     >>
     >> Signed-off-by: Mingli Yu <[email protected]
    <mailto:[email protected]>>
     >> ---
     >>   .../recipes-security/libseccomp/files/run-ptest    |  4 +++
     >>   .../libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>                 | 41 ++++++++++++++++++++++
     >>   2 files changed, 45 insertions(+)
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/files/run-ptest
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >>
     >> diff --git a/meta-oe/recipes-security/libseccomp/files/run-ptest
    b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> new file mode 100644
     >> index 0000000..54b4a63
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> @@ -0,0 +1,4 @@
     >> +#!/bin/sh
     >> +
     >> +cd tests
     >> +./regression -a
     >> diff --git
    a/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
    b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> new file mode 100644
     >> index 0000000..dba1be5
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> @@ -0,0 +1,41 @@
     >> +SUMMARY = "interface to seccomp filtering mechanism"
     >> +DESCRIPTION = "The libseccomp library provides and easy to use,
    platform independent,interface to the Linux Kernel's syscall
    filtering mechanism: seccomp."
     >> +SECTION = "security"
     >> +LICENSE = "LGPL-2.1"
     >> +LIC_FILES_CHKSUM =
    "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
     >> +
     >> +SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
     >> +
     >> +SRC_URI =
    "git://github.com/seccomp/libseccomp.git;branch=release-2.4
    <http://github.com/seccomp/libseccomp.git;branch=release-2.4> \
     >> +           file://run-ptest \
     >> +"
     >> +
     >> +S = "${WORKDIR}/git"
     >> +
     >> +inherit autotools-brokensep pkgconfig ptest
     >> +
     >> +PACKAGECONFIG ??= ""
     >> +PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
     >> +
     >> +do_compile_ptest() {
     >> +    oe_runmake -C tests check-build
     >> +}
     >> +
     >> +do_install_ptest() {
     >> +    install -d ${D}${PTEST_PATH}/tests
     >> +    install -d ${D}${PTEST_PATH}/tools
     >> +    for file in $(find tests/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tests/*.tests -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tools/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
     >> +    done
     >> +}
     >> +
     >> +FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
     >> +FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*
    ${libdir}/${PN}/tools/.debug"
     >> +
     >> +RDEPENDS_${PN}-ptest = "bash"
     >> --
     >> 2.7.4
     >>
     >> --
     >> _______________________________________________
     >> Openembedded-devel mailing list
     >> [email protected]
    <mailto:[email protected]>
     >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
     >
     >
     >

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#6 lore raw
Quoted 37 lines · Bruce Ashfield
Quoted 27 lines · Mingli
Quoted 23 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:28 PM Yu, Mingli <[email protected] <mailto:[email protected]>> wrote:

On 2019年07月25日 21:45, Bruce Ashfield wrote:
> On Thu, Jul 25, 2019 at 3:06 AM <[email protected]
<mailto:[email protected]>> wrote:
>>
>> From: Mingli Yu <[email protected]
<mailto:[email protected]>>
>
> Can you share some details as to why this should be pulled from > meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

Quoted 8 lines
Quoted 4 lines

.. but it is literally churn for the sake of churn.

Meaning, that isn't a great reason to move something. If Armin wanted to put the recipe in meta-oe, he would have done it himself.

^_^, I noticed Armin did try to do this in this thread "[oe] [meta-oe][PATCH 1/2] libseccomp: move lib from meta-security to meta-oe" in Jun 1, 2018.

Quoted 6 lines

In that case, follow up to that thread so folks can remember why it didn't happen, or check to see if it was simply forgotten. Putting the maintainers on the cc' from the start of something like this helps immensely.

But I see you added Armin to this thread, so that should be enough.

Hi Bruce,

I'm okay to keep libseccomp under meta-security and can consider moving it to meta-oe if anyone thinks it is worth.

Quoted 19 lines

Bruce

Quoted 16 lines
Quoted 16 lines

Meanwhile, the below yocto compliance check error disappears once we move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it).
Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

I will find other solution to solve the above error related to yocto compliance check.

Thanks,

Quoted 125 lines
Quoted 122 lines
Quoted 122 lines

Also not a valid reason. We've just fixed meta-virtualization, so there's no need to shuffle something like this around, just to keep another layers compliance check working.

Bruce

     Thanks,

      >
      > It seems to fit the mandate of meta-security quite nicely ;)
      >
      > Is there some sort of dependency issue, or other technical problem
      > that is causing a problem ?
      >
      > Bruce
      >
      >>
      >> Signed-off-by: Mingli Yu <[email protected]
     <mailto:[email protected]>>
      >> ---
      >>   .../recipes-security/libseccomp/files/run-ptest    |  4 +++
      >>   .../libseccomp/libseccomp_2.4.1.bb
     <http://libseccomp_2.4.1.bb>                 | 41 ++++++++++++++++++++++
      >>   2 files changed, 45 insertions(+)
      >>   create mode 100644
     meta-oe/recipes-security/libseccomp/files/run-ptest
      >>   create mode 100644
     meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
     <http://libseccomp_2.4.1.bb>
      >>
      >> diff --git a/meta-oe/recipes-security/libseccomp/files/run-ptest
     b/meta-oe/recipes-security/libseccomp/files/run-ptest
      >> new file mode 100644
      >> index 0000000..54b4a63
      >> --- /dev/null
      >> +++ b/meta-oe/recipes-security/libseccomp/files/run-ptest
      >> @@ -0,0 +1,4 @@
      >> +#!/bin/sh
      >> +
      >> +cd tests
      >> +./regression -a
      >> diff --git
     a/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
     <http://libseccomp_2.4.1.bb>
     b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
     <http://libseccomp_2.4.1.bb>
      >> new file mode 100644
      >> index 0000000..dba1be5
      >> --- /dev/null
      >> +++ b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
     <http://libseccomp_2.4.1.bb>
      >> @@ -0,0 +1,41 @@
      >> +SUMMARY = "interface to seccomp filtering mechanism"
      >> +DESCRIPTION = "The libseccomp library provides and easy to use,
     platform independent,interface to the Linux Kernel's syscall
     filtering mechanism: seccomp."
      >> +SECTION = "security"
      >> +LICENSE = "LGPL-2.1"
      >> +LIC_FILES_CHKSUM =
     "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
      >> +
      >> +SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
      >> +
      >> +SRC_URI =
     "git://github.com/seccomp/libseccomp.git;branch=release-2.4
     <http://github.com/seccomp/libseccomp.git;branch=release-2.4> \
      >> +           file://run-ptest \
      >> +"
      >> +
      >> +S = "${WORKDIR}/git"
      >> +
      >> +inherit autotools-brokensep pkgconfig ptest
      >> +
      >> +PACKAGECONFIG ??= ""
      >> +PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
      >> +
      >> +do_compile_ptest() {
      >> +    oe_runmake -C tests check-build
      >> +}
      >> +
      >> +do_install_ptest() {
      >> +    install -d ${D}${PTEST_PATH}/tests
      >> +    install -d ${D}${PTEST_PATH}/tools
      >> +    for file in $(find tests/* -executable -type f); do
      >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
      >> +    done
      >> +    for file in $(find tests/*.tests -type f); do
      >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
      >> +    done
      >> +    for file in $(find tools/* -executable -type f); do
      >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
      >> +    done
      >> +}
      >> +
      >> +FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
      >> +FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*
     ${libdir}/${PN}/tools/.debug"
      >> +
      >> +RDEPENDS_${PN}-ptest = "bash"
      >> --
      >> 2.7.4
      >>
      >> --
      >> _______________________________________________
      >> Openembedded-devel mailing list
      >> [email protected]
     <mailto:[email protected]>
      >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
      >
      >
      >

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

#7 lore raw
In reply to Bruce Ashfield
Quoted 33 lines · Bruce Ashfield
Quoted 25 lines · Mingli
Quoted 22 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:28 PM Yu, Mingli <[email protected] <mailto:[email protected]>> wrote:

On 2019年07月25日 21:45, Bruce Ashfield wrote:
> On Thu, Jul 25, 2019 at 3:06 AM <[email protected]
<mailto:[email protected]>> wrote:
>>
>> From: Mingli Yu <[email protected]
<mailto:[email protected]>>
>
> Can you share some details as to why this should be pulled from > meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

Quoted 7 lines
Quoted 4 lines

.. but it is literally churn for the sake of churn.

Meaning, that isn't a great reason to move something. If Armin wanted to put the recipe in meta-oe, he would have done it himself.

^_^, I noticed Armin did try to do this in this thread "[oe] [meta-oe][PATCH 1/2] libseccomp: move lib from meta-security to meta-oe" in Jun 1, 2018.

Quoted 6 lines

In that case, follow up to that thread so folks can remember why it didn't happen, or check to see if it was simply forgotten. Putting the maintainers on the cc' from the start of something like this helps immensely.

But I see you added Armin to this thread, so that should be enough.

I am fine if we move the recipe. The issue was Khem didn't want the "bash" dependency and I never followed up to clean that up.

I would have responded sooner but this is the first time I have reliable Internet.

- armin

Quoted 141 lines

Bruce

Quoted 136 lines
Quoted 136 lines

Meanwhile, the below yocto compliance check error disappears once we move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it).
Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

Also not a valid reason. We've just fixed meta-virtualization, so there's no need to shuffle something like this around, just to keep another layers compliance check working.

Bruce

    Thanks,

     >
     > It seems to fit the mandate of meta-security quite nicely ;)
     >
     > Is there some sort of dependency issue, or other technical problem
     > that is causing a problem ?
     >
     > Bruce
     >
     >>
     >> Signed-off-by: Mingli Yu <[email protected]
    <mailto:[email protected]>>
     >> ---
     >>   .../recipes-security/libseccomp/files/run-ptest    |  4 +++
     >>   .../libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>                 | 41 ++++++++++++++++++++++
     >>   2 files changed, 45 insertions(+)
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/files/run-ptest
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >>
     >> diff --git a/meta-oe/recipes-security/libseccomp/files/run-ptest
    b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> new file mode 100644
     >> index 0000000..54b4a63
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> @@ -0,0 +1,4 @@
     >> +#!/bin/sh
     >> +
     >> +cd tests
     >> +./regression -a
     >> diff --git
    a/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
    b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> new file mode 100644
     >> index 0000000..dba1be5
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> @@ -0,0 +1,41 @@
     >> +SUMMARY = "interface to seccomp filtering mechanism"
     >> +DESCRIPTION = "The libseccomp library provides and easy to use,
    platform independent,interface to the Linux Kernel's syscall
    filtering mechanism: seccomp."
     >> +SECTION = "security"
     >> +LICENSE = "LGPL-2.1"
     >> +LIC_FILES_CHKSUM =
    "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
     >> +
     >> +SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
     >> +
     >> +SRC_URI =
    "git://github.com/seccomp/libseccomp.git;branch=release-2.4
    <http://github.com/seccomp/libseccomp.git;branch=release-2.4> \
     >> +           file://run-ptest \
     >> +"
     >> +
     >> +S = "${WORKDIR}/git"
     >> +
     >> +inherit autotools-brokensep pkgconfig ptest
     >> +
     >> +PACKAGECONFIG ??= ""
     >> +PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
     >> +
     >> +do_compile_ptest() {
     >> +    oe_runmake -C tests check-build
     >> +}
     >> +
     >> +do_install_ptest() {
     >> +    install -d ${D}${PTEST_PATH}/tests
     >> +    install -d ${D}${PTEST_PATH}/tools
     >> +    for file in $(find tests/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tests/*.tests -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tools/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
     >> +    done
     >> +}
     >> +
     >> +FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
     >> +FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*
    ${libdir}/${PN}/tools/.debug"
     >> +
     >> +RDEPENDS_${PN}-ptest = "bash"
     >> --
     >> 2.7.4
     >>
     >> --
     >> _______________________________________________
     >> Openembedded-devel mailing list
     >> [email protected]
    <mailto:[email protected]>
     >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
     >
     >
     >

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

#8 lore raw
Quoted 42 lines · On Fri, Jul 26, 2019 at 2:00 AM akuster808 <[email protected]> wrote:
Quoted 38 lines · Bruce Ashfield
Quoted 25 lines · Mingli
Quoted 22 lines · Bruce Ashfield

On Thu, Jul 25, 2019 at 10:28 PM Yu, Mingli <[email protected] <mailto:[email protected]>> wrote:

On 2019年07月25日 21:45, Bruce Ashfield wrote:
> On Thu, Jul 25, 2019 at 3:06 AM <[email protected]
<mailto:[email protected]>> wrote:
>>
>> From: Mingli Yu <[email protected]
<mailto:[email protected]>>
>
> Can you share some details as to why this should be pulled from > meta-security into a different repo ?

Considering there is also some security related recipe under meta-oe/recipes-security/, I think it's not strange to add a new one libseccomp and libseccomp also provides a basic common filtering mechanism.

Quoted 7 lines
Quoted 4 lines

.. but it is literally churn for the sake of churn.

Meaning, that isn't a great reason to move something. If Armin wanted to put the recipe in meta-oe, he would have done it himself.

^_^, I noticed Armin did try to do this in this thread "[oe] [meta-oe][PATCH 1/2] libseccomp: move lib from meta-security to meta-oe" in Jun 1, 2018.

In that case, follow up to that thread so folks can remember why it didn't happen, or check to see if it was simply forgotten. Putting the maintainers on the cc' from the start of something like this helps immensely.

Quoted 5 lines
Quoted 1 line

But I see you added Armin to this thread, so that should be enough.

I am fine if we move the recipe. The issue was Khem didn't want the "bash" dependency and I never followed up to clean that up.

I think this cleanup would be good to have before we move this in. It has built well
in preliminary build testing, since there are recipes in meta-oe using this package it
will become a common place to have it so there might be value.

Other way would be to see if security-recipes in meta-oe could be moved out into meta-security

Quoted 151 lines

I would have responded sooner but this is the first time I have reliable Internet.

- armin

Quoted 141 lines

Bruce

Quoted 136 lines
Quoted 136 lines

Meanwhile, the below yocto compliance check error disappears once we move libseccomp from meta-security to meta-oe.
ERROR: Nothing PROVIDES 'libseccomp' (but /buildarea/layers/meta-virtualization/recipes-containers/cri-o/cri-o_git.bb
<http://cri-o_git.bb>
DEPENDS on or otherwise requires it).
Close matches:
libcomps
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.

Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'cri-o', 'libseccomp']

Also not a valid reason. We've just fixed meta-virtualization, so there's no need to shuffle something like this around, just to keep another layers compliance check working.

Bruce

    Thanks,

     >
     > It seems to fit the mandate of meta-security quite nicely ;)
     >
     > Is there some sort of dependency issue, or other technical problem
     > that is causing a problem ?
     >
     > Bruce
     >
     >>
     >> Signed-off-by: Mingli Yu <[email protected]
    <mailto:[email protected]>>
     >> ---
     >>   .../recipes-security/libseccomp/files/run-ptest    |  4 +++
     >>   .../libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>                 | 41 ++++++++++++++++++++++
     >>   2 files changed, 45 insertions(+)
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/files/run-ptest
     >>   create mode 100644
    meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >>
     >> diff --git a/meta-oe/recipes-security/libseccomp/files/run-ptest
    b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> new file mode 100644
     >> index 0000000..54b4a63
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/files/run-ptest
     >> @@ -0,0 +1,4 @@
     >> +#!/bin/sh
     >> +
     >> +cd tests
     >> +./regression -a
     >> diff --git
    a/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
    b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> new file mode 100644
     >> index 0000000..dba1be5
     >> --- /dev/null
     >> +++ b/meta-oe/recipes-security/libseccomp/libseccomp_2.4.1.bb
    <http://libseccomp_2.4.1.bb>
     >> @@ -0,0 +1,41 @@
     >> +SUMMARY = "interface to seccomp filtering mechanism"
     >> +DESCRIPTION = "The libseccomp library provides and easy to use,
    platform independent,interface to the Linux Kernel's syscall
    filtering mechanism: seccomp."
     >> +SECTION = "security"
     >> +LICENSE = "LGPL-2.1"
     >> +LIC_FILES_CHKSUM =
    "file://LICENSE;beginline=0;endline=1;md5=8eac08d22113880357ceb8e7c37f989f"
     >> +
     >> +SRCREV = "fb43972ea1aab24f2a70193fb7445c2674f594e3"
     >> +
     >> +SRC_URI =
    "git://github.com/seccomp/libseccomp.git;branch=release-2.4
    <http://github.com/seccomp/libseccomp.git;branch=release-2.4> \
     >> +           file://run-ptest \
     >> +"
     >> +
     >> +S = "${WORKDIR}/git"
     >> +
     >> +inherit autotools-brokensep pkgconfig ptest
     >> +
     >> +PACKAGECONFIG ??= ""
     >> +PACKAGECONFIG[python] = "--enable-python, --disable-python, python"
     >> +
     >> +do_compile_ptest() {
     >> +    oe_runmake -C tests check-build
     >> +}
     >> +
     >> +do_install_ptest() {
     >> +    install -d ${D}${PTEST_PATH}/tests
     >> +    install -d ${D}${PTEST_PATH}/tools
     >> +    for file in $(find tests/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tests/*.tests -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     >> +    done
     >> +    for file in $(find tools/* -executable -type f); do
     >> +        install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
     >> +    done
     >> +}
     >> +
     >> +FILES_${PN} = "${bindir} ${libdir}/${BPN}.so*"
     >> +FILES_${PN}-dbg += "${libdir}/${PN}/tests/.debug/*
    ${libdir}/${PN}/tools/.debug"
     >> +
     >> +RDEPENDS_${PN}-ptest = "bash"
     >> --
     >> 2.7.4
     >>
     >> --
     >> _______________________________________________
     >> Openembedded-devel mailing list
     >> [email protected]
    <mailto:[email protected]>
     >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
     >
     >
     >

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel