Regression with commit "ath10k: fill the channel survey results for WCN3990 correctly"

PATCH Ben Greear 2 participants 4 messages Aug 21, 2019 Qualcomm Atheros ATH10K wireless driver

Share & tools

Ben Greear

author

2019-08-21 20:56 UTC #0 lore raw

Hello,

I just noticed in 5.2.7+ kernel than this commit below appears to break WMI message for my 10.1 firmware, and based on code inspection, 10.2 will be broken as well.

10.1 struct ends with cycle_count, and 10.2 ends with one 32-bit number after that, but which is not chan_tx_pwr_range.

I guess you need to create your own wmi msg for the WCN3990.

The change to 10.4 chan_info event is also wrong for my relatively new version of 10.4 code, so likely breaks firmware in use. last member in that struct in my 10.4 fw src is 'A_UINT32 rx_11b_mode_data_duration;'

commit 13104929d2ec32aec0552007d55b9e15bc07176b

Author: Rakesh Pillai <[email protected]>
Date:   Wed Oct 17 16:50:03 2018 +0530

ath10k: fill the channel survey results for WCN3990 correctly

drivers/net/wireless/ath/ath10k/wmi.h +8 -0

index 4971d61..58e33ab 100644
@@ -6442,6 +6442,14 @@ struct wmi_chan_info_event {
        __le32 noise_floor;
        __le32 rx_clear_count;
        __le32 cycle_count;
+       __le32 chan_tx_pwr_range;
+       __le32 chan_tx_pwr_tp;
+       __le32 rx_frame_count;
+       __le32 my_bss_rx_cycle_count;
+       __le32 rx_11b_mode_data_duration;
+       __le32 tx_frame_cnt;
+       __le32 mac_clk_mhz;
+
 } __packed;

Thanks,
Ben

Signature · 2 lines

Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com

Ben Greear

author

2019-08-21 21:06 UTC #1 lore raw

Quoted 6 lines · Ben Greear

Hello,
I just noticed in 5.2.7+ kernel than this commit below appears to break WMI message for my 10.1 firmware, and based on code inspection, 10.2 will be broken as well.

Quoted 8 lines

10.1 struct ends with cycle_count, and 10.2 ends with one 32-bit number after that, but which is not chan_tx_pwr_range.
I guess you need to create your own wmi msg for the WCN3990.
The change to 10.4 chan_info event is also wrong for my relatively new version of 10.4 code, so likely breaks firmware in use. last member in that struct in my 10.4 fw src is 'A_UINT32 rx_11b_mode_data_duration;'

Sorry, I mis-read this 10.4 part of the patch, it was not changing the wmi event itself, so probably that part is fine.

Thanks,
Ben

Quoted 33 lines

commit 13104929d2ec32aec0552007d55b9e15bc07176b

Author: Rakesh Pillai <[email protected]>
Date:   Wed Oct 17 16:50:03 2018 +0530

ath10k: fill the channel survey results for WCN3990 correctly

drivers/net/wireless/ath/ath10k/wmi.h +8 -0

index 4971d61..58e33ab 100644
@@ -6442,6 +6442,14 @@ struct wmi_chan_info_event {
         __le32 noise_floor;
         __le32 rx_clear_count;
         __le32 cycle_count;
+       __le32 chan_tx_pwr_range;
+       __le32 chan_tx_pwr_tp;
+       __le32 rx_frame_count;
+       __le32 my_bss_rx_cycle_count;
+       __le32 rx_11b_mode_data_duration;
+       __le32 tx_frame_cnt;
+       __le32 mac_clk_mhz;
+
  } __packed;

Thanks,
Ben

Signature · 2 lines

Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com

Rakesh Pillai

2019-08-21 21:12 UTC #2 lore raw

Hi Ben,
Can you please check https://patchwork.kernel.org/patch/10844513/ ?
This change fixes the below mentioned regression. A different structure is made for tlv specific event handling.

Thanks,
Rakesh Pillai.

Quoted 55 lines · Ben Greear

Quoted 6 lines · Ben Greear
Hello,
I just noticed in 5.2.7+ kernel than this commit below appears to break WMI message for my 10.1 firmware, and based on code inspection, 10.2 will be broken as well.
Quoted 8 lines
10.1 struct ends with cycle_count, and 10.2 ends with one 32-bit number after that, but which is not chan_tx_pwr_range.
I guess you need to create your own wmi msg for the WCN3990.
The change to 10.4 chan_info event is also wrong for my relatively new version of 10.4 code, so likely breaks firmware in use. last member in that struct in my 10.4 fw src is 'A_UINT32 rx_11b_mode_data_duration;'
Sorry, I mis-read this 10.4 part of the patch, it was not changing the wmi event itself, so probably that part is fine.
Thanks,
Ben
Quoted 33 lines
commit 13104929d2ec32aec0552007d55b9e15bc07176b
Author: Rakesh Pillai <[email protected]>
Date:   Wed Oct 17 16:50:03 2018 +0530
ath10k: fill the channel survey results for WCN3990 correctly
drivers/net/wireless/ath/ath10k/wmi.h +8 -0
index 4971d61..58e33ab 100644
@@ -6442,6 +6442,14 @@ struct wmi_chan_info_event {
         __le32 noise_floor;
         __le32 rx_clear_count;
         __le32 cycle_count;
+       __le32 chan_tx_pwr_range;
+       __le32 chan_tx_pwr_tp;
+       __le32 rx_frame_count;
+       __le32 my_bss_rx_cycle_count;
+       __le32 rx_11b_mode_data_duration;
+       __le32 tx_frame_cnt;
+       __le32 mac_clk_mhz;
+
  } __packed;
 
 
Thanks,
Ben

Ben Greear

author

2019-08-21 21:15 UTC #3 lore raw

Looks like it should work.

Why is this rotting in patchwork?

Thanks
Ben

Quoted 65 lines · Rakesh Pillai

Hi Ben,
Can you please check https://patchwork.kernel.org/patch/10844513/ ?
This change fixes the below mentioned regression. A different structure is made for tlv specific event handling.
Thanks,
Rakesh Pillai.
Quoted 55 lines · Ben Greear
Quoted 6 lines · Ben Greear
Hello,
I just noticed in 5.2.7+ kernel than this commit below appears to break WMI message for my 10.1 firmware, and based on code inspection, 10.2 will be broken as well.
Quoted 8 lines
10.1 struct ends with cycle_count, and 10.2 ends with one 32-bit number after that, but which is not chan_tx_pwr_range.
I guess you need to create your own wmi msg for the WCN3990.
The change to 10.4 chan_info event is also wrong for my relatively new version of 10.4 code, so likely breaks firmware in use. last member in that struct in my 10.4 fw src is 'A_UINT32 rx_11b_mode_data_duration;'
Sorry, I mis-read this 10.4 part of the patch, it was not changing the wmi event itself, so probably that part is fine.
Thanks,
Ben
Quoted 33 lines
commit 13104929d2ec32aec0552007d55b9e15bc07176b
Author: Rakesh Pillai <[email protected]>
Date:   Wed Oct 17 16:50:03 2018 +0530
ath10k: fill the channel survey results for WCN3990 correctly
drivers/net/wireless/ath/ath10k/wmi.h +8 -0
index 4971d61..58e33ab 100644
@@ -6442,6 +6442,14 @@ struct wmi_chan_info_event {
         __le32 noise_floor;
         __le32 rx_clear_count;
         __le32 cycle_count;
+       __le32 chan_tx_pwr_range;
+       __le32 chan_tx_pwr_tp;
+       __le32 rx_frame_count;
+       __le32 my_bss_rx_cycle_count;
+       __le32 rx_11b_mode_data_duration;
+       __le32 tx_frame_cnt;
+       __le32 mac_clk_mhz;
+
  } __packed;
 
 
Thanks,
Ben

Signature · 8 lines

Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k