target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN
Subsystems (3)
PATCH 1/1 target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN
In case command ring buffer becomes inconsistent, tcmu sets device flag TCMU_DEV_BIT_BROKEN.
If the bit is set, tcmu rejects new commands from lio core with TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE, and no longer processes completions from the ring.
The reset_ring attribute can be used to completely clean up the command ring, so after reset_ring the ring no longer is inconsistent.
Therefore reset_ring also should reset bit TCMU_DEV_BIT_BROKEN to allow normal processing.
--- drivers/target/target_core_user.c | 1 + 1 file changed, 1 insertion(+)
drivers/target/target_core_user.c +1 -0
@@ -2073,6 +2073,7 @@ static void tcmu_reset_ring(struct tcmu_dev *udev, u8 err_level) mb->cmd_tail =0 ; mb->cmd_head =0 ;tcmu_flush_dcache_range (mb,sizeof (*mb)); +clear_bit (TCMU_DEV_BIT_BROKEN , &udev->flags);del_timer (&udev->cmd_timer);
Signature · 1 line
2.12.3
Quoted 23 lines · Bodo Stroesser
In case command ring buffer becomes inconsistent, tcmu sets device flag
TCMU_DEV_BIT_BROKEN.
If the bit is set, tcmu rejects new commands from lio core withTCM_LOGICAL_UNIT_COMMUNICATION_FAILURE, and no longer processes completions from the ring.
Thereset_ringattribute can be used to completely clean up the command ring, so afterreset_ringthe ring no longer is inconsistent.Therefore
reset_ringalso should reset bitTCMU_DEV_BIT_BROKENto allow normal processing.Signed-off-by Bodo Stroesser <[email protected]>--- drivers/target/target_core_user.c | 1 + 1 file changed, 1 insertion(+)drivers/target/target_core_user.c +0
-0
drivers/target/target_core_user.c static void tcmu_reset_ring(struct tcmu_dev *udev, u8 err_level) · line 2079
Quoted 7 lines
drivers/target/target_core_user.c +1
-0@@ -2073,6 +2073,7 @@ static void tcmu_reset_ring(struct tcmu_dev *udev, u8 err_level) mb->cmd_tail =0 ; mb->cmd_head =0 ;tcmu_flush_dcache_range (mb,sizeof (*mb)); +clear_bit (TCMU_DEV_BIT_BROKEN , &udev->flags);del_timer (&udev->cmd_timer);
Martin K. Petersen
AppliedBodo,
Quoted 9 lines
In case command ring buffer becomes inconsistent, tcmu sets device flag
TCMU_DEV_BIT_BROKEN. If the bit is set, tcmu rejects new commands from lio core withTCM_LOGICAL_UNIT_COMMUNICATION_FAILURE, and no longer processes completions from the ring. Thereset_ringattribute can be used to completely clean up the command ring, so afterreset_ringthe ring no longer is inconsistent.Therefore
reset_ringalso should reset bitTCMU_DEV_BIT_BROKENto allow normal processing.
Applied to 5.7/scsi-fixes, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering