virtio_balloon: fix up endian-ness for free cmd id
Subsystems (3)
Michael S. Tsirkin
maintainerPATCH 1/1 virtio_balloon: fix up endian-ness for free cmd id
free cmd id is read using virtio endian, spec says all fields in balloon are LE. Fix it up.
Fixes 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Signed-off-by Michael S. Tsirkin <[email protected]>
--- drivers/virtio/virtio_balloon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/virtio/virtio_balloon.c +5 -1
@@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloon *vb)static u32 virtio_balloon_cmd_id_received (struct virtio_balloon *vb) {if (test_and_clear_bit (VIRTIO_BALLOON_CONFIG_READ_CMD_ID , - &vb->config_read_bitmap)) + &vb->config_read_bitmap)) { virtio_cread(vb->vdev, struct virtio_balloon_config, free_page_hint_cmd_id, &vb->cmd_id_received_cache); +/* Legacy balloon config space is LE, unlike all other devices. */ +if (!virtio_has_feature (vb->vdev,VIRTIO_F_VERSION_1 )) + vb->cmd_id_received_cache =le32_to_cpu ((__force __le32 )vb->cmd_id_received_cache); + }return vb->cmd_id_received_cache; }
Signature · 1 line
MST
Quoted 21 lines · Michael S. Tsirkin
free cmd id is read using virtio endian, spec says all fields in balloon are LE. Fix it up.
Fixes 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_balloon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/virtio/virtio_balloon.c +1
-1@@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloon *vb)static u32 virtio_balloon_cmd_id_received (struct virtio_balloon *vb) {if (test_and_clear_bit (VIRTIO_BALLOON_CONFIG_READ_CMD_ID , - &vb->config_read_bitmap)) + &vb->config_read_bitmap)) {
drivers/virtio/virtio_balloon.c static int init_vqs(struct virtio_balloon *vb) · line 591
Quoted 10 lines
drivers/virtio/virtio_balloon.c +4
-0virtio_cread(vb->vdev, struct virtio_balloon_config, free_page_hint_cmd_id, &vb->cmd_id_received_cache); +/* Legacy balloon config space is LE, unlike all other devices. */ +if (!virtio_has_feature (vb->vdev,VIRTIO_F_VERSION_1 )) + vb->cmd_id_received_cache =le32_to_cpu ((__force __le32 )vb->cmd_id_received_cache); + }return vb->cmd_id_received_cache; }
Signature · 3 lines
Thanks, David / dhildenb
Quoted 16 lines · Michael S. Tsirkin
free cmd id is read using virtio endian, spec says all fields in balloon are LE. Fix it up.
Fixes 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_balloon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/virtio/virtio_balloon.c +0
-0@@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloon *vb)static u32 virtio_balloon_cmd_id_received (struct virtio_balloon *vb)
drivers/virtio/virtio_balloon.c static int init_vqs(struct virtio_balloon *vb) · line 587
Quoted 10 lines
drivers/virtio/virtio_balloon.c +4
-1{if (test_and_clear_bit (VIRTIO_BALLOON_CONFIG_READ_CMD_ID , - &vb->config_read_bitmap)) + &vb->config_read_bitmap)) { virtio_cread(vb->vdev, struct virtio_balloon_config, free_page_hint_cmd_id, &vb->cmd_id_received_cache); +/* Legacy balloon config space is LE, unlike all other devices. */ +if (!virtio_has_feature (vb->vdev,VIRTIO_F_VERSION_1 )) + vb->cmd_id_received_cache =le32_to_cpu ((__force __le32 )vb->cmd_id_received_cache);
Seems it exceeds 80 character length.
Reviewed-by Wei Wang <[email protected]>
Best,
Wei
Quoted 20 lines · Michael S. Tsirkin
free cmd id is read using virtio endian, spec says all fields in balloon are LE. Fix it up.
Fixes 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/virtio/virtio_balloon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/virtio/virtio_balloon.c +1
-1@@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloon *vb)static u32 virtio_balloon_cmd_id_received (struct virtio_balloon *vb) {if (test_and_clear_bit (VIRTIO_BALLOON_CONFIG_READ_CMD_ID , - &vb->config_read_bitmap)) + &vb->config_read_bitmap)) {
drivers/virtio/virtio_balloon.c static int init_vqs(struct virtio_balloon *vb) · line 591
Quoted 10 lines
drivers/virtio/virtio_balloon.c +4
-0virtio_cread(vb->vdev, struct virtio_balloon_config, free_page_hint_cmd_id, &vb->cmd_id_received_cache); +/* Legacy balloon config space is LE, unlike all other devices. */ +if (!virtio_has_feature (vb->vdev,VIRTIO_F_VERSION_1 )) + vb->cmd_id_received_cache =le32_to_cpu ((__force __le32 )vb->cmd_id_received_cache); + }return vb->cmd_id_received_cache; }
Acked-by Jason Wang <[email protected]>