Skip to contentSkip to conversation

qga: Fix some style problems

PATCH In review AlexChen 3 participants 5 messages Oct 26, 2020 – Feb 14, 2021

lore
Share & tools
lore

AlexChen

author
#0 lore raw

cover qga: Fix some style problems

Fix some error style problems found by checkpatch.pl.

alexchen (4):
qga: Add spaces around operator
qga: Delete redundant spaces
qga: Open brace '{' following struct go on the same
qga: switch and case should be at the same indent

 qga/channel-win32.c  |  6 ++---
 qga/commands-posix.c |  4 +--
 qga/commands-win32.c | 28 ++++++++++-----------
 qga/commands.c       |  4 +--
 qga/main.c           | 59 ++++++++++++++++++++++----------------------
 5 files changed, 50 insertions(+), 51 deletions(-)
Signature · 1 line
2.19.1
author
#1 lore raw

Kindly ping.

Quoted 15 lines · AlexChen

Fix some error style problems found by checkpatch.pl.

alexchen (4):
qga: Add spaces around operator
qga: Delete redundant spaces
qga: Open brace '{' following struct go on the same
qga: switch and case should be at the same indent

 qga/channel-win32.c  |  6 ++---
 qga/commands-posix.c |  4 +--
 qga/commands-win32.c | 28 ++++++++++-----------
 qga/commands.c       |  4 +--
 qga/main.c           | 59 ++++++++++++++++++++++----------------------
 5 files changed, 50 insertions(+), 51 deletions(-)
Reviewed-by on the v1 series
#2 lore raw
In reply to AlexChen
Quoted 8 lines · AlexChen

Fix some error style problems found by checkpatch.pl.

alexchen (4):
qga: Add spaces around operator
qga: Delete redundant spaces
qga: Open brace '{' following struct go on the same
qga: switch and case should be at the same indent

Quoted 8 lines
 qga/channel-win32.c  |  6 ++---
 qga/commands-posix.c |  4 +--
 qga/commands-win32.c | 28 ++++++++++-----------
 qga/commands.c       |  4 +--
 qga/main.c           | 59 ++++++++++++++++++++++----------------------
 5 files changed, 50 insertions(+), 51 deletions(-)
Signature · 1 line
Marc-André Lureau
#3 lore raw

Le 04/11/2020 à 08:46, Marc-André Lureau a écrit :

Quoted 20 lines · On Mon, Oct 26, 2020 at 1:16 PM AlexChen <[email protected]…

Fix some error style problems found by checkpatch.pl <http://checkpatch.pl>.

alexchen (4):
  qga: Add spaces around operator
  qga: Delete redundant spaces
  qga: Open brace '{' following struct go on the same
  qga: switch and case should be at the same indent

 qga/channel-win32.c  |  6 ++---
 qga/commands-posix.c |  4 +--
 qga/commands-win32.c | 28 ++++++++++----------- qga/commands.c       |  4 +--
 qga/main.c           | 59 ++++++++++++++++++++++---------------------- 5 files changed, 50 insertions(+), 51 deletions(-)

Quoted 1 line
Reviewed-by Marc-André Lureau <[email protected] <mailto:[email protected]>>

Where are the patches?

I don't find them in my mailbox and patchew didn't receive them:

https://patchew.org/QEMU/[email protected]/

Thanks,
Laurent

#4 lore raw

Hi

Quoted 24 lines · Laurent Vivier
Quoted 3 lines · Marc-André Lureau

On Mon, Oct 26, 2020 at 1:16 PM AlexChen <[email protected] <mailto:

Quoted 2 lines · [email protected]>> wrote:

Fix some error style problems found by checkpatch.pl <

http://checkpatch.pl>.

Quoted 7 lines

alexchen (4):
qga: Add spaces around operator
qga: Delete redundant spaces
qga: Open brace '{' following struct go on the same
qga: switch and case should be at the same indent

Quoted 5 lines

qga/channel-win32.c | 6 ++--- qga/commands-posix.c | 4 +-- qga/commands-win32.c | 28 ++++++++++-----------
qga/commands.c | 4 +--
qga/main.c | 59

++++++++++++++++++++++----------------------

Quoted 3 lines
     5 files changed, 50 insertions(+), 51 deletions(-)
Quoted 10 lines
Quoted 1 line

[email protected]>>

Where are the patches?

I don't find them in my mailbox and patchew didn't receive them:

https://patchew.org/QEMU/[email protected]/

It was received on the mailing list:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/index.html
(I got them in my mailbox as well)

Signature · 1 line
Marc-André Lureau