Skip to contentSkip to conversation

Add size property of EEPROM device

DISCUSSION he.huang 2 participants 3 messages Nov 25, 2020 – Nov 26, 2020

lore
Share & tools
lore

he.huang

author
#0 lore raw

Hi All,
I'm going to add the "size" property to the fru device .json file under entity-manager/configurations.

The requirement comes from:
When we write to the EEPROM we need the size to ensure that we won't write out of the range and return the correct complete code.

Here is an example for review:
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/38532

If the proposal gets approved I will add the 'size' property to the other .json file under entity-manager/configurations.

Could you please help to review and let me know if you have any comments. Thanks a lot.

2020-11-24

Helen.huang

#1 lore raw
Quoted 3 lines · he.huang

The requirement comes from:
When we write to the EEPROM we need the size to ensure that we won't write out of the range and return the correct complete code.

Don't the eeprom drivers prevent this?

author
#2 lore raw

Hi Brad,
Yes, eeprom driver could help the requirement partially.
As Ed's comments on the patch, we still need the size in the upper level such as IPMI command handler, to differentiate the error between writing failed and writing out of the range, and return the correct complete code. Thanks.

2020-11-26

Helen.huang

发件人:Brad Bishop <[email protected]>
发送时间:2020-11-25 23:36
主题:Re: Add size property of EEPROM device 收件人:"he.huang"<[email protected]>,"ed"<[email protected]>,"jae.hyun.yoo"<[email protected]>,"vernon.mauery"<[email protected]>,"openbmc"<[email protected]> 抄送:

Quoted 3 lines · he.huang

The requirement comes from:
When we write to the EEPROM we need the size to ensure that we won't write out of the range and return the correct complete code.

Don't the eeprom drivers prevent this?