build.sh: Remove deprecated CROSS_COMPILE
PATCH 1/2 build.sh: Remove deprecated CROSS_COMPILE
The CROSS_COMPILE was no longer used by ltp since 400ac9bbe20.
--- build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
build.sh +1 -1
@@ -64,7 +64,7 @@ build_cross() fi echo "===== cross-compile ${host} ${1}-tree build into $PREFIX =====" - build $1 $2 "--host=$host" CROSS_COMPILE="${host}-" + build $1 $2 "--host=$host" } build()
Signature · 1 line
2.30.0
PATCH 2/2 build.sh: support compiler with path prefix
Previously, specify a compiler with path prefix will lead to a error like below:
ltp$ ./build.sh -t cross -c /opt/gcc-4.9.3-64-gnu/bin/mips64el-linux-gcc
...
It was created by ltp configure LTP_VERSION, which was generated by GNU Autoconf 2.69. Invocation command line was
$ ./configure --with-open-posix-testsuite --with-realtime-testsuite --prefix=/home/lizj/ltp-install --host=/opt/gcc-4.9.3-64-gnu/bin/mips64el-linux ... #define VERSION "LTP_VERSION"
configure: exit 1
--- build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
build.sh +1 -1
@@ -57,7 +57,7 @@ build_native() build_cross() { - local host="${CC%-gcc}" + local host=$(basename "${CC%-gcc}") if [ "$host" = "gcc" ]; then echo "Invalid CC variable for cross compilation: $CC (clang not supported)" >&2 exit 1
Signature · 1 line
2.30.0
PATCH 1/2 build.sh: Remove deprecated CROSS_COMPILE
In reply to Li ZhijianHi Li,
Thanks for your work, I pushed the patch set. :-)
Best Regards,
Xiao Yang
Quoted 20 lines · Li Zhijian
The
CROSS_COMPILEwas no longer used by ltp since400ac9bbe20.Signed-off-by Li Zhijian<[email protected]>--- build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)build.sh +1
-1@@ -64,7 +64,7 @@ build_cross() fi echo "===== cross-compile ${host} ${1}-tree build into $PREFIX =====" - build $1 $2 "--host=$host" CROSS_COMPILE="${host}-" + build $1 $2 "--host=$host" } build()
PATCH 1/2 build.sh: Remove deprecated CROSS_COMPILE
In reply to Li ZhijianHi Petr,
I have merged it because CROSS_COMPILE seems unneeded. Please tell me if you have any objection.
Best Regards,
Xiao Yang
Quoted 20 lines · Li Zhijian
The
CROSS_COMPILEwas no longer used by ltp since400ac9bbe20.Signed-off-by Li Zhijian<[email protected]>--- build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)build.sh +1
-1@@ -64,7 +64,7 @@ build_cross() fi echo "===== cross-compile ${host} ${1}-tree build into $PREFIX =====" - build $1 $2 "--host=$host" CROSS_COMPILE="${host}-" + build $1 $2 "--host=$host" } build()
PATCH 1/2 build.sh: Remove deprecated CROSS_COMPILE
In reply to Li ZhijianHi Li,
Quoted 12 lines
The
CROSS_COMPILEwas no longer used by ltp since400ac9bbe20.Signed-off-by Li Zhijian <[email protected]>--- build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)build.sh +0
-0
build.sh build_cross() · line 67
Quoted 4 lines
build.sh +0
-1@@ -64,7 +64,7 @@ build_cross() fi echo "===== cross-compile ${host} ${1}-tree build into $PREFIX =====" - build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
I looked what would require CROSS_COMPILE support. It's somehow duplicate to autoconf --host parameter.
Although it wouldn't be difficult to add a support into configure.ac and include/mk/config.mk.in via AC_ARG_VAR, it's use would require:
1) either migrate everything to pkg-config (but libnuma and libaio does not support it) and use PKG_CONFIG_LIBDIR
2) fix host cpu detection in m4/ltp-host-cpu.m4 (parse CROSS_COMPILE).
=> IMHO it's not worth of doing it, thus good we removed it.
Kind regards,
Petr
Quoted 4 lines
build.sh +1
-0+ build $1 $2 "--host=$host" } build()