io_uring: abort file assignment prior to assigning creds
Jens Axboe
maintainerPATCH 1/1 io_uring: abort file assignment prior to assigning creds
We need to either restore creds properly if we fail on the file assignment, or just do the file assignment first instead. Let's do the latter as it's simpler, should make no difference here for file assignment.
Reported-by [email protected]
Fixes 6bf9c47a3989 ("io_uring: defer file assignment")
Signed-off-by Jens Axboe <[email protected]>
---
fs/io_uring.c +3 -2
@@ -7111,13 +7111,14 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags)const struct cred *creds =NULL ;int ret; +if (unlikely (!io_assign_file (req, issue_flags))) +return -EBADF ; +if (unlikely ((req->flags &REQ_F_CREDS ) && req->creds !=current_cred ())) creds =override_creds (req->creds);if (!io_op_defs[req->opcode].audit_skip)audit_uring_entry (req->opcode); -if (unlikely (!io_assign_file (req, issue_flags))) -return -EBADF ;switch (req->opcode) {case IORING_OP_NOP :
Signature · 1 line
Jens Axboe