blk-mq: remove unused code exist in blk_mq_dispatch_rq_list
PATCH 1/1 blk-mq: remove unused code exist in blk_mq_dispatch_rq_list
Once .queue_rq return BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE, we will insert the rq back to list, and will return false since '(!list_empty)' always be true. The latter check seems unused.
Signed-off-by yangerkun <[email protected]>
--- block/blk-mq.c | 7 ------- 1 file changed, 7 deletions(-)
block/blk-mq.c +0 -7
@@ -1361,13 +1361,6 @@ bool blk_mq_dispatch_rq_list(struct request_queue *q, struct list_head *list, }else blk_mq_update_dispatch_busy (hctx, false); -/* -* If the host/device is unable to accept more work, inform the -* caller of that. -*/ -if (ret ==BLK_STS_RESOURCE || ret ==BLK_STS_DEV_RESOURCE ) -return false; -return (queued + errors) !=0 ; }
Signature · 1 line
2.25.4
Quoted 30 lines · yangerkun
Once .queue_rq return
BLK_STS_RESOURCEorBLK_STS_DEV_RESOURCE, we will insert the rq back to list, and will return false since '(!list_empty)' always be true. The latter check seems unused.Signed-off-by yangerkun <[email protected]>--- block/blk-mq.c | 7 ------- 1 file changed, 7 deletions(-)block/blk-mq.c +0
-7@@ -1361,13 +1361,6 @@ bool blk_mq_dispatch_rq_list(struct request_queue *q, struct list_head *list, }else blk_mq_update_dispatch_busy (hctx, false); -/* -* If the host/device is unable to accept more work, inform the -* caller of that. -*/ -if (ret ==BLK_STS_RESOURCE || ret ==BLK_STS_DEV_RESOURCE ) -return false; -return (queued + errors) !=0 ; }Signature · 1 line
2.25.4
Reviewed-by Ming Lei <[email protected]>
Signature · 1 line
Ming
Jens Axboe
maintainerQuoted 3 lines · yangerkun
Once .queue_rq return
BLK_STS_RESOURCEorBLK_STS_DEV_RESOURCE, we will insert the rq back to list, and will return false since '(!list_empty)' always be true. The latter check seems unused.
This check is already gone in for-5.9/block
Signature · 1 line
Jens Axboe