RDS: Heap OOB write in rds_message_alloc_sgs()

From: Mohamed Ghannam <[email protected]>

When args->nr_local is 0, nr_pages gets also 0 due some size calculation via rds_rm_size(), which is later used to allocate pages for DMA, this bug produces a heap Out-Of-Bound write access to a specific memory region.

---
 net/rds/rdma.c | 3 +++
 1 file changed, 3 insertions(+)

index bc2f1e0977d6..40a733566eb7 100644
@@ -525,6 +525,9 @@ int rds_rdma_extra_size(struct rds_rdma_args *args)
 
 	local_vec = (struct rds_iovec __user *)(unsigned long) args->local_vec_addr;
 
+	if (args->nr_local == 0)
+		return -EINVAL;
+
 	/* figure out the number of pages in the vector */
 	for (i = 0; i < args->nr_local; i++) {
 		if (copy_from_user(&vec, &local_vec[i],

2.14.1

From: [email protected]
Date: Tue, 2 Jan 2018 19:44:34 +0000

Applied and queued up for -stable, thanks.