selftests: prctl: Add new prctl test for PR_SET_NAME
PATCH v2 1/1 selftests: prctl: Add new prctl test for PR_SET_NAME
This patch will add the new test, which covers the prctl call PR_SET_NAME command. The test tries to give a name using the PR_SET_NAME call and then confirm it that it changed correctly by using PR_GET_NAME. It also tries to rename it with empty name.In the test PR_GET_NAME is tested by passing null pointer to it and check its behaviour.
---
changes since v1:
-Used TASK_COMM_LEN instead of using numerical value 16.
--- tools/testing/selftests/prctl/Makefile | 2 +- .../selftests/prctl/set-process-name.c | 62 +++++++++++++++++++ 2 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/prctl/set-process-name.c
tools/testing/selftests/prctl/Makefile +1 -1
@@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) ifeq ($(ARCH),x86) TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \ - disable-tsc-test set-anon-vma-name-test + disable-tsc-test set-anon-vma-name-test set-process-name all: $(TEST_PROGS) include ../lib.mk
tools/testing/selftests/prctl/set-process-name.c new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
2.34.1
Shuah Khan
maintainerQuoted 11 lines · Osama Muhammad
This patch will add the new test, which covers the prctl call
PR_SET_NAMEcommand. The test tries to give a name using thePR_SET_NAMEcall and then confirm it that it changed correctly by usingPR_GET_NAME. It also tries to rename it with empty name.In the testPR_GET_NAMEis tested by passing null pointer to it and check its behaviour.Signed-off-by Osama Muhammad <[email protected]>---
changes since v1:
-UsedTASK_COMM_LENinstead of using numerical value 16.
Please add linux/sched.h here as an include to pull this. It is good to add an explicit include as opposed taking a chance on it being included from another include.
thanks,
-- Shuah
Hi all,
I looked into it and tried to use TASK_COMM_LEN in the test. Even though I included "linux/sched.h '', I was not able to compile the test because it couldn't find it in the header file.
I dived deep into the issue and turns out header file mapped in /usr/include/linux/sched.h is actually mapped to /include/uapi/linux/sched.h[1] in linux source,
where TASK_COMM_LEN is not even defined. Instead TASK_COMM_LEN is defined in /include/linux/sched.h which is not mapped to any header files in
userspace(/(/usr/include/linux).
I also tried to find the TASK_COM_LEN in /usr/include/linux/ but I couldn't find it. Following are the search results.
grep -rnw '/usr/include/linux/' -e 'TASK_COMM_LEN"
RESULTS OF COMMAND :- /usr/include/linux/taskstats.h:38:#define TS_COMM_LEN 32 /* should be >= TASK_COMM_LEN
Based on this information, I have two questions:
1. Would this require a fix to move 'TASK_COMM_LEN' macro from /include/linux/sched.h to UAPI headers /include/uapi/linux/sched.h.
2. Is there any other way to access TASK_COMM_LEN in the selftest that I'm not aware of?
[1]:-https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.h
Thanks,
Osama
Quoted 20 lines · Shuah Khan
Quoted 11 lines · Osama Muhammad
This patch will add the new test, which covers the prctl call
PR_SET_NAMEcommand. The test tries to give a name using thePR_SET_NAMEcall and then confirm it that it changed correctly by usingPR_GET_NAME. It also tries to rename it with empty name.In the testPR_GET_NAMEis tested by passing null pointer to it and check its behaviour.Signed-off-by Osama Muhammad <[email protected]>---
changes since v1:
-UsedTASK_COMM_LENinstead of using numerical value 16.Please add
linux/sched.hhere as an include to pull this. It is good to add an explicit include as opposed taking a chance on it being included from another include.thanks,
-- Shuah
Shuah Khan
maintainerQuoted 23 lines · Osama Muhammad
Hi all,
I looked into it and tried to use
TASK_COMM_LENin the test. Even though I included "linux/sched.h'', I was not able to compile the test because it couldn't find it in the header file.
I dived deep into the issue and turns out header file mapped in/usr/include/linux/sched.his actually mapped to /include/uapi/linux/sched.h[1] in linux source,
whereTASK_COMM_LENis not even defined. InsteadTASK_COMM_LENis defined in /include/linux/sched.h which is not mapped to any header files in
userspace(/(/usr/include/linux).
I also tried to find theTASK_COM_LENin/usr/include/linux/but I couldn't find it. Following are the search results.
grep -rnw '/usr/include/linux/' -e 'TASK_COMM_LEN"
RESULTS OF COMMAND :- /usr/include/linux/taskstats.h:38:#defineTS_COMM_LEN32 /* should be >=TASK_COMM_LEN
Based on this information, I have two questions:
1. Would this require a fix to move 'TASK_COMM_LEN' macro from /include/linux/sched.h to UAPI headers /include/uapi/linux/sched.h.
2. Is there any other way to accessTASK_COMM_LENin the selftest that I'm not aware of?
Quoted 2 lines
[1]:-https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.h
The best source is Linux mainline.
Take a look at test files that include linux/sched.h
arm64/abi/tpidr2.c is one of them.
Did you install headers before compiling the test?
make headers_install
thanks,
-- Shuah
Hi,
Yes, I did install the latest kernel headers and TASK_COMM_LEN is not accessible in userspace.
I looked into the test which uses TASK_COMM_LEN but the test defines it in its own header file.
Example: https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13
TASK_COMM_LEN is defined in include/linux/sched.h, but this header file is not exposed to userspace.
TASK_COMM_LEN is not defined in /include/uapi/linux/sched.h which is exposed to userspace kernel headers.
Please find the link to the header file exposed to user space :- -https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.h
As for arm64/abi/tpidr2.c It includes linux/sched.h which will be /include/uapi/linux/sched.h because the user space program is including it.
So it also cannot use TASK_COMM_LEN directly.
Regards,
Osama
Quoted 41 lines · Shuah Khan
Quoted 23 lines · Osama Muhammad
Hi all,
I looked into it and tried to use
TASK_COMM_LENin the test. Even though I included "linux/sched.h'', I was not able to compile the test because it couldn't find it in the header file.
I dived deep into the issue and turns out header file mapped in/usr/include/linux/sched.his actually mapped to /include/uapi/linux/sched.h[1] in linux source,
whereTASK_COMM_LENis not even defined. InsteadTASK_COMM_LENis defined in /include/linux/sched.h which is not mapped to any header files in
userspace(/(/usr/include/linux).
I also tried to find theTASK_COM_LENin/usr/include/linux/but I couldn't find it. Following are the search results.
grep -rnw '/usr/include/linux/' -e 'TASK_COMM_LEN"
RESULTS OF COMMAND :- /usr/include/linux/taskstats.h:38:#defineTS_COMM_LEN32 /* should be >=TASK_COMM_LEN
Based on this information, I have two questions:
1. Would this require a fix to move 'TASK_COMM_LEN' macro from /include/linux/sched.h to UAPI headers /include/uapi/linux/sched.h.
2. Is there any other way to accessTASK_COMM_LENin the selftest that I'm not aware of?Quoted 2 lines
[1]:-https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.h
The best source is Linux mainline.
Take a look at test files that include
linux/sched.h
arm64/abi/tpidr2.cis one of them.Did you install headers before compiling the test?
makeheaders_installthanks,
-- Shuah
Hi Shuah,
Any feedback on this patch?.
Thanks,
Osama
Quoted 69 lines · Osama Muhammad
Hi,
Yes, I did install the latest kernel headers and
TASK_COMM_LENis not accessible in userspace.I looked into the test which uses
TASK_COMM_LENbut the test defines it in its own header file.Example: https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13
TASK_COMM_LENis defined ininclude/linux/sched.h, but this header file is not exposed to userspace.
TASK_COMM_LENis not defined in /include/uapi/linux/sched.h which is exposed to userspace kernel headers.
Please find the link to the header file exposed to user space :- -https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.hAs for
arm64/abi/tpidr2.cIt includeslinux/sched.hwhich will be /include/uapi/linux/sched.h because the user space program is including it.
So it also cannot useTASK_COMM_LENdirectly.Regards,
OsamaQuoted 41 lines · Shuah Khan
Quoted 23 lines · Osama Muhammad
Hi all,
I looked into it and tried to use
TASK_COMM_LENin the test. Even though I included "linux/sched.h'', I was not able to compile the test because it couldn't find it in the header file.
I dived deep into the issue and turns out header file mapped in/usr/include/linux/sched.his actually mapped to /include/uapi/linux/sched.h[1] in linux source,
whereTASK_COMM_LENis not even defined. InsteadTASK_COMM_LENis defined in /include/linux/sched.h which is not mapped to any header files in
userspace(/(/usr/include/linux).
I also tried to find theTASK_COM_LENin/usr/include/linux/but I couldn't find it. Following are the search results.
grep -rnw '/usr/include/linux/' -e 'TASK_COMM_LEN"
RESULTS OF COMMAND :- /usr/include/linux/taskstats.h:38:#defineTS_COMM_LEN32 /* should be >=TASK_COMM_LEN
Based on this information, I have two questions:
1. Would this require a fix to move 'TASK_COMM_LEN' macro from /include/linux/sched.h to UAPI headers /include/uapi/linux/sched.h.
2. Is there any other way to accessTASK_COMM_LENin the selftest that I'm not aware of?Quoted 2 lines
[1]:-https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.h
The best source is Linux mainline.
Take a look at test files that include
linux/sched.h
arm64/abi/tpidr2.cis one of them.Did you install headers before compiling the test?
makeheaders_installthanks,
-- Shuah
Hi,
Thank you for the patch. This patch cleanly applies on next-20230627.
Unrelated to this patch:
I'm not sure if this patch was written against linux next. Always try to send patches against latest next tag from following repo:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
Quoted 78 lines · Osama Muhammad
Hi Shuah,
Any feedback on this patch?.
Thanks,
OsamaQuoted 69 lines · Osama Muhammad
Hi,
Yes, I did install the latest kernel headers and
TASK_COMM_LENis not accessible in userspace.I looked into the test which uses
TASK_COMM_LENbut the test defines it in its own header file.Example: https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13
TASK_COMM_LENis defined ininclude/linux/sched.h, but this header file is not exposed to userspace.
TASK_COMM_LENis not defined in /include/uapi/linux/sched.h which is exposed to userspace kernel headers.
Please find the link to the header file exposed to user space :- -https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.hAs for
arm64/abi/tpidr2.cIt includeslinux/sched.hwhich will be /include/uapi/linux/sched.h because the user space program is including it.
So it also cannot useTASK_COMM_LENdirectly.Regards,
OsamaQuoted 41 lines · Shuah Khan
Quoted 23 lines · Osama Muhammad
Hi all,
I looked into it and tried to use
TASK_COMM_LENin the test. Even though I included "linux/sched.h'', I was not able to compile the test because it couldn't find it in the header file.
I dived deep into the issue and turns out header file mapped in/usr/include/linux/sched.his actually mapped to /include/uapi/linux/sched.h[1] in linux source,
whereTASK_COMM_LENis not even defined. InsteadTASK_COMM_LENis defined in /include/linux/sched.h which is not mapped to any header files in
userspace(/(/usr/include/linux).
I also tried to find theTASK_COM_LENin/usr/include/linux/but I couldn't find it. Following are the search results.
grep -rnw '/usr/include/linux/' -e 'TASK_COMM_LEN"
RESULTS OF COMMAND :- /usr/include/linux/taskstats.h:38:#defineTS_COMM_LEN32 /* should be >=TASK_COMM_LEN
Based on this information, I have two questions:
1. Would this require a fix to move 'TASK_COMM_LEN' macro from /include/linux/sched.h to UAPI headers /include/uapi/linux/sched.h.
2. Is there any other way to accessTASK_COMM_LENin the selftest that I'm not aware of?Quoted 2 lines
[1]:-https://elixir.bootlin.com/linux/v5.15.116/source/include/uapi/linux/sched.h
The best source is Linux mainline.
Take a look at test files that include
linux/sched.h
arm64/abi/tpidr2.cis one of them.Did you install headers before compiling the test?
makeheaders_installthanks,
-- Shuah
Signature · 2 lines
BR, Muhammad Usama Anjum
Shuah Khan
maintainerQuoted 8 lines · Osama Muhammad
Hi Shuah,
Any feedback on this patch?.
Thanks,
Osama
Please don't top post when you are responding on kernel mailing lists. It gets very difficult to follow the comments in the email thread.
Quoted 11 lines · Osama Muhammad
Quoted 10 lines
Hi,
Yes, I did install the latest kernel headers and
TASK_COMM_LENis not accessible in userspace.I looked into the test which uses
TASK_COMM_LENbut the test defines it in its own header file.Example: https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13
bfp test does things differently because its dependencies on run-time environment.
Quoted 3 lines
Quoted 3 lines
TASK_COMM_LENis defined ininclude/linux/sched.h, but this header file is not exposed to userspace.
Correct. you can include linux/sched.h like other tests do Take a look at tools/testing/selftests/clone3
thanks,
-- Shuah
Shuah Khan
maintainerQuoted 30 lines · Shuah Khan
Quoted 8 lines · Osama Muhammad
Hi Shuah,
Any feedback on this patch?.
Thanks,
OsamaPlease don't top post when you are responding on kernel mailing lists. It gets very difficult to follow the comments in the email thread.
Quoted 11 lines · Osama Muhammad
Quoted 10 lines
Hi,
Yes, I did install the latest kernel headers and
TASK_COMM_LENis not accessible in userspace.I looked into the test which uses
TASK_COMM_LENbut the test defines it in its own header file.Example: https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13
bfp test does things differently because its dependencies on run-time environment.
Quoted 1 line
Quoted 1 line
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
TASK_COMM_LENis defined ininclude/linux/sched.h, but this header file is not exposed to userspace.Correct. you can include
linux/sched.hlike other tests do Take a look attools/testing/selftests/clone3
You are right about TASK_COMM_LEN not visible to user-space. This patch has been applied to linux-kselftest next for 6.6-rc1
thanks,
-- Shuah
Quoted 9 lines · Shuah Khan
Quoted 8 lines · Osama Muhammad
This patch will add the new test, which covers the prctl call
PR_SET_NAMEcommand. The test tries to give a name using thePR_SET_NAMEcall and then confirm it that it changed correctly by usingPR_GET_NAME. It also tries to rename it with empty name.In the testPR_GET_NAMEis tested by passing null pointer to it and check its behaviour.Signed-off-by Osama Muhammad <[email protected]>
Quoted 7 lines
Quoted 3 lines
---
changes since v1:
-UsedTASK_COMM_LENinstead of using numerical value 16.Please add
linux/sched.hhere as an include to pull this. It is good to add an explicit include as opposed taking a chance on it being included from another include.
TASK_COMM_LEN is defined in include/linux/sched.h. It is only to be used by the kernel.
If we look at include/uapi/linux/sched.h, TASK_COMM_LEN isn't defined. So this test looks good to me.
Quoted 3 lines
thanks,
-- Shuah
Signature · 2 lines
BR, Muhammad Usama Anjum
Unrelated to this patch:
You can build the user header files by running make headers in a kernel repository to process the kernel header files. They are generated in <kernel_source>/include/uapi Then run make -C tools/testing/selftests/prctl to build the test etc.
Quoted 7 lines · Osama Muhammad
This patch will add the new test, which covers the prctl call
PR_SET_NAMEcommand. The test tries to give a name using thePR_SET_NAMEcall and then confirm it that it changed correctly by usingPR_GET_NAME. It also tries to rename it with empty name.In the testPR_GET_NAMEis tested by passing null pointer to it and check its behaviour.Signed-off-by Osama Muhammad <[email protected]>
Quoted 92 lines
---
changes since v1:
-UsedTASK_COMM_LENinstead of using numerical value 16.--- tools/testing/selftests/prctl/Makefile | 2 +- .../selftests/prctl/set-process-name.c | 62 +++++++++++++++++++ 2 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/prctl/set-process-name.ctools/testing/selftests/prctl/Makefile +1
-1@@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) ifeq ($(ARCH),x86) TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \ - disable-tsc-test set-anon-vma-name-test + disable-tsc-test set-anon-vma-name-test set-process-name all: $(TEST_PROGS) include ../lib.mktools/testing/selftests/prctl/set-process-name.c new file +62
-0@@ -0,0 +1,62 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* This test covers the PR_SET_NAME functionality of prctl calls +*/ + +#include <errno.h> +#include <sys/prctl.h> +#include <string.h> + +#include "../kselftest_harness.h" + +#define CHANGE_NAME "changename" +#define EMPTY_NAME "" +#define TASK_COMM_LEN 16 + +int set_name (char *name) +{ +int res; + + res =prctl (PR_SET_NAME , name,NULL ,NULL ,NULL ); + +if (res <0 ) +return -errno; +return res; +} + +int check_is_name_correct (char *check_name) +{ +char name[TASK_COMM_LEN ]; +int res; + + res =prctl (PR_GET_NAME , name,NULL ,NULL ,NULL ); + +if (res <0 ) +return -errno; + +return !strcmp (name, check_name); +} + +int check_null_pointer (char *check_name) +{ +char *name =NULL ; +int res; + + res =prctl (PR_GET_NAME , name,NULL ,NULL ,NULL ); + +return res; +} + +TEST (rename_process) { + +EXPECT_GE (set_name (CHANGE_NAME ),0 ); +EXPECT_TRUE (check_is_name_correct (CHANGE_NAME )); + +EXPECT_GE (set_name (EMPTY_NAME ),0 ); +EXPECT_TRUE (check_is_name_correct (EMPTY_NAME )); + +EXPECT_GE (set_name (CHANGE_NAME ),0 ); +EXPECT_LT (check_null_pointer (CHANGE_NAME ),0 ); +} + +TEST_HARNESS_MAIN
Signature · 2 lines
BR, Muhammad Usama Anjum