Skip to contentSkip to conversation

INFO: trying to register non-static key in io_cqring_ev_posted (2)

DISCUSSION Jens Axboe 1 participant 1 message Mar 31, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jens Axboe

author maintainer
#1 lore raw
Quoted 31 lines · Hillf Danton

On Tue, 31 Mar 2020 04:14:03 -0700

Quoted 19 lines

syzbot has bisected this bug to:

commit b41e98524e424d104aa7851d54fd65820759875a

Author: Jens Axboe <[email protected]>
Date:   Mon Feb 17 16:52:41 2020 +0000

io_uring: add per-task callback handler

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=115adadbe00000
start commit:   673b41e0 staging/octeon: fix up merge error
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=135adadbe00000
console output: https://syzkaller.appspot.com/x/log.txt?x=155adadbe00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=acf766c0e3d3f8c6
dashboard link: https://syzkaller.appspot.com/bug?extid=0c3370f235b74b3cfd97
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13ac1b9de00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10449493e00000
Quoted 4 lines
Reported-by [email protected]
Fixes b41e98524e42 ("io_uring: add per-task callback handler")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Looks like another line is missed in that work.

fs/io_uring.c static int io_sq_thread(void *data) · line 5968

Quoted 7 lines
fs/io_uring.c +1 -0
@@ -5962,6 +5962,7 @@ static int io_sq_thread(void *data)
 				}
 				if (current->task_works) {
 					task_work_run();
+					finish_wait(&ctx->sqo_wait, &wait);
 					continue;
 				}
 				if (signal_pending(current))

Can you send this as a properly formatted patch? That indeed looks like the issue.

Signature · 1 line
Jens Axboe