Skip to contentSkip to conversation

ARM: stm32: Use firmware property instead of loadables

PATCH Superseded Michal Simek 5 participants 8 messages Oct 5, 2020 – Nov 25, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

There shouldn't be a need to use loadables propertyn because u-boot can be pointed by firmware property. This change should also speedup boot process because loadables property is list of strings which code is going through. On the other hand firmware can just point to one image.

---

Changes in v2:
- Also add dhcor
- Fix subject typo

Only done based on grepping the code. Please retest.

---
 board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its | 8 ++++----
 board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its +4 -4
index 905be57dffd7..dfe89bfad67e 100644
@@ -39,28 +39,28 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-pdk2_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-2 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-pdk2_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-3 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-drc02_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
 		config-4 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-drc02_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its +1 -1
index 7419684f5599..0ea10a14972e 100644
@@ -31,7 +31,7 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "arrow,stm32mp15xx-avenger96_somrev0_boardrev1";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
Signature · 1 line
2.28.0
#1 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

Hi Michael and Marek,

Quoted 80 lines

From: U-Boot <[email protected]> On Behalf Of Michal Simek
Sent: lundi 5 octobre 2020 11:37

There shouldn't be a need to use loadables propertyn because u-boot can be pointed by firmware property. This change should also speedup boot process because loadables property is list of strings which code is going through. On the other hand firmware can just point to one image.

---

Changes in v2:
- Also add dhcor
- Fix subject typo

Only done based on grepping the code. Please retest.

---
 board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its | 8 ++++----
board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its +4 -4
index 905be57dffd7..dfe89bfad67e 100644
@@ -39,28 +39,28 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-
 pdk2_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-2 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-
 pdk2_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-3 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-
 drc02_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
 		config-4 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-
 drc02_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its +1 -2
index 7419684f5599..0ea10a14972e 100644
@@ -31,7 +31,7 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "arrow,stm32mp15xx-
 avenger96_somrev0_boardrev1";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
--
Quoted 1 line

2.28.0

Marek, I don't see any objection, it is also ok for you ? And can you test dh board with this patch ?

Thanks

Patrick

#2 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

Quoted 1 line · Patrick DELAUNAY

Hi Michael and Marek,

[...]

Quoted 2 lines

Marek, I don't see any objection, it is also ok for you ? And can you test dh board with this patch ?

I plan to test that , yes. Note that I am still not entirely sure whether loadables and firmware are the same thing with both SPL fit and SPL fit-full, I recall there was some strange difference in behavior.

#3 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

In reply to Michal Simek

Hi Patrick

Quoted 61 lines · Michal Simek

There shouldn't be a need to use loadables propertyn because u-boot can be pointed by firmware property. This change should also speedup boot process because loadables property is list of strings which code is going through. On the other hand firmware can just point to one image.

---

Changes in v2:
- Also add dhcor
- Fix subject typo

Only done based on grepping the code. Please retest.

---
 board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its | 8 ++++----
 board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its +4 -4
index 905be57dffd7..dfe89bfad67e 100644
@@ -39,28 +39,28 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-pdk2_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-2 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-pdk2_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 
 		config-3 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-drc02_somrev0_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
 		config-4 {
 			/* DT+SoM+board model */
 			description = "dh,stm32mp15xx-dhcom-drc02_somrev1_boardrev0";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-2";
 		};
 
board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its +0 -0
index 7419684f5599..0ea10a14972e 100644

board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its line 37

Quoted 8 lines
board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its +1 -1
@@ -31,7 +31,7 @@
 		config-1 {
 			/* DT+SoM+board model */
 			description = "arrow,stm32mp15xx-avenger96_somrev0_boardrev1";
-			loadables = "uboot";
+			firmware = "uboot";
 			fdt = "fdt-1";
 		};
 

Thanks

#4 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

Quoted 7 lines · Patrice CHOTARD

Hi Patrick

Quoted 4 lines · Michal Simek

There shouldn't be a need to use loadables propertyn because u-boot can be pointed by firmware property. This change should also speedup boot process because loadables property is list of strings which code is going through. On the other hand firmware can just point to one image.

Note that this patch currently cannot be tested because SPL fitImage loading is broken on arm32, see [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" .

#5 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

Hi Marek,

st 21. 10. 2020 v 14:31 odes?latel Marek Vasut <[email protected]> napsal:

Quoted 13 lines · Patrice CHOTARD
Quoted 7 lines

Hi Patrick

Quoted 4 lines · Michal Simek

There shouldn't be a need to use loadables propertyn because u-boot can be pointed by firmware property. This change should also speedup boot process because loadables property is list of strings which code is going through. On the other hand firmware can just point to one image.

Note that this patch currently cannot be tested because SPL fitImage loading is broken on arm32, see [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" .

Is this fixed now?

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
#6 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

Quoted 1 line · Michal Simek

Hi Marek,

Hi,

Quoted 11 lines

st 21. 10. 2020 v 14:31 odes?latel Marek Vasut <[email protected]> napsal:

Quoted 10 lines · Patrice CHOTARD
Quoted 7 lines

Hi Patrick

Quoted 4 lines · Michal Simek

There shouldn't be a need to use loadables propertyn because u-boot can be pointed by firmware property. This change should also speedup boot process because loadables property is list of strings which code is going through. On the other hand firmware can just point to one image.

Quoted 5 lines
Quoted 3 lines

Note that this patch currently cannot be tested because SPL fitImage loading is broken on arm32, see [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" .

Is this fixed now?

Yes.

I would prefer this patch to be applied for next though.

#7 lore raw

PATCH v2 1/1 ARM: stm32: Use firmware property instead of loadables

Quoted 23 lines · Marek Vasut
Quoted 1 line · Michal Simek

Hi Marek,

Hi,

Quoted 18 lines

st 21. 10. 2020 v 14:31 odes?latel Marek Vasut <[email protected]> napsal:

Quoted 16 lines · Patrice CHOTARD
Quoted 10 lines

Hi Patrick

Quoted 7 lines · Michal Simek

There shouldn't be a need to use loadables propertyn because u-boot can be
pointed by firmware property. This change should also speedup boot process
because loadables property is list of strings which code is going through.
On the other hand firmware can just point to one image.

Note that this patch currently cannot be tested because SPL fitImage loading is broken on arm32, see [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" .

Quoted 5 lines
Quoted 1 line

Is this fixed now?

Yes.

I would prefer this patch to be applied for next though.

Not a problem for me.

Thanks,
Michal