Skip to contentSkip to conversation

wifi: rtw88: usb: Fix disconnection after beacon loss

PATCH In review Bitterblue Smith 2 participants 4 messages Apr 29, 2024 – May 9, 2024 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: rtw88: usb: Fix disconnection after beacon loss

When there is beacon loss, for example due to unrelated Bluetooth devices transmitting music nearby, the wifi connection dies soon after the first beacon loss message:

Apr 28 20:47:14 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:15 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:24 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:25 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:34 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:35 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1

When the beacon loss happens, mac80211 makes rtw88 transmit a QOS NULL frame and asks to confirm the ACK status. Even though rtw88 confirms to mac80211 that the QOS NULL was transmitted successfully, the connection still dies. This is because rtw88 is handing the QOS NULL back to mac80211 with skb->data pointing to the headroom (the TX descriptor) instead of ieee80211_hdr.

Fix the disconnection by moving skb->data to the correct position before ieee80211_tx_status_irqsafe().

The problem was observed with RTL8811AU (TP-Link Archer T2U Nano) and the potential future rtw88_8821au driver. Also tested with RTL8811CU (Tenda U9).

---
 drivers/net/wireless/realtek/rtw88/usb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/realtek/rtw88/usb.c +2 -0
index 3ba7b81c6080..1dfe7c6ae4ba 100644
@@ -278,6 +278,8 @@ static void rtw_usb_write_port_tx_complete(struct urb *urb)
 		info = IEEE80211_SKB_CB(skb);
 		tx_data = rtw_usb_get_tx_data(skb);
 
+		skb_pull(skb, rtwdev->chip->tx_pkt_desc_sz);
+
 		/* enqueue to wait for tx report */
 		if (info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) {
 			rtw_tx_report_enqueue(rtwdev, skb, tx_data->sn);
Signature · 1 line
2.44.0
maintainer
#1 lore raw

+Cc: Martin for rtw88 SDIO that seems have the same problem

Quoted 44 lines · Bitterblue Smith

When there is beacon loss, for example due to unrelated Bluetooth devices transmitting music nearby, the wifi connection dies soon after the first beacon loss message:

Apr 28 20:47:14 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:15 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:24 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:25 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:34 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:35 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1

When the beacon loss happens, mac80211 makes rtw88 transmit a QOS NULL frame and asks to confirm the ACK status. Even though rtw88 confirms to mac80211 that the QOS NULL was transmitted successfully, the connection still dies. This is because rtw88 is handing the QOS NULL back to mac80211 with skb->data pointing to the headroom (the TX descriptor) instead of ieee80211_hdr.

Fix the disconnection by moving skb->data to the correct position before ieee80211_tx_status_irqsafe().

The problem was observed with RTL8811AU (TP-Link Archer T2U Nano) and the potential future rtw88_8821au driver. Also tested with RTL8811CU (Tenda U9).

---
 drivers/net/wireless/realtek/rtw88/usb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/realtek/rtw88/usb.c +0 -0
index 3ba7b81c6080..1dfe7c6ae4ba 100644

drivers/net/wireless/realtek/rtw88/usb.c static void rtw_usb_write_port_tx_complete(struct urb *urb) · line 282

Quoted 5 lines
drivers/net/wireless/realtek/rtw88/usb.c +2 -0
@@ -278,6 +278,8 @@ static void rtw_usb_write_port_tx_complete(struct urb *urb)
                info = IEEE80211_SKB_CB(skb);
                tx_data = rtw_usb_get_tx_data(skb);
 
+               skb_pull(skb, rtwdev->chip->tx_pkt_desc_sz);
+

There are two cases of arguments of skb_push() for USB:
1. skb_push(skb, chip->tx_pkt_desc_sz);
2. skb_push(skb, headsize);

   headsize = pkt_info->offset ? pkt_info->offset : desclen;
      pkt_info->offset = chip->tx_pkt_desc_sz;
      desclen = chip->tx_pkt_desc_sz;

Eventually all are chip->tx_pkt_desc_sz, but spend a little time to ensure this. Could you test and have another patch to change above case (2) to (1)?

Quoted 5 lines
drivers/net/wireless/realtek/rtw88/usb.c +0 -1
                /* enqueue to wait for tx report */
                if (info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) {
                        rtw_tx_report_enqueue(rtwdev, skb, tx_data->sn);
--

2.44.0

#2 lore raw
Quoted 55 lines · Ping-Ke Shih

+Cc: Martin for rtw88 SDIO that seems have the same problem

Quoted 44 lines · Bitterblue Smith

When there is beacon loss, for example due to unrelated Bluetooth devices transmitting music nearby, the wifi connection dies soon after the first beacon loss message:

Apr 28 20:47:14 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:15 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:24 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:25 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:34 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:35 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1

When the beacon loss happens, mac80211 makes rtw88 transmit a QOS NULL frame and asks to confirm the ACK status. Even though rtw88 confirms to mac80211 that the QOS NULL was transmitted successfully, the connection still dies. This is because rtw88 is handing the QOS NULL back to mac80211 with skb->data pointing to the headroom (the TX descriptor) instead of ieee80211_hdr.

Fix the disconnection by moving skb->data to the correct position before ieee80211_tx_status_irqsafe().

The problem was observed with RTL8811AU (TP-Link Archer T2U Nano) and the potential future rtw88_8821au driver. Also tested with RTL8811CU (Tenda U9).

---
 drivers/net/wireless/realtek/rtw88/usb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/realtek/rtw88/usb.c +0 -0
index 3ba7b81c6080..1dfe7c6ae4ba 100644

drivers/net/wireless/realtek/rtw88/usb.c static void rtw_usb_write_port_tx_complete(struct urb *urb) · line 282

Quoted 5 lines
drivers/net/wireless/realtek/rtw88/usb.c +2 -0
@@ -278,6 +278,8 @@ static void rtw_usb_write_port_tx_complete(struct urb *urb)
                info = IEEE80211_SKB_CB(skb);
                tx_data = rtw_usb_get_tx_data(skb);
 
+               skb_pull(skb, rtwdev->chip->tx_pkt_desc_sz);
+

There are two cases of arguments of skb_push() for USB:
1. skb_push(skb, chip->tx_pkt_desc_sz);

Quoted 8 lines
2. skb_push(skb, headsize);
   headsize = pkt_info->offset ? pkt_info->offset : desclen;
      pkt_info->offset = chip->tx_pkt_desc_sz;
      desclen = chip->tx_pkt_desc_sz;

Eventually all are chip->tx_pkt_desc_sz, but spend a little time to ensure this. Could you test and have another patch to change above case (2) to (1)?

I see what you mean. I will make it another patch, because the skb from case 2 is not sent to mac80211.

Quoted 6 lines
Quoted 5 lines
drivers/net/wireless/realtek/rtw88/usb.c +0 -1
                /* enqueue to wait for tx report */
                if (info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS) {
                        rtw_tx_report_enqueue(rtwdev, skb, tx_data->sn);
--

2.44.0

maintainer
#3 lore raw
In reply to Bitterblue Smith
Quoted 29 lines · Bitterblue Smith

When there is beacon loss, for example due to unrelated Bluetooth devices transmitting music nearby, the wifi connection dies soon after the first beacon loss message:

Apr 28 20:47:14 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:15 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:24 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:25 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
Apr 28 20:47:34 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-BEACON-LOSS
Apr 28 20:47:35 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
 CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1

When the beacon loss happens, mac80211 makes rtw88 transmit a QOS NULL frame and asks to confirm the ACK status. Even though rtw88 confirms to mac80211 that the QOS NULL was transmitted successfully, the connection still dies. This is because rtw88 is handing the QOS NULL back to mac80211 with skb->data pointing to the headroom (the TX descriptor) instead of ieee80211_hdr.

Fix the disconnection by moving skb->data to the correct position before ieee80211_tx_status_irqsafe().

Quoted 6 lines

The problem was observed with RTL8811AU (TP-Link Archer T2U Nano) and the potential future rtw88_8821au driver. Also tested with RTL8811CU (Tenda U9).

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

28818b4d871b wifi: rtw88: usb: Fix disconnection after beacon loss

---
https://github.com/pkshih/rtw.git