Skip to contentSkip to conversation

common/Kconfig: sort HAS_*

PATCH In review Jan Beulich 2 participants 2 messages Sep 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/Kconfig: sort HAS_*

Later additions look to have been put at the end, with MEM_ACCESS* somewhere in the middle. Re-sort this part of the file, in the hope that future additions will be made noticing the intentions here.

xen/common/Kconfig +13 -13
@@ -34,16 +34,11 @@ config HAS_EX_TABLE
 config HAS_FAST_MULTIPLY
 	bool
 
-config MEM_ACCESS_ALWAYS_ON
+config HAS_IOPORTS
 	bool
 
-config MEM_ACCESS
-	def_bool MEM_ACCESS_ALWAYS_ON
-	prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
-	---help---
-
-	  Framework to configure memory access types for guests and receive
-	  related events in userspace.
+config HAS_KEXEC
+	bool
 
 config HAS_MEM_PAGING
 	bool
@@ -51,17 +46,22 @@ config HAS_MEM_PAGING
 config HAS_PDX
 	bool
 
-config HAS_UBSAN
+config HAS_SCHED_GRANULARITY
 	bool
 
-config HAS_KEXEC
+config HAS_UBSAN
 	bool
 
-config HAS_IOPORTS
+config MEM_ACCESS_ALWAYS_ON
 	bool
 
-config HAS_SCHED_GRANULARITY
-	bool
+config MEM_ACCESS
+	def_bool MEM_ACCESS_ALWAYS_ON
+	prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
+	---help---
+
+	  Framework to configure memory access types for guests and receive
+	  related events in userspace.
 
 config NEEDS_LIBELF
 	bool
Acked-by on v1 1/1
#1 lore raw

Hi Jan,

Quoted 5 lines · Jan Beulich

Later additions look to have been put at the end, with MEM_ACCESS* somewhere in the middle. Re-sort this part of the file, in the hope that future additions will be made noticing the intentions here.

Cheers,

Quoted 52 lines
xen/common/Kconfig +13 -13
@@ -34,16 +34,11 @@ config HAS_EX_TABLE
  config HAS_FAST_MULTIPLY
  	bool
 
-config MEM_ACCESS_ALWAYS_ON
+config HAS_IOPORTS
  	bool
 
-config MEM_ACCESS
-	def_bool MEM_ACCESS_ALWAYS_ON
-	prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
-	---help---
-
-	  Framework to configure memory access types for guests and receive
-	  related events in userspace.
+config HAS_KEXEC
+	bool
 
  config HAS_MEM_PAGING
  	bool
@@ -51,17 +46,22 @@ config HAS_MEM_PAGING
  config HAS_PDX
  	bool
 
-config HAS_UBSAN
+config HAS_SCHED_GRANULARITY
  	bool
 
-config HAS_KEXEC
+config HAS_UBSAN
  	bool
 
-config HAS_IOPORTS
+config MEM_ACCESS_ALWAYS_ON
  	bool
 
-config HAS_SCHED_GRANULARITY
-	bool
+config MEM_ACCESS
+	def_bool MEM_ACCESS_ALWAYS_ON
+	prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
+	---help---
+
+	  Framework to configure memory access types for guests and receive
+	  related events in userspace.
 
  config NEEDS_LIBELF
  	bool
Signature · 1 line
Julien Grall